On Sat, 29 Jul 2023 00:12:45 GMT, Andy Goryachev wrote:
> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
> (using Math.floor), see for instance
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
> methods Region.snapPortionX/Y().
Are you s
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
> they are rarely modified. These are re-used by caching them in a new class
> `ImmutablePseudoClassSetsCache`.
>
> In order to make this work, `BitSet` had to be cleaned up. It made
> assumptions about the collection
On Sat, 29 Jul 2023 13:57:41 GMT, Kevin Rushforth wrote:
>> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
>> (using Math.floor), see for instance
>> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
>> methods Region.snapPortionX/Y().
>
> m
On Wed, 6 Sep 2023 23:03:46 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Sat, 29 Jul 2023 00:12:45 GMT, Andy Goryachev wrote:
> Introduces Region.snapInnerSpaceX/Y() methods for dealing with inner space
> (using Math.floor), see for instance
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753), using existing
> methods Region.snapPortionX/Y().
I have a
On Wed, 6 Sep 2023 21:52:22 GMT, Kevin Rushforth wrote:
> I left a few comments on the API docs.
>
> I tested this on Ubuntu 16.04 Linux (yes, I know it's old). It doesn't pick
> up a change to the theme, but only reports the new value the next time I run
> the program.
>
> The serious issue
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Sat, 2 Sep 2023 13:09:14 GMT, Marius Hanl wrote:
>> This PR adds a test that verifies the `SkinBase.layoutChildren(..)` method
>> with different scales.
>> While not explicitly documented, this method will receive the snapped and
>> correctly calculated x, y, width and height values, so that
On Wed, 6 Sep 2023 20:41:25 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 21:15:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Wed, 6 Sep 2023 20:40:31 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
>> 472:
>>
>>> 470: *
>>> 471: * Windows
>>> 472: * {@code Windows.SPI.HighContrast}{@link
>>> Boolean}
>>
>> would it be p
On Wed, 6 Sep 2023 17:22:11 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Eclipse .classpath file
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> 47
On Wed, 6 Sep 2023 19:34:05 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fire only a single invalidation event
>
> tests/manual/events/PlatformPreferencesTest.java line 46:
>
>> 44: import
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Wed, 6 Sep 2023 19:14:55 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
I think this proposal makes a lot of sense.
Having the trait interfaces inner classes of Trait clearly narrows down
semantics. "Trait" might be too generic, maybe FxTrait or something like that?
Just a thought.
What other traits/properties should we include?
Converting https://github.com/ope
On Wed, 6 Sep 2023 19:08:51 GMT, Michael Strauß wrote:
>> sorry, that's not exactly what I meant. Platform preferences gets
>> invalidated multiple times, but only the first time the value(s) are changed
>> - all the other invalidations in the same batch have values unchanged.
>> Is it possib
On Wed, 6 Sep 2023 19:14:55 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 9 Aug 2023 18:41:32 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Example
>>
>> .button {
>> -fx-background-color: dodgerblue;
>> }
>>
>> .button:hover {
>> -fx-background-color:
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Wed, 6 Sep 2023 19:07:19 GMT, Andy Goryachev wrote:
> One more question: are there currently any OS version specific differences in
> the Preferences keys? Like going from Win10 to Win11, or from macOS 12.* to
> 13.* ?
All of the `Windows.UIColor.*` mappings are available starting with Wind
On Wed, 6 Sep 2023 19:01:28 GMT, Andy Goryachev wrote:
> Another question, certainly out of scope for this PR. In Windows, we have
> display orientation and Scale settings. Changing those result in change
> updates sent via Screen.getScreens(), but Screen, while having DPI and scale
> fields,
On Wed, 6 Sep 2023 18:14:02 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 18:27:01 GMT, Andy Goryachev wrote:
>> Fixed.
>
> sorry, that's not exactly what I meant. Platform preferences gets
> invalidated multiple times, but only the first time the value(s) are changed
> - all the other invalidations in the same batch have values unchanged.
> Is i
On Wed, 6 Sep 2023 18:14:02 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 18:22:38 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS Description, I generated this PR by running the same
> copyright tool we use to update the jfx repo, with a slight modification to
> not filter out those files that already had "Copyright.*2023", since those
> ar
As mentioned in the JBS Description, I generated this PR by running the same
copyright tool we use to update the jfx repo, with a slight modification to not
filter out those files that already had "Copyright.*2023", since those are the
ones that need to be fixed up for incorrect formatting.
I m
On Wed, 6 Sep 2023 18:07:31 GMT, Michael Strauß wrote:
>> tests/manual/events/PlatformPreferencesTest.java line 85:
>>
>>> 83: textArea.setText("preferences = " +
>>> formatPrefs(cachedPreferences.entrySet().stream()));
>>> 84:
>>> 85: Platform.getPreferences().addListener(
>>
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote:
>> JDK-8315409: Fix jfx-tests so they work with latest jfx build
>
> Alexandre Iline has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressing copyright issues.
I just now ran our co
On Wed, 6 Sep 2023 17:31:06 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Eclipse .classpath file
>
> tests/manual/events/PlatformPreferencesTest.java line 85:
>
>> 83: textA
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request with a new targe
On Tue, 5 Sep 2023 23:35:04 GMT, Andy Goryachev wrote:
>> I think we should indeed document _all_ possible preferences for the
>> platform toolkit implementations we control. Of course, this means that we
>> need to keep this list in sync with the actual implementation.
>
> +1
>
> we could put
On Wed, 6 Sep 2023 00:14:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 00:14:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 00:14:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 31 Aug 2023 20:22:09 GMT, Alexandre Iline
wrote:
> JDK-8315409: Fix jfx-tests so they work with latest jfx build
This pull request has now been integrated.
Changeset: 9a7df0b5
Author:Alexandre Iline
URL:
https://git.openjdk.org/jfx-tests/commit/9a7df0b57cb8ce035b3221a24a20d
On Wed, 6 Sep 2023 00:01:29 GMT, Michael Strauß wrote:
>> would it make sense to add this explanation to javadoc, even though it's not
>> a public API?
>
> I've added the following sentence:
>
> Callers should assume that the returned map is immutable, while
> implementations should
> either r
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao
wrote:
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Scr
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote:
>> JDK-8315409: Fix jfx-tests so they work with latest jfx build
>
> Alexandre Iline has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressing copyright issues.
There are still 122 m
On Mon, 4 Sep 2023 10:47:02 GMT, Karthik P K wrote:
> Made changes to use Util::waitForIdle instead of Toolkit::firePulse in system
> tests. The test will wait for default value of 10 pulses to complete in the
> scene before executing the subsequent statements.
This pull request has now been i
On Wed, 6 Sep 2023 16:02:08 GMT, Jose Pereda wrote:
> Clean backport of 8311185: VirtualFlow jump when cellcount changes
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: 07955dd2
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit/07955dd28
Clean backport of 8311185: VirtualFlow jump when cellcount changes
Reviewed-by: angorya, kcr
-
Commit messages:
- 8311185: VirtualFlow jump when cellcount changes
Changes: https://git.openjdk.org/jfx17u/pull/163/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=163&range=00
On Wed, 6 Sep 2023 14:23:39 GMT, Jose Pereda wrote:
> Almost clean backport of 8311127: Regression: The fix for TableView and
> TreeTableView menu button affects all table column headers
> Reviewed-by: angorya
>
> There was a conflict with the insertion point of the test in
> TreeTableViewTest
On Wed, 6 Sep 2023 14:23:39 GMT, Jose Pereda wrote:
> Almost clean backport of 8311127: Regression: The fix for TableView and
> TreeTableView menu button affects all table column headers
> Reviewed-by: angorya
>
> There was a conflict with the insertion point of the test in
> TreeTableViewTest
On Wed, 6 Sep 2023 00:14:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 00:14:45 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Sep 2023 05:58:22 GMT, Karthik P K wrote:
>> Made changes to use Util::waitForIdle instead of Toolkit::firePulse in
>> system tests. The test will wait for default value of 10 pulses to complete
>> in the scene before executing the subsequent statements.
>
> Karthik P K has updated th
On Wed, 6 Sep 2023 00:05:58 GMT, Michael Strauß wrote:
>> one [possible] use case is when different versions of the native platform
>> have different types (int32/int64 ?).
>> or, if the property value is String with the semantics of an integer.
>>
>> Of course, the app dev can always request a
On Mon, 4 Sep 2023 13:15:47 GMT, Karthik P K wrote:
> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
> `StackedAreaChart` to check if the line and fill elements gets removed from
> the series on clearing the series. This test is added similar to the tests
> added to `LineChart
On Wed, 6 Sep 2023 05:21:03 GMT, Karthik P K wrote:
>> Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for
>> `StackedAreaChart` to check if the line and fill elements gets removed from
>> the series on clearing the series. This test is added similar to the tests
>> added to `LineC
Almost clean backport of 8311127: Regression: The fix for TableView and
TreeTableView menu button affects all table column headers
Reviewed-by: angorya
There was a conflict with the insertion point of the test in TreeTableViewTest,
that was solved by swapping the order of tests to match up with
More than happy to provide feedback regarding performance improvements in our
applications due to this change.
Dirk
> Am 05.09.2023 um 21:25 schrieb Johan Vos :
>
> On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>
>>> This fix introduces immutable sets of `PseudoClass` almost everywher
On Wed, 6 Sep 2023 13:49:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8138842: TableViewSelectionModel.selectIndices does
> not select index 0
> Reviewed-by: angorya, aghaisas
>
> There were conflicts with the insertion point of the two tests TableViewTest
> and TreeTableViewTest.
>
On Wed, 6 Sep 2023 13:49:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8138842: TableViewSelectionModel.selectIndices does
> not select index 0
> Reviewed-by: angorya, aghaisas
>
> There were conflicts with the insertion point of the two tests TableViewTest
> and TreeTableViewTest.
>
Almost clean backport of 8138842: TableViewSelectionModel.selectIndices does
not select index 0
Reviewed-by: angorya, aghaisas
There were conflicts with the insertion point of the two tests TableViewTest
and TreeTableViewTest.
In the case of TableViewTest: also two tests that already exist were
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao
wrote:
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Scr
On Wed, 6 Sep 2023 08:54:51 GMT, Lukasz Kostyra wrote:
> Printed line was right above the assertion testing the printed `failed`
> value. Failing assertion will print the value of `failed` regardless, so the
> printed line was redundant.
This pull request has now been integrated.
Changeset: 6
On Wed, 6 Sep 2023 08:54:51 GMT, Lukasz Kostyra wrote:
> Printed line was right above the assertion testing the printed `failed`
> value. Failing assertion will print the value of `failed` regardless, so the
> printed line was redundant.
Marked as reviewed by kcr (Lead).
-
PR Rev
On Wed, 6 Sep 2023 11:02:23 GMT, Jose Pereda wrote:
> Almost clean backport of 8310638: Filtering a TableView with a large number
> of items freezes the UI
> Reviewed-by: kcr, angorya
>
> There was a small conflict in VirtualFlowTest due to JDK-8297414:
>
> -list = new ArrayLinkedListS
On Wed, 6 Sep 2023 11:02:23 GMT, Jose Pereda wrote:
> Almost clean backport of 8310638: Filtering a TableView with a large number
> of items freezes the UI
> Reviewed-by: kcr, angorya
>
> There was a small conflict in VirtualFlowTest due to JDK-8297414:
>
> -list = new ArrayLinkedListS
Almost clean backport of 8310638: Filtering a TableView with a large number of
items freezes the UI
Reviewed-by: kcr, angorya
There was a small conflict in VirtualFlowTest due to JDK-8297414:
-list = new ArrayLinkedListShim();
+list = new ArrayLinkedListShim<>();
-
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote:
>> JDK-8315409: Fix jfx-tests so they work with latest jfx build
>
> Alexandre Iline has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Addressing copyright issues.
Approving this PR as
On Wed, 6 Sep 2023 10:21:14 GMT, Jose Pereda wrote:
> Clean backport of 8309470: Potential performance improvements in VirtualFlow
> Reviewed-by: kpk, angorya
This pull request has now been integrated.
Changeset: 4b1022f6
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit
On Wed, 6 Sep 2023 10:21:14 GMT, Jose Pereda wrote:
> Clean backport of 8309470: Potential performance improvements in VirtualFlow
> Reviewed-by: kpk, angorya
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/159#pullrequestreview-1613024999
Clean backport of 8309470: Potential performance improvements in VirtualFlow
Reviewed-by: kpk, angorya
-
Commit messages:
- 8309470: Potential performance improvements in VirtualFlow
Changes: https://git.openjdk.org/jfx17u/pull/159/files
Webrev: https://webrevs.openjdk.org/?repo=jf
On Wed, 6 Sep 2023 09:41:35 GMT, Jose Pereda wrote:
> Clean backport of 8293836: Rendering performance degradation at bottom of
> TableView with many rows
>
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: 514dfaec
Author:Jose Pereda
URL:
https://g
Clean backport of 8293836: Rendering performance degradation at bottom of
TableView with many rows
Reviewed-by: angorya, kcr
-
Commit messages:
- 8293836: Rendering performance degradation at bottom of TableView with many
rows
Changes: https://git.openjdk.org/jfx17u/pull/158/file
On Wed, 6 Sep 2023 08:49:50 GMT, Jose Pereda wrote:
> Clean backport of 8306447: Adding an element to a long existing list may
> cause the first visible element to jump
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: a90a028f
Author:Jose Pereda
URL:
Printed line was right above the assertion testing the printed `failed` value.
Failing assertion will print the value of `failed` regardless, so the printed
line was redundant.
-
Commit messages:
- 8315728: [testbug] SystemMenuBarTest prints "FAILED IS: false"
Changes: https://git
Clean backport of 8306447: Adding an element to a long existing list may cause
the first visible element to jump
Reviewed-by: angorya, kcr
-
Commit messages:
- 8306447: Adding an element to a long existing list may cause the first
visible element to jump
Changes: https://git.openj
On Wed, 6 Sep 2023 08:16:46 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
> Reviewed-by: angorya, jvos
This pull request has now been integrated.
Changeset: 877ee019
Author:Jose Pereda
URL:
https://
Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
scrollPixels in succession
Reviewed-by: angorya, jvos
-
Commit messages:
- 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in
succession
Changes: https://git.openjdk.org/jfx17u/pull/15
On Wed, 6 Sep 2023 07:45:58 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
>
> Reviewed-by: angorya, jvos
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/j
On Wed, 6 Sep 2023 07:45:58 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
>
> Reviewed-by: angorya, jvos
Errors are due to branch not being up to date.
-
PR Comment: https://git.openjdk.org/jfx17u
Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
scrollPixels in succession
Reviewed-by: angorya, jvos
-
Commit messages:
- 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in
succession
Changes: https://git.openjdk.org/jfx17u/pull/1
On Tue, 5 Sep 2023 23:36:25 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
>
> -setSkin(new SkinStub(this));
> +
77 matches
Mail list logo
