On Wed, 6 Sep 2023 17:22:11 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Eclipse .classpath file
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> 472:
>
>> 470: * <tbody>
>> 471: * <tr><th colspan="2" scope="colgroup">Windows</th></tr>
>> 472: * <tr><td>{@code Windows.SPI.HighContrast}</td><td>{@link
>> Boolean}</td></tr>
>
> would it be possible to sort the keys alphabetically?
I don't think that's necessarily a good idea. I've reordered some of them, but
others should be grouped. For example: it makes sense to keep the following
keys together:
* `macOS.NSColor.labelColor`
* `macOS.NSColor.secondaryLabelColor`
* `macOS.NSColor.tertiaryLabelColor`
* `macOS.NSColor.quaternaryLabelColor`
Another example:
* `macOS.NSColor.textBackgroundColor`
* `macOS.NSColor.selectedTextBackgroundColor`
As it is, most of the keys appear in the same order as they appear in the
respective platform's developer documentation.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1317811702
