Withdrawn: 8089373: Translation from character to key code is not sufficient

2023-08-09 Thread duke
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote: > Note: the Java-side changes in this PR are also in #694 which fixes the same > issue (and more) on Linux. Unfortunately the Linux Robot code is not working > making it difficult to test on that platform (see #718). > > KeyCharacterCombinatio

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Kevin Rushforth
On Wed, 9 Aug 2023 20:12:48 GMT, Michael Strauß wrote: > > I actually considered this but I really want to keep the diff in this PR as > > small as possible, as this is a very sensitive area. If something is broken > > here, it will affect a lot of Windows users. IMO this is a good idea for a

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Michael Strauß
On Wed, 9 Aug 2023 20:03:04 GMT, Marius Hanl wrote: > I actually considered this but I really want to keep the diff in this PR as > small as possible, as this is a very sensitive area. If something is broken > here, it will affect a lot of Windows users. IMO this is a good idea for a > follow

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Marius Hanl
On Wed, 9 Aug 2023 18:46:11 GMT, Michael Strauß wrote: > I notice that the logic to assign adapter ordinals is now duplicated in two > places in the codebase. Have you thought about moving the implementation into > the `Screen` class? I actually considered this but I really want to keep the d

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Michael Strauß
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds

Re: RFR: 8311895: CSS Transitions [v7]

2023-08-09 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-scale-x: 1.1; > -fx-scale-y: 1.1; > > transi

[jfx21u] Integrated: 8313856: Replace VLA with malloc in pango

2023-08-09 Thread Jayathirth D V
On Wed, 9 Aug 2023 05:13:36 GMT, Jayathirth D V wrote: > This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u. > > We should not use stack memory for large VLA allocations in pango.c This pull request has now been integrated. Changeset: 4ff0b7d8 Author:Jayathirth D V

[jfx21u] Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
On Wed, 9 Aug 2023 12:09:26 GMT, Jay Bhaskar wrote: > A clean backport to jfx21u. The fix is for the video control issue, without > the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have > tested the fix it is working with the fix and failing without the fix. This pull r

[jfx21u] Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
A clean backport to jfx21u. The fix is for the video control issue, without the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport 5d741761e751aa047f265d9d816

Withdrawn: 8087370: [odroid] Monocle: Touch is still broken on Odroid

2023-08-09 Thread duke
On Wed, 13 Oct 2021 10:52:40 GMT, Fabian Wolter wrote: > There are sometimes multitouch events detected, when only a single touch > should be detected under certain conditions. This lead to touch events on > previous touch positions. > > The referenced bug is closed with "won't fix" with the j

RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-09 Thread Hima Bindu Meda
Minimum version of python ,to run webkit build , on linux is set to 3.6 and for other platforms, minimum version of python is set to 3.8. Verified build on all platforms. No issue seen - Commit messages: - Add check for python version for various platforms Changes: https://git.ope

Integrated: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-09 Thread Jay Bhaskar
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote: > Issue : Enabling modern media controls on webkit 616.1 does not load button > images on HTML5 Video Element > Solution: Add resources and correct MediaControl Stylesheet This pull request has now been integrated. Changeset: 5d741761 Author: