Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-06 Thread Prasanta Sadhukhan
On Fri, 4 Aug 2023 05:46:35 GMT, Prasanta Sadhukhan wrote: > both windows (using EmbeddedFrameBug class listed earlier) shows O100% for > primary retina screen (should be 200%). @hjohn Seems like @andy-goryachev-oracle is telling it regressed after `updateSceneState` integration as previousl

Re: RFR: 8313856: Replace VLA with malloc in pango

2023-08-06 Thread Ambarish Rapte
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote: > We should not use stack for array memory allocations in JNI. > Updated pango.c to use malloc for arrays and release them at appropriate > places. LGTM - Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjd

RFR: 8313856: Replace VLA with malloc in pango

2023-08-06 Thread Jayathirth D V
We should not use stack for array memory allocations in JNI. Updated pango.c to use malloc for arrays and release them at appropriate places. - Commit messages: - 8313856: Replace VLA with malloc in pango Changes: https://git.openjdk.org/jfx/pull/1202/files Webrev: https://webrevs.

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]

2023-08-06 Thread Hima Bindu Meda
> Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Correct indentation - Changes:

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v3]

2023-08-06 Thread Nir Lisker
On Sun, 6 Aug 2023 09:16:32 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request incrementally wi

Re: RFR: 8309558: Create implementation of NSAccessibilityCheckBox protocol [v2]

2023-08-06 Thread Ambarish Rapte
On Mon, 24 Jul 2023 18:34:22 GMT, Alexander Zuev wrote: >> also >> 8309629: Create implementation of NSAccessibilityRadioButton protocol >> >> Create implementation of NSAccessibilityCheckBox and >> NSAccessibilityRadioButton protocols >> Add workaround for the wrong focus owner announcement wi

RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

2023-08-06 Thread Jay Bhaskar
Issue : Enabling modern media controls on webkit 616.1 does not load button images on HTML5 Video Element Solution: Add resources and correct MediaControl Stylesheet - Commit messages: - use smart pointer to avoid memory leak - Adding simple tool based on python to generate base64

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v2]

2023-08-06 Thread John Hendrikx
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request with a new targ

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v3]

2023-08-06 Thread John Hendrikx
> Incorporates documentation review comments from #1069. > > This PR should be kept minimal so it can be backported to JFX21; it should > only contain documentation changes. John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Improve S

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v9]

2023-08-06 Thread John Hendrikx
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > > Prasant