On Mon, 24 Jul 2023 18:34:22 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> also >> 8309629: Create implementation of NSAccessibilityRadioButton protocol >> >> Create implementation of NSAccessibilityCheckBox and >> NSAccessibilityRadioButton protocols >> Add workaround for the wrong focus owner announcement with radio buttons >> Add workaround for wrong magnifier text on buttons > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Add newline at the end of the header files. Providing a minor comment for a warning. Also noticed that, with this change tab are read as radio button. [ Tested with ensemble ] <img width="646" alt="Screenshot 2023-08-06 at 3 23 35 PM" src="https://github.com/openjdk/jfx/assets/11330676/1d9ade44-2305-4f13-afe3-2d586934a918";> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 174: > 172: jobject jresult = NULL; > 173: GET_MAIN_JENV; > 174: if (env == NULL) return NULL; This generates a warning: `warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'BOOL' (aka 'signed char') [-Wint-conversion]` ------------- Changes requested by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1184#pullrequestreview-1564090685 PR Review Comment: https://git.openjdk.org/jfx/pull/1184#discussion_r1285169799
