On Thu, 1 Jun 2023 20:55:33 GMT, Phil Race wrote:
>> Assuming line 473 is the one still there today, it looks to me as if that
>> would be reached if you had the caret on an empty line that isn't the last
>> line.
>
> Regarding
> "If we can initialize insertionIndex to a positive value, then th
On Thu, 1 Jun 2023 20:53:07 GMT, Phil Race wrote:
>>> I couldn't create the scenario to hit line 473. If you have any suggestions
>>> please let me know.
>>
>> I can't seem to trigger this code path (I wonder if it's possible to hit it
>> at all). Anyway, the code there looks correct to me, e
On Tue, 16 May 2023 17:53:00 GMT, Andy Goryachev wrote:
>> Initializing the insertion index directly with character index looks better.
>> In this way we can avoid additional conditional logic as well. Changed code
>> to do so.
>> Added additional test case. This tests the condition present in
On Tue, 30 May 2023 10:39:28 GMT, Johan Vos wrote:
>> Only update the VirtualFlow parameters in case the size of a cell has
>> changed.
>>
>> The fixes for JDK-8298728 and JDK-8277785 introduced an unconditional
>> recalculation in case the size of a cell is set. This recalculation is only
>>
On Sat, 20 May 2023 16:19:19 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request in
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote:
> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
> the needed C++20 support for the next WebKit update.
>
> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
> 17.5.0 -- see [JDK-830374
On Fri, 26 May 2023 22:26:49 GMT, Andy Goryachev wrote:
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse wit
On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth wrote:
>> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
>> the needed C++20 support for the next WebKit update.
>>
>> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
>> 17.5.0 -- see [JDK-8
Vote: YES
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confus
On Thu, 1 Jun 2023 15:31:22 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 1700:
>>
>>> 1698:
>>> 1699: The default value for controls is true, although there
>>> are some exceptions.
>>> 1700: See
On Thu, 1 Jun 2023 15:42:26 GMT, Andy Goryachev wrote:
>> I think this link should point to the (currently missing) Controls header
>> and not the Control class. The "details" on focusibility that this note
>> refers to are in the package header for `javafx.scene.control`, which will
>> be rig
On Thu, 1 Jun 2023 15:40:14 GMT, Kevin Rushforth wrote:
>> not here - here the link should point to Control.
>>
>> @Maran23 is right - the heading H2 was originally missing from the Controls
>> section (line 3245)
>
> I think this link should point to the (currently missing) Controls header and
On Thu, 1 Jun 2023 15:45:00 GMT, Kevin Rushforth wrote:
>> there is a duplicate entry for -fx-focus-traversable in Node and Control
>> sections. I think this particular link should point to Control, where it
>> says
>>
>> "Control sets the default value of the focusTraversable property to tr
> Minor fixes and addition of missing sections:
>
> - The 'system' font is missing from the list of generic font family names in
> the section. ✓
> - Explicitly add text color property -fx-fill to Text section, so as not to
> confuse with Labeled -fx-text-fill ✓
> - TextFlow section is missing,
On Thu, 1 Jun 2023 13:19:34 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pane
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 1700:
>
>> 1698:
On Sat, 20 May 2023 16:17:50 GMT, Thiago Milczarek Sayao
wrote:
> About the `testAnchorRight` test: I know what happened, it's the focus shadow
> of the button `topLeft` - it was the first child of the AnchorPane, so it got
> the focus and hence the difference in the value. Moving it in the Sc
On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth wrote:
>> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides
>> the needed C++20 support for the next WebKit update.
>>
>> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022
>> 17.5.0 -- see [JDK-8
Vote : YES
Regards,
Karthik
From: openjfx-dev on behalf of Kevin Rushforth
Date: Wednesday, 24 May 2023 at 5:18 PM
To: openjfx-dev , Lukasz Kostyra
Subject: CFV: New OpenJFX Committer: Lukasz Kostyra
I hereby nominate Lukasz Kostyra [1] to OpenJFX Committer.
Lukasz is a member of the JavaFX
On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev wrote:
>> Minor fixes and addition of missing sections:
>>
>> - The 'system' font is missing from the list of generic font family names in
>> the section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to
>> confu
On Thu, 1 Jun 2023 09:39:18 GMT, Marius Hanl wrote:
>> you are right
>
> You need to add a `Controls` headline still.
> `Nodes`
> It should be above the `javafx.scene.control` row.
> Then the `href` will work and is consistent with the other headers.
>
> 