On Mon, 27 Mar 2023 23:05:00 GMT, John Hendrikx wrote:
> Fix bug in CSS caching code that could reset values on unrelated nodes.
>
> The bug occurs due to a cache entry being constructed incorrectly when the
> initial node that triggered the cache entry creation has user set values. The
> calc
Updated ICU to v73.1. Verified build and sanity. No issues seen.
-
Commit messages:
- resolve compile error on windows
- change file mode for rbbicst.pl
- whitespace corrections
- chmod to 644 for regexcst.pl
- white space corrections
- remove unwanted files
- Merge branch 'mas
On Wed, 3 May 2023 16:02:34 GMT, John Neffenger wrote:
> Please review these changes to the Gradle build files and the dependency
> verification file. The initial version of this pull request extends the
> permitted build platforms for Linux to the Java architectures `arm`,
> `ppc64le`, and `s
Please review these changes to the Gradle build files and the dependency
verification file. The initial version of this pull request extends the
permitted build platforms for Linux to the Java architectures `arm`, `ppc64le`,
and `s390x` and adds an entry to the dependency verification file for t
On Sat, 13 May 2023 17:22:53 GMT, Michael Strauß wrote:
>> On Windows, a `Stage` that is restricted by minimum and maximum sizes can
>> briefly be observed to appear with incorrect dimensions when it is first
>> shown. The root cause of this bug is that the native `WinWindow._setBounds`
>> met
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
In https://github.com/openjdk/jfx/pull/1135 I implemented a way to override the behaviour when the table menu button is clicked.
Current behaviour
The table menu button is visible when setTableMenuButtonVisible(true) is called.
When clicked, a ContextMenu is shown with all available columns o
On Mon, 15 May 2023 18:13:00 GMT, Kevin Rushforth wrote:
> This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big
> Sur) on x64 platforms, matching the current minimum on aarch64.
>
> As a follow-on to this, I will file a (low-priority) cleanup issue to remove
> any `@availa
On Mon, 15 May 2023 18:13:00 GMT, Kevin Rushforth wrote:
> This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big
> Sur) on x64 platforms, matching the current minimum on aarch64.
>
> As a follow-on to this, I will file a (low-priority) cleanup issue to remove
> any `@availa
On Mon, 15 May 2023 18:13:00 GMT, Kevin Rushforth wrote:
> This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big
> Sur) on x64 platforms, matching the current minimum on aarch64.
>
> As a follow-on to this, I will file a (low-priority) cleanup issue to remove
> any `@availa
On Mon, 15 May 2023 18:54:16 GMT, Andy Goryachev wrote:
> is the intent here to always be in sync?
Yes. Having a different minimum was a one-time anomaly due to the fact that
Apple required a minimum target of 11.0 for M1 systems when they introduced
them. See [JDK-8265031](https://bugs.openjd
On Mon, 15 May 2023 18:13:00 GMT, Kevin Rushforth wrote:
> This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big
> Sur) on x64 platforms, matching the current minimum on aarch64.
>
> As a follow-on to this, I will file a (low-priority) cleanup issue to remove
> any `@availa
On Mon, 15 May 2023 15:09:27 GMT, Martin Fox wrote:
> Fun fact: Xcode 14 (released late 2022) officially dropped support for macOS
> 10.12.
Thanks for pointing this out. I had missed that, so added it as another point
in favor of bumping our minimum in the mailing list thread where we are
di
On Mon, 15 May 2023 17:57:21 GMT, Andy Goryachev wrote:
>> Even if there is, this still shouln't stop us using new language features,
>> should it? Otherwise we can't really use any new feature, as a fix *might*
>> be backported.
>> On the other hand it is also easy to replace this text block w
On Mon, 15 May 2023 17:23:45 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line
>> 1185:
>>
>>> 1183: if (cssValue != null &&
>>> "inherit".equals(cssValue.getValue())) {
>>> 1184: style = getInheritedStyle(styleable, pr
This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big Sur)
on x64 platforms, matching the current minimum on aarch64.
As a follow-on to this, I will file a (low-priority) cleanup issue to remove
any `@available` checks for 10.x, since those will then be no-ops.
-
One more reason why we need to bump the minimum is that Xcode 14 no
longer supports deploying to 10.12, and we will need to update to Xcode
14 relatively soon.
So the only remaining question is whether to choose Option 1 or Option
2. I haven't heard any objection to going straight to macOS 11.
On Mon, 15 May 2023 17:55:09 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
>> line 622:
>>
>>> 620: }
>>> 621: """
>>> 622: );
>>
>> is there a chance we would backport this fix (to < java15)?
>
>
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Mon, 15 May 2023 16:44:58 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> com
On Fri, 12 May 2023 15:05:01 GMT, Lukasz Kostyra wrote:
>> Crashes started happening due to macOS DnD API change from macOS 10.14
>> onwards. 10.14 incrodues some [DnD
>> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop
On Fri, 12 May 2023 11:56:00 GMT, Lukasz Kostyra wrote:
>> This sounds like it could be the reason for the functional regression in
>> handling the CMD modifier while dragging.
>
> Good catch, I'll take a look into that
Looks good to me.
-
PR Review Comment: https://git.openjdk.or
On Mon, 15 May 2023 16:41:33 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> com
On Sat, 13 May 2023 17:22:53 GMT, Michael Strauß wrote:
>> On Windows, a `Stage` that is restricted by minimum and maximum sizes can
>> briefly be observed to appear with incorrect dimensions when it is first
>> shown. The root cause of this bug is that the native `WinWindow._setBounds`
>> met
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote:
>> Fix bug in CSS caching code that could reset values on unrelated nodes.
>>
>> The bug occurs due to a cache entry being constructed incorrectly when the
>> initial node that triggered the cache entry creation has user set values.
>> The
On Sun, 14 May 2023 17:36:12 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl wrote:
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridde
On Sat, 13 May 2023 17:17:42 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> John is right
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
> line 158:
>
> Fixed a memory leak in TreeTableView by reverting to register**Listener
> (which is ok in this particular situation) - the leak is specific to
> TreeTableRowSkin.
>
> Added a unit test.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The increme
On Mon, 15 May 2023 09:57:59 GMT, Karthik P K wrote:
>> Since surrogate pairs are internally considered as 2 characters and text
>> field is null in `HitInfo` when `getInsertionIndex` is invoked from
>> `TextFlow`, wrong insertion index was returned.
>>
>> Updated code to calculate insertion i
On Mon, 15 May 2023 12:49:41 GMT, Lukasz Kostyra wrote:
> This issue happened because `childSet` member of Parent was modified during
> `onProposedChange()` call - that call did not recognize negative indexes as
> invalid, which caused an exception when actually adding the Node to a List.
>
>
In macOS 10.12 Apple renamed a bunch of constants to match the Swift
enumeration style. JavaFX is still using the old deprecated constants which
generates over 50 warnings during the build. JavaFX 18 upped the minimum macOS
version to 10.12 so it's time to migrate to the new names.
This is stri
On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl wrote:
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridde
On Sat, 13 May 2023 15:56:15 GMT, Carl Döbbelin wrote:
> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
This pull request has now been integrated.
Changeset: e7974bc8
Author:Carl Döbbelin
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/comm
This issue happened because `childSet` member of Parent was modified during
`onProposedChange()` call - that call did not recognize negative indexes as
invalid, which caused an exception when actually adding the Node to a List.
This seemed like the simplest solution which doesn't rework a lot of
On Fri, 12 May 2023 21:05:27 GMT, Andy Goryachev wrote:
> Just by looking at the code, the code paths that leave `insertionIndex=-1` in
> `PrismTextLayout.getHitInfo()` are on lines: 431, 450(when run==null), 472
>
> If we can initialize insertionIndex to a positive value, then the buggy code
> Since surrogate pairs are internally considered as 2 characters and text
> field is null in `HitInfo` when `getInsertionIndex` is invoked from
> `TextFlow`, wrong insertion index was returned.
>
> Updated code to calculate insertion index in `getHitInfo` method of
> `PrismTextLayout` class wh
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Fri, 12 May 2023 22:19:00 GMT, Kevin Rushforth wrote:
> I can't find anything like VoiceOver on Windows 11. Do you need JAWS or
> similar to test?
On Windows 10/11 it is called Narrator and is in Start->All
Apps->Accessibility->Narrator
Unlike AWT/Swing JavaFX does not require JAWS or NVDA.
On Thu, 11 May 2023 01:09:53 GMT, Alexander Matveev
wrote:
>> - libFFI updated to 3.4.4.
>> - No additional changes are done to the code.
>> - Tested on Linux, Windows x64 and macOS x64/aarch64.
>> - Windows x86 config files are updated, but no build/testing was done for
>> 32-bit.
>
> Alexande
40 matches
Mail list logo
