On Wed, 3 May 2023 16:02:34 GMT, John Neffenger <jgn...@openjdk.org> wrote:
> Please review these changes to the Gradle build files and the dependency > verification file. The initial version of this pull request extends the > permitted build platforms for Linux to the Java architectures `arm`, > `ppc64le`, and `s390x` and adds an entry to the dependency verification file > for the `i386` architecture. The Debian names for these architectures are > `armhf`, `i386`, `ppc64el`, and `s390x`. I changed the patch to print a warning message instead of failing when the build machine's architecture is unrecognized, based on the discussion [on the mailing list][1]. I then built JavaFX on six Linux architectures. Three of the resulting build log files contain the warning message as expected (`arm`, `ppc64le`, and `s390x`): $ grep -T -A5 'Configure project' *.txt openjfx_amd64.txt: > Configure project : openjfx_amd64.txt- gradle.gradleVersion: 7.6 openjfx_amd64.txt- OS_NAME: linux openjfx_amd64.txt- OS_ARCH: amd64 openjfx_amd64.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64 openjfx_amd64.txt- JDK_HOME: /usr/lib/jvm/java-17-openjdk-amd64 -- openjfx_arm64.txt: > Configure project : openjfx_arm64.txt- gradle.gradleVersion: 7.6 openjfx_arm64.txt- OS_NAME: linux openjfx_arm64.txt- OS_ARCH: aarch64 openjfx_arm64.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-arm64 openjfx_arm64.txt- JDK_HOME: /usr/lib/jvm/java-17-openjdk-arm64 -- openjfx_armhf.txt: > Configure project : openjfx_armhf.txt- Unknown and unsupported build architecture: arm openjfx_armhf.txt- gradle.gradleVersion: 7.6 openjfx_armhf.txt- OS_NAME: linux openjfx_armhf.txt- OS_ARCH: arm openjfx_armhf.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-armhf -- openjfx_i386.txt: > Configure project : openjfx_i386.txt- gradle.gradleVersion: 7.6 openjfx_i386.txt- OS_NAME: linux openjfx_i386.txt- OS_ARCH: i386 openjfx_i386.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-i386 openjfx_i386.txt- JDK_HOME: /usr/lib/jvm/java-17-openjdk-i386 -- openjfx_ppc64el.txt: > Configure project : openjfx_ppc64el.txt- Unknown and unsupported build architecture: ppc64le openjfx_ppc64el.txt- gradle.gradleVersion: 7.6 openjfx_ppc64el.txt- OS_NAME: linux openjfx_ppc64el.txt- OS_ARCH: ppc64le openjfx_ppc64el.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-ppc64el -- openjfx_s390x.txt: > Configure project : openjfx_s390x.txt- Unknown and unsupported build architecture: s390x openjfx_s390x.txt- gradle.gradleVersion: 7.6 openjfx_s390x.txt- OS_NAME: linux openjfx_s390x.txt- OS_ARCH: s390x openjfx_s390x.txt- JAVA_HOME: /usr/lib/jvm/java-17-openjdk-s390x All of the builds were successful: $ grep -T -A1 ^BUILD *.txt openjfx_amd64.txt: BUILD SUCCESSFUL in 2m 40s openjfx_amd64.txt- 137 actionable tasks: 137 executed -- openjfx_arm64.txt: BUILD SUCCESSFUL in 3m 42s openjfx_arm64.txt- 137 actionable tasks: 137 executed -- openjfx_armhf.txt: BUILD SUCCESSFUL in 16m 51s openjfx_armhf.txt- 137 actionable tasks: 137 executed -- openjfx_i386.txt: BUILD SUCCESSFUL in 2m 42s openjfx_i386.txt- 137 actionable tasks: 137 executed -- openjfx_ppc64el.txt: BUILD SUCCESSFUL in 3m 29s openjfx_ppc64el.txt- 137 actionable tasks: 137 executed -- openjfx_s390x.txt: BUILD SUCCESSFUL in 2m 34s openjfx_s390x.txt- 137 actionable tasks: 137 executed [1]: https://mail.openjdk.org/pipermail/openjfx-dev/2023-April/039439.html Two GitHub pre-submit tests failed, but they appear to be temporary network errors: * [Linux] Connecting to archive.apache.org (archive.apache.org)|138.201.131.134|:443... failed: Connection timed out. * [Windows] curl: (28) Failed to connect to archive.apache.org port 443 after 21065 ms: Couldn't connect to server ------------- PR Comment: https://git.openjdk.org/jfx/pull/1124#issuecomment-1548787652 PR Comment: https://git.openjdk.org/jfx/pull/1124#issuecomment-1548794987
