On Tue, 18 Apr 2023 02:08:03 GMT, Alexander Matveev
wrote:
> - Added missing exception checks for JNI calls.
> - Improved JNI error checking by checking for both exception and return
> value.
> - Minor code clean up.
Looks good overall, suggesting few minor changes.
modules/javafx.media/src
On Tue, 9 May 2023 18:16:09 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address code review
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 425:
>
On Tue, 9 May 2023 18:43:07 GMT, Andy Goryachev wrote:
> There is one question whether it's possible to always initialize
> HitInfo.insertionIndex and remove the secondary computation from
> HitInfo.getInsertionIndex()
>
> I am not clear under which conditions it is not possible to initialize,
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinations allow the specification of accelerators based on
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev
wrote:
> - libFFI updated to 3.4.4.
> - No additional changes are done to the code.
> - Tested on Linux, Windows x64 and macOS x64/aarch64.
> - Windows x86 config files are updated, but no build/testing was done for
> 32-bit.
8306328: Update
> - libFFI updated to 3.4.4.
> - No additional changes are done to the code.
> - Tested on Linux, Windows x64 and macOS x64/aarch64.
> - Windows x86 config files are updated, but no build/testing was done for
> 32-bit.
Alexander Matveev has updated the pull request incrementally with one
additio
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Found an occurrences:
* `com.sun.javafx.application.LauncherImpl` line 386.
* `com.sun.media.jfxmediaimpl.HostU
On Wed, 10 May 2023 23:12:50 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
Andy Goryachev has updated the pull request incrementally with one
On Wed, 10 May 2023 20:48:22 GMT, Andy Goryachev wrote:
>> Adding TextFlow.underlineShape() to add support for a spellchecker-like
>> decoration, using
>>
>> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>>
>>
>> which mirrors an existing method in Text with exactly the same signature.
>
On Wed, 12 Apr 2023 16:50:38 GMT, Lukasz Kostyra wrote:
> Crashes started happening due to macOS DnD API change from macOS 10.14
> onwards. 10.14 incrodues some [DnD
> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop)
>
- libFFI updated to 3.4.4.
- No additional changes are done to the code.
- Tested on Linux, Windows x64 and macOS x64/aarch64.
- Windows x86 config files are updated, but no build/testing was done for
32-bit.
-
Commit messages:
- 8306328: Update libFFI to 3.4.4 [v2]
- 8306328: Upda
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev
wrote:
> - libFFI updated to 3.4.4.
> - No additional changes are done to the code.
> - Tested on Linux, Windows x64 and macOS x64/aarch64.
> - Windows x86 config files are updated, but no build/testing was done for
> 32-bit.
8306328: Update
On Fri, 5 May 2023 20:20:02 GMT, John Hendrikx wrote:
> > I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> > methods. Why not just have one? Not changing the existing call sites
> > doesn't seem to be a sufficient reason to expand the toolkit API surface.
>
> I also
On Wed, 10 May 2023 20:48:22 GMT, Andy Goryachev wrote:
>> Adding TextFlow.underlineShape() to add support for a spellchecker-like
>> decoration, using
>>
>> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>>
>>
>> which mirrors an existing method in Text with exactly the same signature.
>
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
Andy Goryachev has updated the pull request with a new target base
Replaced querying of `System.getProperty("os.name")` to check for OS with the
use of the methods provided by `PlatformUtils`
-
Commit messages:
- Merge branch 'master' into
JDK-8307807-replace-system-getproperty-osname-platform-utils
- replaced sensible spots of system getproperty
On Wed, 10 May 2023 17:40:59 GMT, Kevin Rushforth wrote:
> UPDATE: THIS COMMENT WAS MEANT FOR ANOTHER PR.
we've all been there! :-)
-
PR Comment: https://git.openjdk.org/jfx/pull/1127#issuecomment-1542585334
On Wed, 10 May 2023 17:36:41 GMT, Andy Goryachev wrote:
> it looks like the test is unstable - it works fine in Eclipse, but sometimes
> fails with gradle. investigating.
It's definitely affected by GC, so I'd start by looking there. I can change
whether the the test passes or fails by changin
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
~~It's de
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
The API l
On Mon, 8 May 2023 18:55:38 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by using WeakInvalidationListener
>> (which is the right approach in this particular situation) - the leak is
>> specific to TreeTableRowSkin.
>>
>> Added a unit test.
>>
>> Added Refresh buttons an
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
Seems fin
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
Maybe @pr
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote:
> Focused only on raw type problems, and removing casts that were no longer
> needed because of the changes.
I started reviewing but there are too many files, which makes the GitHub
interface unresponsive. Can you break it into 4 PRs of ~5
On Mon, 8 May 2023 18:55:38 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by using WeakInvalidationListener
>> (which is the right approach in this particular situation) - the leak is
>> specific to TreeTableRowSkin.
>>
>> Added a unit test.
>>
>> Added Refresh buttons an
On Wed, 10 May 2023 06:57:04 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java
>> line 215:
>>
>>> 213: int right = 23;
>>> 214: int bottom = 37;
>>> 215: int left = 49;
>>
>> After the fix and te
On Wed, 10 May 2023 15:20:25 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 334:
>>
>>> 332: private void updateTreeItem() {
>>> 333: unregisterInvalidationListeners(graphicProperty());
>>> 334: tre
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
I'm not f
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
@nlisker
On Wed, 10 May 2023 06:54:35 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commit
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinations allow the specification of accelerators based on
On Tue, 9 May 2023 14:12:09 GMT, Lukasz Kostyra wrote:
> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>
> Only Windows and macOS parts were affected, tests work good on both platforms.
>
> I looked through the code and didn't find any other cases of
> `Runtime.get
On Tue, 9 May 2023 21:15:38 GMT, Andy Goryachev wrote:
>> But I do think it would be a good idea to use `PlatformUtil` here, so maybe
>> file a cleanup issue to look for places where we explicitly parse `os.name`,
>> and consider calling the appropriate `PlatformUtil` method instead?
>
> +1 for
On Tue, 9 May 2023 20:38:35 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/native-glass/win/KeyTable.cpp line 366:
>>
>>> 364: UINT keyChar = ::MapVirtualKeyEx(UINT(hardwareCode), 2,
>>> layout);
>>> 365: // Filter out dead keys
>>> 366: BOOL isDead = (keyCha
On Tue, 9 May 2023 22:41:41 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commi
On Mon, 8 May 2023 18:55:38 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by using WeakInvalidationListener
>> (which is the right approach in this particular situation) - the leak is
>> specific to TreeTableRowSkin.
>>
>> Added a unit test.
>>
>> Added Refresh buttons an
37 matches
Mail list logo
