Re: Support pluggable image loading via javax.imageio

2023-04-18 Thread clemens.lantha...@itarchitects.at
Hi Michael, yes you are right. It could live in parallel. > On 18. Apr 2023, at 20:23, Michael Strauß wrote: > > Hi Clemens, > > when you talk about doing it faster, are you concerned about performance? > > Creating an API for the JavaFX image loaders is also a possibility, > but that's muc

Re: RFR: 8299335: Monkey Tester Application

2023-04-18 Thread Nir Lisker
On Tue, 18 Apr 2023 20:12:01 GMT, Andy Goryachev wrote: > Monkey Tester - a JavaFX application designed to support ad-hoc testing of > JavaFX controls. > > Feedback and suggestions are always welcome. > > ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11

RFR: 8299335: Monkey Tester Application

2023-04-18 Thread Andy Goryachev
Monkey Tester - a JavaFX application designed to support ad-hoc testing of JavaFX controls. Feedback and suggestions are always welcome. ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png) - Commit messages: - white

Re: RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v4]

2023-04-18 Thread Kevin Rushforth
On Mon, 17 Apr 2023 07:23:40 GMT, John Hendrikx wrote: >> These changes use base classes for custom properties where possible for the >> `ExpressionHelper` logic instead of duplicating these each time. > > John Hendrikx has updated the pull request incrementally with one additional > commit sin

Re: Support pluggable image loading via javax.imageio

2023-04-18 Thread Michael Strauß
Hi Clemens, when you talk about doing it faster, are you concerned about performance? Creating an API for the JavaFX image loaders is also a possibility, but that's much more difficult to get done. We can always do that in the future though, the proposed support for Java Image I/O doesn't close a

Re: Support pluggable image loading via javax.imageio

2023-04-18 Thread clemens.lantha...@itarchitects.at
You can do it via non public API much faster. You can have a look into LibrawFX or LibHeifFX. What would help is to make the existing API public. Clemens > On 18. Apr 2023, at 17:51, John Neffenger wrote: > > On 4/17/23 2:10 PM, Michael Strauß wrote: >> I've been working on a proposal that

Re: Content Graph

2023-04-18 Thread Michael Strauß
Hi Robert, > This requires that a MenuButton always has a text, however a Skin could > exist that does not contain any text node (but only a bitmap, a simple > shape, etc.). AFAIK Skins separate controls from their concrete > representation. But that's the point of the content graph. A MenuButton

Re: Content Graph

2023-04-18 Thread Michael Strauß
Here's a draft PR: https://github.com/openjdk/jfx/pull/1096 There are some API changes compared to my last email, the most notable being that the content graph can now contain arbitrary objects. This allows the content graph to directly contain a ListView's item list, or a Labeled's text. > I th

Re: Support pluggable image loading via javax.imageio

2023-04-18 Thread John Neffenger
On 4/17/23 2:10 PM, Michael Strauß wrote: I've been working on a proposal that doesn't add any new API to JavaFX, but instead plugs into the existing `javax.imageio` API, allowing applications to use third-party libraries like TwelveMonkeys [0] to load a wide variety of image formats. Looks int

Re: [External] : Re: RFR: Request to sync April 2023 CPU changes into jfx:master+ backports to jfx20u, jfx17u, jfx11u

2023-04-18 Thread Kevin Rushforth
Now pushed to all code lines. Thanks. -- Kevin On 4/18/2023 7:31 AM, Johan Vos wrote: Hi Kevin, Approved. - Johan On Tue, Apr 18, 2023 at 4:14 PM Kevin Rushforth wrote: Hi Johan, I request approval to sync changes from to the just-released April 2023 CPU release into t

Re: RFR: Request to sync April 2023 CPU changes into jfx:master+ backports to jfx20u, jfx17u, jfx11u

2023-04-18 Thread Johan Vos
Hi Kevin, Approved. - Johan On Tue, Apr 18, 2023 at 4:14 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to sync changes from to the just-released April 2023 > CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > > https:/

RFR: Request to sync April 2023 CPU changes into jfx:master+ backports to jfx20u, jfx17u, jfx11u

2023-04-18 Thread Kevin Rushforth
Hi Johan, I request approval to sync changes from to the just-released April 2023 CPU release into the 'master' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/f28896aa63...cpu-2304-sync NOTE: Since this is an integr

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-04-18 Thread John Hendrikx
> Fix bug in CSS caching code that could reset values on unrelated nodes. > > The bug occurs due to a cache entry being constructed incorrectly when the > initial node that triggered the cache entry creation has user set values. The > calculated values for properties with a user set value were o

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v5]

2023-04-18 Thread John Hendrikx
> Description copied from issue: > > There are up to two additional invalidations performed that really should be > avoided, causing downstream fluent bindings to be recomputed with the same > values. This is very confusing as these should only be called when there is > an actual change, and n

Re: RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v3]

2023-04-18 Thread Kevin Rushforth
On Tue, 11 Apr 2023 07:28:36 GMT, John Hendrikx wrote: >>> Well, I am just following the specification here, but JavaFX itself isn't... >>> >>> We may need to make a decision here. JavaFX is not consistent itself where >>> it applies `equals` and where it uses reference equality: >> >> Alright

Variable reassignment and raw types :-)

2023-04-18 Thread John Hendrikx
So, I was doing raw type clean-up in some obscure graphics code, and I noticed I couldn't get things to compile anymore when I fixed all the raw types. It turns out that at some point a List (actually a Vector) which was using raw types was being assigned to another variable that also held a li