Re: CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread Ajit Ghaisas
Vote: YES Regards, Ajit > On 12-Apr-2023, at 9:44 PM, Kevin Rushforth > wrote: > > I hereby nominate Karthik P K [1] to OpenJFX Committer. > > Karthik is a member of the JavaFX team at Oracle who has contributed 15 > commits [2] to OpenJFX. > > Votes are due by April 26, 2023 at 17:00 UTC.

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v9]

2023-04-12 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys wh

Re: Promote addEventHandler/removeEventHandler to EventTarget interface

2023-04-12 Thread Michael Strauß
I've created a draft PR with the proposed changes: https://github.com/openjdk/jfx/pull/1090 Adding event handler management methods to `EventTarget` greatly increases the usefulness of the event system for the reasons John and I mentioned earlier. I want to circle back to the compatibility issues

Re: RFR: 8305925: Add concatenated list view

2023-04-12 Thread Kevin Rushforth
On Wed, 12 Apr 2023 07:24:08 GMT, Michael Strauß wrote: > The JavaFX collections framework offers the > `FXCollections.concat(ObservableList...)` method, which creates a new > modifiable list that contains a concatenated snapshot of the source lists, > backed by an `ArrayList`. However, when t

RFR: 8305925: Add concatenated list view

2023-04-12 Thread Michael Strauß
The JavaFX collections framework offers the `FXCollections.concat(ObservableList...)` method, which creates a new modifiable list that contains a concatenated snapshot of the source lists, backed by an `ArrayList`. However, when the source lists are changed, the concatenated list is not updated

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

2023-04-12 Thread Martin Fox
On Mon, 10 Apr 2023 20:16:23 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 473: >> >>> 471: // If the QWERTY key is in the layout sensitive area search the >>> other keys in that >>> 472: // area. We may not find a key so returning NO is pos

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop

2023-04-12 Thread Lukasz Kostyra
On Wed, 12 Apr 2023 16:50:38 GMT, Lukasz Kostyra wrote: > Crashes started happening due to macOS DnD API change from macOS 10.14 > onwards. 10.14 incrodues some [DnD > constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop) >

RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop

2023-04-12 Thread Lukasz Kostyra
Crashes started happening due to macOS DnD API change from macOS 10.14 onwards. 10.14 incrodues some [DnD constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop) which our DnD code happened to trigger on some occasions. Our c

Re: CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread Philip Race
Vote: yes -phil.

Re: CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread John Neffenger
Vote: YES On 4/12/23 9:14 AM, Kevin Rushforth wrote: I hereby nominate Karthik P K [1] to OpenJFX Committer.

Re: RFR: 8284542: Missing attribute for state of CheckBox in CheckBoxTreeItem

2023-04-12 Thread Kevin Rushforth
On Wed, 12 Apr 2023 15:13:25 GMT, Ambarish Rapte wrote: > Issue: > CheckBoxTreeItem extends TreeItem and adds a CheckBox. > The state of this CheckBox is not visible to an accessibility client > application. > If we analyze a simple program that contains a CheckBoxTreeItem using a > windows app

Re: CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread Kevin Rushforth
Vote: YES On 4/12/2023 9:14 AM, Kevin Rushforth wrote: I hereby nominate Karthik P K [1] to OpenJFX Committer.

Re: CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread Andy Goryachev
Vote: yes From: openjfx-dev on behalf of Kevin Rushforth Date: Wednesday, April 12, 2023 at 09:15 To: openjfx-dev , Karthik P K Subject: CFV: New OpenJFX Committer: Karthik P K I hereby nominate Karthik P K [1] to OpenJFX Committer. Karthik is a member of the JavaFX team at Oracle who has con

Integrated: 8088594: NullPointerException on showing submenu of a contextmenu

2023-04-12 Thread Karthik P K
On Thu, 6 Apr 2023 13:03:04 GMT, Karthik P K wrote: > When custom skin was loaded, the listeners added in `ContextMenuContent` > class while loading the default skin were not removed. This was causing the > NPE when outdated listeners were invoked. > > Updated the code to dispose listeners in

CFV: New OpenJFX Committer: Karthik P K

2023-04-12 Thread Kevin Rushforth
I hereby nominate Karthik P K [1] to OpenJFX Committer. Karthik is a member of the JavaFX team at Oracle who has contributed 15 commits [2] to OpenJFX. Votes are due by April 26, 2023 at 17:00 UTC. Only current OpenJFX Committers [3] are eligible to vote on this nomination. Votes must be cas

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

2023-04-12 Thread Jose Pereda
On Mon, 10 Apr 2023 20:04:45 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 195: >> >>> 193: } >>> 194: >>> 195: if (keyCode >= 0x00 && keyCode <= 0x32) >> >> Add a comment? like `// Null to [Space]` > > This are Mac virtual key code constan

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v8]

2023-04-12 Thread Jose Pereda
On Mon, 10 Apr 2023 20:06:02 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

2023-04-12 Thread Jose Pereda
On Wed, 5 Apr 2023 12:38:36 GMT, Jose Pereda wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added manual cross-platform keyboard handling test > > modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 19

RFR: 8284542: Missing attribute for state of CheckBox in CheckBoxTreeItem

2023-04-12 Thread Ambarish Rapte
Issue: CheckBoxTreeItem extends TreeItem and adds a CheckBox. The state of this CheckBox is not visible to an accessibility client application. If we analyze a simple program that contains a CheckBoxTreeItem using a windows application "Accessibility Insights for Window", we can notice that toggl

Re: RFR: 8088594: NullPointerException on showing submenu of a contextmenu [v4]

2023-04-12 Thread Andy Goryachev
On Wed, 12 Apr 2023 05:08:46 GMT, Karthik P K wrote: >> When custom skin was loaded, the listeners added in `ContextMenuContent` >> class while loading the default skin were not removed. This was causing the >> NPE when outdated listeners were invoked. >> >> Updated the code to dispose listene

Integrated: 8305867: BitSetShim: The type parameter T is hiding the type T warning

2023-04-12 Thread Andy Goryachev
On Tue, 11 Apr 2023 20:46:37 GMT, Andy Goryachev wrote: > Fixed minor warnings in Eclipse. This pull request has now been integrated. Changeset: 4d7aaa48 Author:Andy Goryachev URL: https://git.openjdk.org/jfx/commit/4d7aaa485a0eebc39329a0ca0febdf6399f8012f Stats: 3 lines in 1 fi

Re: RFR: 8305867: BitSetShim: The type parameter T is hiding the type T warning

2023-04-12 Thread Kevin Rushforth
On Tue, 11 Apr 2023 20:46:37 GMT, Andy Goryachev wrote: > Fixed minor warnings in Eclipse. Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1086#pullrequestreview-1381070368

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol

2023-04-12 Thread Ambarish Rapte
On Thu, 6 Apr 2023 20:43:13 GMT, Alexander Zuev wrote: > Add the common base component for all the new implementing native classes > Change native peer creation to use the new base component The new code will > instantiate new protocol implementation for the given role if it exists or > an ol

Concatenated observable lists

2023-04-12 Thread Michael Strauß
The JavaFX collections framework offers the `FXCollections.concat(ObservableList...)` method, which creates a new modifiable list that contains a concatenated snapshot of the source lists, backed by an `ArrayList`. However, when the source lists are changed, the concatenated list is not updated. I