On Mon, 10 Apr 2023 17:21:34 GMT, Hima Bindu Meda wrote:
> Clean Backport.This pull request contains a backport of commit
> [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull req
Hi,
I noticed that the JDK's javadoc contains a 'NEW' section [1], but
JavaFX's docs don't have it. Do we need to update the javadoc tool?
[1] https://docs.oracle.com/en/java/javase/19/docs/api/new-list.html
- Nir
On Mon, 10 Apr 2023 00:14:31 GMT, John Hendrikx wrote:
> Well, I am just following the specification here, but JavaFX itself isn't...
>
> We may need to make a decision here. JavaFX is not consistent itself where it
> applies `equals` and where it uses reference equality:
Alright, so this is f
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Mon, 10 Apr 2023 17:19:15 GMT, Jay Bhaskar wrote:
> clean backport to jfx20u. The fix solves the build issue on the macOx11_64
> machine. It fixes the intermittent build issue. The build issue occurs
> without the fix and does not occur with the fix.
This pull request has now been integrate
On Mon, 10 Apr 2023 23:55:51 GMT, Martin Fox wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
>> key) the glass code will dynamically query the key's unshifted character to
>> determine the Java code to assign to it. This is necessary since the
>> relationsh
> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
> key) the glass code will dynamically query the key's unshifted character to
> determine the Java code to assign to it. This is necessary since the
> relationship between OEM key codes and the characters they generate
On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx wrote:
> BitSet uses the SetListenerHelper abstraction to prevent allocating the
> listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be
> different from the one called) is not reassigned. This effectively
On Mon, 10 Apr 2023 23:08:31 GMT, John Hendrikx wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Mon, 10 Apr 2023 23:08:31 GMT, John Hendrikx wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Mon, 10 Apr 2023 22:07:41 GMT, John Hendrikx wrote:
>> As with the earlier comment, any changes to the behavior of a null listener
>> should be done separately and not part of this PR.
>
> Alright, I'll file another ticket for that. The general state of this class
> is quite poor, as it doe
> BitSet uses the SetListenerHelper abstraction to prevent allocating the
> listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be
> different from the one called) is not reassigned. This effectively means that
> removing the listener does not happen.
>
On Thu, 6 Apr 2023 20:43:13 GMT, Alexander Zuev wrote:
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an ol
On Fri, 7 Apr 2023 18:28:28 GMT, Martin Fox wrote:
>> PR looks good and works fine on Windows 11.
>>
>> I've tested the test attached to the JBS issue with a Spanish keyboard. It
>> fails without the patch for `+`, `'`, `¡`, and passes with it.
>>
>> There is a NPE if you press AltGr (with or
On Fri, 7 Apr 2023 17:19:56 GMT, Martin Fox wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
>> key) the glass code will dynamically query the key's unshifted character to
>> determine the Java code to assign to it. This is necessary since the
>> relationshi
On Mon, 10 Apr 2023 20:45:22 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 617:
>>
>>> 615: @Override
>>> 616: public void removeListener(InvalidationListener
>>> invalidationListener) {
>>> 617: if (invalidationList
On Mon, 10 Apr 2023 21:14:02 GMT, Michael Strauß wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effec
On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx wrote:
> BitSet uses the SetListenerHelper abstraction to prevent allocating the
> listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be
> different from the one called) is not reassigned. This effectively
On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx wrote:
> BitSet uses the SetListenerHelper abstraction to prevent allocating the
> listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be
> different from the one called) is not reassigned. This effectively
On Mon, 3 Apr 2023 06:29:58 GMT, Michael Strauß wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx wrote:
> BitSet uses the SetListenerHelper abstraction to prevent allocating the
> listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be
> different from the one called) is not reassigned. This effectively
On Mon, 3 Apr 2023 07:23:28 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 603:
>>
>>> 601: @Override
>>> 602: public void removeListener(SetChangeListener
>>> setChangeListener) {
>>> 603: if (setChangeListener != null
On Wed, 5 Apr 2023 13:25:00 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> tests/manual/events/KeyboardTest.java line 458:
>
>> 456: G
On Mon, 10 Apr 2023 18:54:44 GMT, Alexander Zuev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java
>> line 807:
>>
>>> 805: if (this.peer == 0L) {
>>> 806: AccessibleRole role = (AccessibleRole) getAttribute(ROLE);
>>> 807: i
On Wed, 5 Apr 2023 12:51:31 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 47
On Wed, 5 Apr 2023 12:39:28 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 19
On Wed, 5 Apr 2023 12:36:37 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 19
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layout). The new code first identifies a set of Mac keys wh
On Sat, 8 Apr 2023 14:19:34 GMT, Kevin Rushforth wrote:
>> Add the common base component for all the new implementing native classes
>> Change native peer creation to use the new base component The new code will
>> instantiate new protocol implementation for the given role if it exists or
>>
On Sat, 8 Apr 2023 14:18:56 GMT, Kevin Rushforth wrote:
>> Add the common base component for all the new implementing native classes
>> Change native peer creation to use the new base component The new code will
>> instantiate new protocol implementation for the given role if it exists or
>>
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Mon, 27 Mar 2023 14:36:45 GMT, John Hendrikx wrote:
>> Makes `Subscription` public (removing some of its methods that are
>> unnecessary), and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Sat, 8 Apr 2023 14:16:57 GMT, Kevin Rushforth wrote:
>> Add the common base component for all the new implementing native classes
>> Change native peer creation to use the new base component The new code will
>> instantiate new protocol implementation for the given role if it exists or
>>
clean backport to jfx20u. The fix solves the build issue on the macOx11_64
machine. It fixes the intermittent build issue. The build issue occurs without
the fix and does not occur with the fix.
-
Commit messages:
- Backport 810bd90d5089364067549b8ba299300bfd208357
Changes: https:
Clean Backport.This pull request contains a backport of commit
[a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport a264435dccba6ec386548f76f1ace095d9
On Thu, 13 Oct 2022 00:48:09 GMT, Thiago Milczarek Sayao
wrote:
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size beca
Here is the proposed schedule for JavaFX 21.
RDP1: Jul 13, 2023 (aka “feature freeze”)
RDP2: Aug 3, 2023
Freeze: Aug 31, 2023
GA: Sep 19, 2023
We plan to fork a jfx21 stabilization branch at RDP1.
The start of RDP1, the start of RDP2, and the code freeze will be 16:00
UTC on the respective dat
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
> When custom skin was loaded, the listeners added in `ContextMenuContent`
> class while loading the default skin were not removed. This was causing the
> NPE when outdated listeners were invoked.
>
> Updated the code to dispose listeners in the `dispose` method of
> `ContextMenuSkin` so that w
39 matches
Mail list logo
