On Thu, 13 Oct 2022 00:48:09 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
> This cleans size and positioning code, reducing special cases, code > complexity and size. > > Changes: > > - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different > sizes. It does not assume any size because it varies - it does cache because > it's unlikely to vary on the same system - but if it does occur, it will only > waste a resize event. > - window geometry, min/max size are centralized in > `update_window_constraints`; > - Frame extents (the window decoration size used for "total window size"): > - frame extents are received in `process_property_notify`; > - removed quirks in java code; > - When received, call `set_bounds` again to adjust the size (to account > decorations later received); > - Removed `activate_window` because it's the same as focusing the window. > `gtk_window_present` will deiconify and focus it. > - `ensure_window_size` was a quirk - removed; > - `requested_bounds` removed - not used anymore; > - `window_configure` incorporated in `set_bounds` with `gtk_window_move` and > `gtk_window_resize`; > - `process_net_wm_property` is a work-around for Unity only (added a check if > Unity - but it can probably be removed at some point) > - `restack` split in `to_front()` and `to_back()` to conform to managed code; This pull request has now been integrated. Changeset: 0c03a411 Author: Thiago Milczarek Sayao <tsa...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/0c03a411655047a393862eda937408aa90fc3fa9 Stats: 750 lines in 5 files changed: 175 ins; 434 del; 141 mod 8260528: Clean glass-gtk sizing and positioning code Reviewed-by: jvos, kcr ------------- PR: https://git.openjdk.org/jfx/pull/915
