> This unifies and organizes WindowContext of the glass-gtk.
>
> It does not change any behaviour, just reorganizes the code.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Unrelated file
-
Changes:
- all:
This unifies and organizes WindowContext of the glass-gtk.
It does not change any behaviour, just reorganizes the code.
-
Commit messages:
- Unify WindowContext
- Unify window contexts
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merg
On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote:
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects. T
On Sun, 2 Apr 2023 23:36:27 GMT, Martin Fox wrote:
>> @beldenfox Could you point out which tests were failing?
>> `test.robot.javafx.embed.swing.SwingNodeJDialogTest` is getting stuck for me.
>
> @tsayao The best place to start is with the manual test that I added to PR
> #425 (KeyboardTest.jav
On Fri, 3 Mar 2023 01:13:49 GMT, Thiago Milczarek Sayao
wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know
>> style mistakes);
>> - Configures auto-format to sun style (with t
On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote:
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects. T
On Thu, 23 Mar 2023 08:31:41 GMT, Florian Kirmaier
wrote:
>> When an exception is logged in JavaFX, then the exception is kept in a
>> reference.
>> This way, always the last logged exception is retained.
>>
>> This is a memory-leak.
>> This was done to write unit-tests to ensure certain error
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Fri, 31 Mar 2023 13:24:27 GMT, Kevin Rushforth wrote:
>> The CSS API baffles me a bit. It doesn't seem consistent.
>>
>> Just now I took a look at the class `SimpleSelector` and `CompoundSelector`.
>> These are public, yet cannot be constructed by users. They're also not
>> returned anywh
On Fri, 7 Apr 2023 06:22:05 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Wed, 13 Oct 2021 10:52:40 GMT, Fabian Wolter wrote:
> There are sometimes multitouch events detected, when only a single touch
> should be detected under certain conditions. This lead to touch events on
> previous touch positions.
>
> The referenced bug is closed with "won't fix" with the j
On Fri, 7 Apr 2023 17:19:56 GMT, Martin Fox wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
>> key) the glass code will dynamically query the key's unshifted character to
>> determine the Java code to assign to it. This is necessary since the
>> relationshi
On Thu, 6 Apr 2023 11:48:58 GMT, Jose Pereda wrote:
> I wonder if RobotKeySanityTest could be part of the PR as a manual test? Same
> as in #694
The RobotKeySanityTest is tricky, it requires the user to press a lot of keys
to get good coverage but can produce confusing results if the user pres
> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead
> key) the glass code will dynamically query the key's unshifted character to
> determine the Java code to assign to it. This is necessary since the
> relationship between OEM key codes and the characters they generate
On Fri, 24 Mar 2023 21:37:16 GMT, Phil Race wrote:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
On Fri, 7 Apr 2023 06:22:05 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Sun, 2 Apr 2023 20:49:38 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any siz
On Thu, 6 Apr 2023 13:03:04 GMT, Karthik P K wrote:
> When custom skin was loaded, the listeners added in `ContextMenuContent`
> class while loading the default skin were not removed. This was causing the
> NPE when outdated listeners were invoked.
>
> Updated the code to dispose listeners in
On Thu, 6 Apr 2023 13:03:04 GMT, Karthik P K wrote:
> When custom skin was loaded, the listeners added in `ContextMenuContent`
> class while loading the default skin were not removed. This was causing the
> NPE when outdated listeners were invoked.
>
> Updated the code to dispose listeners in
On Fri, 7 Apr 2023 08:43:14 GMT, Johan Vos wrote:
>>> @johanvos You might want to take a look at this, since it supersedes your
>>> earlier PR #547.
>>
>> It also supersedes #553
>
>> @johanvos did you have any comments on this PR?
>
> This approach is a much better approach to fix PR #547 and
On Fri, 7 Apr 2023 06:36:50 GMT, John Hendrikx wrote:
>> Description copied from issue:
>>
>> There are up to two additional invalidations performed that really should be
>> avoided, causing downstream fluent bindings to be recomputed with the same
>> values. This is very confusing as these s
On Fri, 7 Apr 2023 08:15:08 GMT, Johan Vos wrote:
>> @johanvos You might want to take a look at this, since it supersedes your
>> earlier PR #547.
>
>> @johanvos You might want to take a look at this, since it supersedes your
>> earlier PR #547.
>
> It also supersedes #553
> @johanvos did you
On Thu, 6 Apr 2023 20:17:15 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
On Thu, 6 Apr 2023 20:17:15 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text - ran
On Tue, 4 Apr 2023 21:16:49 GMT, Phil Race wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTGlyphLayout.java
>> line 83:
>>
>>> 81: if (fr == null) return -1;
>>> 82: slot = fr.getSlotForFont(fontName);
>>> 83: if (slot == -1) {
On Mon, 3 Apr 2023 22:30:45 GMT, Kevin Rushforth wrote:
> @johanvos You might want to take a look at this, since it supersedes your
> earlier PR #547.
It also supersedes #553
-
PR Comment: https://git.openjdk.org/jfx/pull/1067#issuecomment-1500058222
27 matches
Mail list logo
