On Fri, 7 Apr 2023 17:19:56 GMT, Martin Fox <d...@openjdk.org> wrote:
>> When processing a `WM_CHAR` event on an OEM key (punctuation, symbol, dead >> key) the glass code will dynamically query the key's unshifted character to >> determine the Java code to assign to it. This is necessary since the >> relationship between OEM key codes and the characters they generate varies >> from layout to layout. >> >> The Robot implementation was consulting a table which assumed a fixed >> relationship between Java codes and Windows key codes even for the OEM keys. >> The table was also missing entries for any Java code not on a US QWERTY >> layout, like PLUS. >> >> In this PR if we don't find the Java code in the table or if it maps to an >> OEM key (which may be wrong) we sweep through all the OEM keys looking for >> the matching Java code. > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Updated license header copyrights Looks good! Okay, makes sense. I'll approve this PR as is then, if you modify it for any reason, I'll review again. ------------- Marked as reviewed by jpereda (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/702#pullrequestreview-1376508988 PR Comment: https://git.openjdk.org/jfx/pull/702#issuecomment-1500569428
