RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed

2023-03-09 Thread John Hendrikx
Description copied from issue: There are up to two additional invalidations performed that really should be avoided, causing downstream fluent bindings to be recomputed with the same values. This is very confusing as these should only be called when there is an actual change, and not called fo

Integrated: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex()

2023-03-09 Thread Phil Race
On Tue, 7 Mar 2023 19:54:15 GMT, Phil Race wrote: > This fixes an the AIOOBE when finding a line break point in RTL laid out > glyphs. > The comment in the bug report explains how we can end up trying to find an > unachievable break point and yet there's no "stop" on the search when we've > ru

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v3]

2023-03-09 Thread Andy Goryachev
On Wed, 8 Mar 2023 19:36:54 GMT, Phil Race wrote: >> This fixes an the AIOOBE when finding a line break point in RTL laid out >> glyphs. >> The comment in the bug report explains how we can end up trying to find an >> unachievable break point and yet there's no "stop" on the search when we've

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v3]

2023-03-09 Thread Kevin Rushforth
On Wed, 8 Mar 2023 19:36:54 GMT, Phil Race wrote: >> This fixes an the AIOOBE when finding a line break point in RTL laid out >> glyphs. >> The comment in the bug report explains how we can end up trying to find an >> unachievable break point and yet there's no "stop" on the search when we've

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v2]

2023-03-09 Thread Kevin Rushforth
On Wed, 8 Mar 2023 19:20:21 GMT, Phil Race wrote: >> tests/system/src/test/java/test/javafx/scene/text/ArabicWrappingTest.java >> line 46: >> >>> 44: import java.util.TimerTask; >>> 45: >>> 46: public class ArabicWrappingTest extends Application { >> >> The main test class should not extend A

Re: RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 [v3]

2023-03-09 Thread Lukasz Kostyra
> Issue happened during setting a new Scene - updating a new View was done > while the Window reference it kept was null. This caused it to default > scaling values to 1.0f (or 100%) while processing a resize notification, > which for high DPI screens with scaling different than 100% caused UI i

Re: RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 [v2]

2023-03-09 Thread Lukasz Kostyra
On Tue, 7 Mar 2023 15:20:50 GMT, Lukasz Kostyra wrote: >> Issue happened during setting a new Scene - updating a new View was done >> while the Window reference it kept was null. This caused it to default >> scaling values to 1.0f (or 100%) while processing a resize notification, >> which for

Gradle help

2023-03-09 Thread Thiago Milczarek Sayão
Hi, https://github.com/openjdk/jfx/pull/1009 For this PR, Intellij Idea is not importing the systemTests dependencies correctly. I noticed that it's this part: dependencies { testImplementation project(":graphics").sourceSets.test.output testImplementation project(":base").sourc

Re: RFR: 8303680 Virtual Flow freezes after calling scrollTo and scrollPixels in succession

2023-03-09 Thread Johan Vos
On Tue, 7 Mar 2023 09:47:39 GMT, Florian Kirmaier wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 1718: >> >>> 1716: // Finally, update the scroll bars >>> 1717: updateScrollBarsAndCells(false); >>> 1718: lastPosition =