Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v3]

2023-03-08 Thread Andy Goryachev
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 19:36:54 GMT, Phil Race wrote:

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v3]

2023-03-08 Thread Phil Race
> This fixes an the AIOOBE when finding a line break point in RTL laid out > glyphs. > The comment in the bug report explains how we can end up trying to find an > unachievable break point and yet there's no "stop" on the search when we've > run out of glyphs so hence the exception. > > The fix

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v2]

2023-03-08 Thread Phil Race
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 12:29:45 GMT, Kevin Rushforth wr

Re: RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 [v2]

2023-03-08 Thread Kevin Rushforth
On Tue, 7 Mar 2023 15:20:50 GMT, Lukasz Kostyra wrote: >> Issue happened during setting a new Scene - updating a new View was done >> while the Window reference it kept was null. This caused it to default >> scaling values to 1.0f (or 100%) while processing a resize notification, >> which for

Re: Allow to extend NumberAxis

2023-03-08 Thread Kevin Rushforth
Hi Marc, > Is there any good reason not to remove the “final” modifier from the class definition? Providing extensibility is not as simple as "removing the final modifier". This would be an API change that needs to be motivated and discussed just like any other API change. That discussion ne

Re: RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception

2023-03-08 Thread Kevin Rushforth
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote: > When an exception is logged in JavaFX, then the exception is kept in a > reference. > This way, always the last logged exception is retained. > > This is a memory-leak. > This was done to write unit-tests to ensure certain error-cases a

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v2]

2023-03-08 Thread Kevin Rushforth
On Tue, 7 Mar 2023 22:03:12 GMT, Phil Race wrote: >> This fixes an the AIOOBE when finding a line break point in RTL laid out >> glyphs. >> The comment in the bug report explains how we can end up trying to find an >> unachievable break point and yet there's no "stop" on the search when we've

Re: RFR: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex() [v2]

2023-03-08 Thread Ajit Ghaisas
On Tue, 7 Mar 2023 22:03:12 GMT, Phil Race wrote: >> This fixes an the AIOOBE when finding a line break point in RTL laid out >> glyphs. >> The comment in the bug report explains how we can end up trying to find an >> unachievable break point and yet there's no "stop" on the search when we've

Allow to extend NumberAxis

2023-03-08 Thread Toni, Marc
Hi All, There is an open Enhancement issue (https://bugs.openjdk.org/browse/JDK-8090467), back from 2011, to allow extending from the NumberAxis class. We (at Vector Germany) want to extend from NumberAxis to overwrite the implementations of "calculateTickValues" and "calculateMinorTickMarks"

Re: RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception

2023-03-08 Thread Florian Kirmaier
On Wed, 8 Mar 2023 08:19:25 GMT, John Hendrikx wrote: >> I think it's cleaner, to just have nothing in production. >> The flag is a bit ugly - just aesthetically, but I don't think it's a >> problem. > >> I think it's cleaner, to just have nothing in production. The flag is a bit >> ugly - just

Re: RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception

2023-03-08 Thread John Hendrikx
On Wed, 8 Mar 2023 07:53:22 GMT, Florian Kirmaier wrote: > I think it's cleaner, to just have nothing in production. The flag is a bit > ugly - just aesthetically, but I don't think it's a problem. IMHO, the `Logging` class should also not be there, as it is just a facade for `PlatformLogger`