Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-20 Thread Ajit Ghaisas
On Tue, 20 Sep 2022 18:59:40 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java >> line 840: >> >>> 838: /** TreeTableView with cell selection enabled should not select >>> TreeTableRows */ >>> 839: @Test >>> 840: pub

Integrated: 8293839: Documentation memory consistency effects of runLater

2022-09-20 Thread Jens Lidestrom
On Wed, 17 Aug 2022 07:21:43 GMT, Jens Lidestrom wrote: > Prior to this change it was not clear from the documentation if callers of > Platform#runLater must perform > any synchronisation to have writes of the calling thread be visible in the > JavaFX Application > Thread. It is important to do

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-20 Thread Andy Goryachev
On Tue, 20 Sep 2022 12:49:01 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292353: review comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlUtils.java > lin

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v12]

2022-09-20 Thread Andy Goryachev
> The issue is caused by TreeTableRow incorrectly selected when cell selection > mode is enabled. > > Changes: > - modified TreeTableRow.updateSelection() Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8292353: review comments -

Re: RFR: 8293839: Documentation memory consistency effects of runLater

2022-09-20 Thread Kevin Rushforth
On Thu, 15 Sep 2022 12:10:25 GMT, Jens Lidestrom wrote: >>> Do I remove the summary by issuing and empty `/summary`? >>> >>> Will the commit message of the squshed commit be taken from the PR >>> description? >> >> Yes to both questions. > > @kevinrushforth I think this is now finished. > > T

Re: Provide Quit handler for system menu bar

2022-09-20 Thread Philip Race
All of these requests seem to map to what we added to AWT in JDK 9. We did this because there'd been Apple specific APIs that came in via the Apple port but were very iffy in terms of what was supported and it was not a good idea to formally export them from the new desktop module. The java.awt.D

Re: Provide Quit handler for system menu bar

2022-09-20 Thread Scott Palmer
I always understood Alt+F4 as simply being a keyboard shortcut on Windows for closing the window of the active application. The same as clicking the close widget. I don’t think there is anything special about it. As far as being an equivalent to the macOS Quit action, I don’t think it is quit

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-20 Thread Ajit Ghaisas
On Mon, 19 Sep 2022 15:44:58 GMT, Andy Goryachev wrote: >> The issue is caused by TreeTableRow incorrectly selected when cell selection >> mode is enabled. >> >> Changes: >> - modified TreeTableRow.updateSelection() > > Andy Goryachev has updated the pull request incrementally with one addition

Re: Provide Quit handler for system menu bar

2022-09-20 Thread John Hendrikx
What about Alt + F4 and Ctrl + F4 on Windows?  Alt + F4 closes the application (which works with JavaFX already) and Ctrl + F4 is supposed to close a single window, but that doesn't work for JavaFX. Also very much in favor of Keeping the API platform neutral, that's just how Java has worked si

Re: RFR: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues [v4]

2022-09-20 Thread danielpeintner
On Mon, 22 Aug 2022 09:46:24 GMT, Florian Kirmaier wrote: >> It's "a bit" complicated. >> In some situations, getRuns get's called because listeners on bounds are set. >> This causes TextFlow to layout to compute the runs. >> Afterward, the bounds of the parents get updated. >> This triggers a