Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-22 Thread Konrad Weihmann
Another point where I encounter this warning is when using devtool, as externalsrc is injected via bbappend. After browsing through the code here [1] I was wondering if all that is like it is supposed to be - if I understand the code correctly [2] the bbappends should be applied before the BBCLA

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-12 Thread Richard Purdie
On Fri, 2021-02-12 at 18:26 +, Peter Kjellerstedt wrote: > Since the order of inheriting native/nativesdk is important, rather > than adding warnings about when it is done in the wrong order, which > conflicts with bbappends that want to add inherit statements for > native recipes, wouldn’t it

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-12 Thread Peter Kjellerstedt
/2] insane: Add test for native/nativesdk inherit order >After this patch got merged I notice some "noise" in my builds. > >For bbappends which inherit unrelated classes I get a lot of warning like > >Issue: nativesdk-openssh: native/nativesdk class is not inherited

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Konrad Weihmann
On 11.02.21 15:59, Richard Purdie wrote: On Thu, 2021-02-11 at 15:47 +0100, Konrad Weihmann wrote: On 11.02.21 14:04, Richard Purdie wrote: On Thu, 2021-02-11 at 13:10 +0100, Konrad Weihmann wrote: On 11.02.21 12:43, Richard Purdie wrote: On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Richard Purdie
On Thu, 2021-02-11 at 15:47 +0100, Konrad Weihmann wrote: > > On 11.02.21 14:04, Richard Purdie wrote: > > On Thu, 2021-02-11 at 13:10 +0100, Konrad Weihmann wrote: > > > > > > On 11.02.21 12:43, Richard Purdie wrote: > > > > On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann wrote: > > > > > Aft

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Konrad Weihmann
On 11.02.21 14:04, Richard Purdie wrote: On Thu, 2021-02-11 at 13:10 +0100, Konrad Weihmann wrote: On 11.02.21 12:43, Richard Purdie wrote: On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann wrote: After this patch got merged I notice some "noise" in my builds. For bbappends which inherit

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Richard Purdie
On Thu, 2021-02-11 at 13:10 +0100, Konrad Weihmann wrote: > > On 11.02.21 12:43, Richard Purdie wrote: > > On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann wrote: > > > After this patch got merged I notice some "noise" in my builds. > > > > > > For bbappends which inherit unrelated classes I ge

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Konrad Weihmann
On 11.02.21 12:43, Richard Purdie wrote: On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann wrote: After this patch got merged I notice some "noise" in my builds. For bbappends which inherit unrelated classes I get a lot of warning like Issue: nativesdk-openssh: native/nativesdk class is not

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Richard Purdie
On Thu, 2021-02-11 at 08:21 +0100, Konrad Weihmann wrote: > After this patch got merged I notice some "noise" in my builds. > > For bbappends which inherit unrelated classes I get a lot of warning like > > Issue: nativesdk-openssh: native/nativesdk class is not inherited last, > this can result

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-11 Thread Tomasz Dziendzielski
>After this patch got merged I notice some "noise" in my builds. > >For bbappends which inherit unrelated classes I get a lot of warning like > >Issue: nativesdk-openssh: native/nativesdk class is not inherited last, >this can result in unexpected behaviour. Classes inherited after >native/nativesd

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-02-10 Thread Konrad Weihmann
After this patch got merged I notice some "noise" in my builds. For bbappends which inherit unrelated classes I get a lot of warning like Issue: nativesdk-openssh: native/nativesdk class is not inherited last, this can result in unexpected behaviour. Classes inherited after native/nativesdk: m

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-01-27 Thread Tomasz Dziendzielski
Hello Martin, I have just submitted patches with fix for missing INSANE_SKIP and printing shortlist of classes inherited after native/nativesdk. Please check: https://lists.openembedded.org/g/openembedded-core/message/147370 https://lists.openembedded.org/g/openembedded-core/message/147371 Sorry

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-01-27 Thread Tomasz Dziendzielski
>Would it make sense to show some shortened version of inherited_classes? Yes, it wouldn't be a problem to continue the loop until native/nativesdk recipe is found and then just print the classes that were found. >Unfortunately INSANE_SKIP doesn't seem to work with native-last as well. Is this exp

Re: [OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-01-27 Thread Martin Jansa
Would it make sense to show some shortened version of inherited_classes? The whole variable is too long, e.g. in my case with: diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 3597943ddd..03481489c3 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbcl

[OE-core] [PATCH 1/2] insane: Add test for native/nativesdk inherit order

2021-01-24 Thread Tomasz Dziendzielski
Classes native/nativesdk should be inherited last to prevent unexpected behaviour. [YOCTO #5729] Signed-off-by: Tomasz Dziendzielski --- meta/classes/insane.bbclass | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/met