Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-31 Thread Trevor Woerner
On Wed, May 31, 2017 at 3:15 AM, Jussi Kukkonen wrote: > On 30 May 2017 at 19:19, Richard Purdie > wrote: >> If someone really wants to enable it, they can drop the patch. I'm open >> to feedback from others like Ross/Jussi but IMO I think we can accept >> the degraded piglit results for swrast..

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-31 Thread Jussi Kukkonen
On 30 May 2017 at 19:19, Richard Purdie wrote: > > On Tue, 2017-05-30 at 12:00 -0400, Trevor Woerner wrote: > > On Tue, May 30, 2017 at 11:44 AM, Richard Purdie > > wrote: > > > > > > > > > > > Maybe this would be a better way forward? Enable it, always, in > > > > ./configure, > > > > add the pa

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-30 Thread Richard Purdie
On Tue, 2017-05-30 at 12:00 -0400, Trevor Woerner wrote: > On Tue, May 30, 2017 at 11:44 AM, Richard Purdie > wrote: > > > > > > > > Maybe this would be a better way forward? Enable it, always, in > > > ./configure, > > > add the patch to check for it in the code itself, then you can > > > build

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-30 Thread Trevor Woerner
On Tue, May 30, 2017 at 11:44 AM, Richard Purdie wrote: >> Maybe this would be a better way forward? Enable it, always, in >> ./configure, >> add the patch to check for it in the code itself, then you can build >> for all >> the gallium targets (including swrast) and know that the patented >> code

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-30 Thread Richard Purdie
On Tue, 2017-05-30 at 11:27 -0400, Trevor Woerner wrote: > Here is the relevant part of Fedora's mesa.spec file for Fedora 25 > (with line > numbers): > >400 %configure \ >401 %{?asm_flags} \ >402 --enable-libglvnd \ >403 --enable-selinux \ >404 

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-30 Thread Trevor Woerner
On Tue 2017-05-30 @ 08:47:55 AM, Richard Purdie wrote: > We should look at how Fedora "just bars float on llvmpipe and softpipe" > and perhaps look at copying that? Not that we enable llvmpipe at the > moment either mind so presumably we're using softpipe. If you build for AMD's gizmo2 (meta-amd),

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-30 Thread Richard Purdie
On Tue, 2017-05-30 at 01:28 -0400, Trevor Woerner wrote: > On Mon, May 29, 2017 at 7:25 PM, Richard Purdie > wrote: > > > > On Fri, 2017-05-26 at 17:22 -0400, Trevor Woerner wrote: > > > > > > Somewhere along the path from OpenGL ES 2.0 to OpenGL ES 3.0 are > > > some > > > algorithms that are e

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-29 Thread Trevor Woerner
Hi Richard, Thanks for your review. On Mon, May 29, 2017 at 7:25 PM, Richard Purdie wrote: > On Fri, 2017-05-26 at 17:22 -0400, Trevor Woerner wrote: >> Somewhere along the path from OpenGL ES 2.0 to OpenGL ES 3.0 are some >> algorithms that are encumbered by patents. These algorithms are >> ena

Re: [OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-29 Thread Richard Purdie
On Fri, 2017-05-26 at 17:22 -0400, Trevor Woerner wrote: > Somewhere along the path from OpenGL ES 2.0 to OpenGL ES 3.0 are some > algorithms that are encumbered by patents. These algorithms are > enabled with > mesa's --enable-texture-float configure flag. However, if hardware > acceleration is be

[OE-core] [PATCH] mesa: potentially enable texture float for gallium

2017-05-26 Thread Trevor Woerner
Somewhere along the path from OpenGL ES 2.0 to OpenGL ES 3.0 are some algorithms that are encumbered by patents. These algorithms are enabled with mesa's --enable-texture-float configure flag. However, if hardware acceleration is being used and the hardware supports --enable-texture-float, it means