D7662: Draw a dark rectangle around highlighted search results

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: ngraham, aacid

D7662: Draw a dark rectangle around highlighted search results

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: aacid, ngraham

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham created this revision. ngraham added a project: Okular. REVISION SUMMARY Changed the colors used from the active theme so that there is never a white-on-light-blue situation that makes the text unreadable. Here are the changes when using the Breeze color scheme: - When an inac

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 To: ngraham, aacid, #okular, #kde_applications, broulik, sander Cc: aacid

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham added a comment. I did test with Oxygen, as that's a built-in theme. It looks fine: F3911431: Change with Oxygen.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 To: ngraham, aacid, #okular, #kde_applications

D7714: Show dialog to ask when closing when more than tab open

ngraham added reviewers: Okular, KDE Applications. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

ngraham added a comment. I'm willing to commandeer this patch and with with folks to do the wording change. Do you approve, Albert? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

ngraham added a comment. So for the record, I agree with folks that our "are you sure you want to close all these tabs" dialogs could stand for a bit of usability polishing. However, that's a larger task--one that I am willing to spearhead, but nonetheless outside the scope of this parti

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham added a comment. Oh I see. Here's how it looks with the Oxygen style: F3917149: Screenshot_20170918_220609.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 To: ngraham, aacid, #okular, #kde_applications, bro

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham updated this revision to Diff 19720. ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added a comment. Removed unnecessary parentheses and cleaned up the summary/commit message REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE htt

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

ngraham updated this revision to Diff 19721. ngraham added a comment. Missed one more tiny formatting issue REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7793?vs=19720&id=19721 REVISION DETAIL https://phabricator.kde.org/D7793 AFFECTED FILES ui/sideba

D7793: Fix sidebar labels being unreadable when selected or hovered over

ngraham retitled this revision from "Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme" to "Fix sidebar labels being unreadable when selected or hovered over". ngraham edited the summary of this revision. REPOSITORY

D7793: Fix sidebar labels being unreadable when selected or hovered over

ngraham added a comment. Thanks Henrik! Yes, I have a developer account and should be able to commit now. I haven't had the time to actually set that up yet though. I'll look into it late tonight or tomorrow. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 To:

D7793: Fix sidebar labels being unreadable when selected or hovered over

ngraham added a comment. I managed to get `arc` set up. Am I basically going to do this? 1. `arc land --onto Applications/17.08` 2. `git checkout master; git merge Applications/17.08` One potential issue: `arc land --onto Applications/17.08 --preview` shows a large number of extran

D7793: Fix sidebar labels being unreadable when selected or hovered over

ngraham closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7793 To: ngraham, aacid, #okular, #kde_applications, broulik, sander, rkflx Cc: rkflx, aacid

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham added reviewers: Frameworks, Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, #okular Cc: #frameworks

D7962: Implement several new print scaling options

ngraham added a comment. Does this resolve https://bugs.kde.org/show_bug.cgi?id=348172, or does it only implement preliminary support for these new options? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7962 To: sander, #okular Cc: rkflx, michaelweghorn, ngraham, a

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. Yes, your work here is much appreciated. Since this fixes grayscale printing, can you mark it with "BUG: 368758"? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: rkflx, michaelweghorn, ngraham, aacid

D7874: Show tooltip for annotations without handle too

ngraham edited the summary of this revision. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D7874 To: aacid, rkflx Cc: rkflx, tobiasdeiminger, #okular, aacid

D8051: Enable custom background color to be enabled and changed from settings

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: aacid

D8051: Enable custom background color to be enabled and changed from settings

ngraham added a comment. Nice! Can you add some details of your testing to the Test Plan section? A screenshot of the new functionality is always very much appreciated. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: ngraham,

D6268: HiDPI Support for Okular

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid

D8051: Custom background color

ngraham added reviewers: aacid, elvisangelaccio, rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx Cc: aacid, ltoscano, ngraham

D7874: Show tooltip for annotations without handle too

ngraham added a comment. Sorry, I was under the impression that only "BUG: [number]" worked. I didn't know that "BUGS:" worked too. Is that used to indicate multiple bugs? REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D7874 To: aacid, rk

D8051: Custom background color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The patch applies cleanly and the feature works well. Nice job! @aacid and @rkflx, if there are no other objections, should we get this into 17.08, or just master? REPOSITORY R223

D8051: Custom background color

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. @aacid thanks for the info. Master it is, then. @albertfreeman, can you rename useCustomBackgroundColor() to something different? I agree with Albert that the "set" prefix w

D8051: Custom background color

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham Cc: aacid, ltoscano, ngraham

D8051: Custom background color

This revision was automatically updated to reflect the committed changes. Closed by commit R223:6b5a7c9a1a00: Custom background color (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8051?vs=20174&id=20175 REVISION DETAIL https://phabric

D8051: Custom background color

ngraham added a comment. Sorry about that, guys. I just did `arc land`. Was that not the right approach to land this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham Cc: aacid, ltoscano, ngraham

D6268: HiDPI Support for Okular

ngraham added a comment. Nice! Can we close this out so the bugs mentioned in the Summary get updated and marked as resolved? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: gladhorn, ngraham, rkflx, sander, anthon

D6268: HiDPI Support for Okular

ngraham added a comment. Gotcha. I've manually closed the bugs. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: ltoscano, gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid

D6696: Elide cut off text in sidebar header, remove restricted max width

ngraham added a comment. *raises hand* I care about Okular! I actually have to agree with Albert here, and I have what I believe to be a good reason for not allowing the thumbnail bar to be wider than the main view. In the screenshot Albert provided, it wasn't clear to me that the th

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. 1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything you can count (e.g. fewer columns, fewer people, fewer lines of co

D6696: Elide cut off text in sidebar header, remove restricted max width

ngraham added a comment. FWIW, Apple's Preview does something similar and limits the size of the sidebar to about 40% of the window's width. They elide the text, too. F5440829: PDF.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.

D6696: Elide cut off text in sidebar header, remove restricted max width

ngraham added a comment. FWIW, I don't think eliding the text is controversial at all; could we maybe break that out into a new patch so we can get that merged quickly? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6696 To: rkflx, #okular, aacid, sander, pino Cc: n

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. I'm fine with the new auto-reduction in columns feature going in and not being user-configurable. Perhaps this should be split into two patches: we can use this one for the above feature (minus to UI to turn it on and off), and a new one for a new "Auto" mode, w

D8379: PDF: Support the new poppler renderToImage with update callback

ngraham added a comment. This definitely looks like it implements that feature request. Can we add "BUG: 344081" to the Summary? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8379 To: aacid, #okular Cc: rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. @rkflx, what's the difference between FEATURE: and BUG:? @lexdem, once you've made the above changes to the Summary, I will be happy to formally approve this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: l

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. Oh I see, https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages says that it's used to aid whoever compiles the release notes, and should be used for actual new features. Anyone know if this is still the case? REPOSITORY R22

D8415: Soften correctness of image file open check

ngraham added a comment. Thanks for the patch: The Summary needs some reformatting: - Add the special keyword "BUG 385384" on its own line - Remove the quote from the Bugzilla ticket; instead briefly explain the change in your own words - No need to explain the code change; it should

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham accepted this revision. ngraham added a comment. +1 here too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham

D7662: Draw a dark rectangle around highlighted search results

ngraham added a comment. Any progress on this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: cfeck, aacid, ngraham

D8612: Fix CMake Error in generators/spectre/CMakeLists.txt

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D8612 To: rkflx, #okular, ngraham Cc: aacid

D8415: Soften correctness of image file open check

ngraham added a comment. Could we add the local workaround here, and include a FIXME comment urging an upstream fix later? Gwenview already has this workaround... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular Cc: aacid, progwolff

D8415: Soften correctness of image file open check

ngraham added a comment. That's a good idea. @trufanov, can you add that? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham added a comment. I am, yes. How does this sound? > This document appears malformed. Error: [error message] > Here is a best approximation of the document's intended appearance: This wording (or something similar) has the benefit that it casts Okular as a hero--bravely doin

D8415: Soften correctness of image file open check

ngraham added a comment. Yeah, in the above screenshot, `reader.errorString()` seems to have returned "Unable to read image data" which is not very helpful. How about a single line and the following text: > This document appears malformed. Here is a best approximation of the document's

D8415: Soften correctness of image file open check

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham accepted this revision. ngraham added a comment. @trufanov, would you like to make that change? If not I can do it, and either way, let's land this tonight. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid,

D8415: Soften correctness of image file open check

ngraham added a comment. OK, will do! REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham, #okular, aacid Cc: aacid, progwolff, ngraham

D8415: Soften correctness of image file open check

ngraham added a comment. Actually @trufanov, would you mind doing it? I'd rather not commandeer your revision or commit it by hand, both of which will break the history here on phabricator. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8415 To: trufanov, ngraham,

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > part.cpp:1720 > +res = KMessageBox::warningYesNo( widget(), > + i18n( "You have unsaved > modifications and the file has been modified externally since it was > opened.Unfortunately that mea

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1720 > I dont' like this wording, seems like it will let you not lose your changes > if you say "keep okular version". All you can do is "hopefully" still see > what is rendered, but doing much will probably also break rea

D8863: Give warnings when the file is modified externally

ngraham added a comment. > This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk: Right, that's what I originally thought this was all about. If the user can't, then this whole interface is almost rubbing salt in the wound: they're informed that t

D9043: Use a distinct and more appropriate icon for Layers

ngraham created this revision. ngraham added reviewers: aacid, Okular. Restricted Application added a project: Okular. REVISION SUMMARY BUG: 387424 TEST PLAN Tested in KDE Neon. Before: After: REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9043

D9043: Use a distinct and more appropriate icon for Layers

ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To: ngraham, aacid, #okular Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

ngraham added a comment. Darn. Can you think of a more universal icon that has an Oxygen equivalent? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To: ngraham, aacid, #okular Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To: ngraham, aacid, #okular Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

ngraham added a comment. Excellent idea, @rkflx. `format-list-unordered` is much better than what I had chosen anyway. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To: ngraham, aacid, #okular Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

ngraham updated this revision to Diff 23284. ngraham added a comment. Instead, use the format-list-unordered icon, which has an Oxygen version and is much better anyway REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9043?vs=23112&id=23284 BRANCH master

D9043: Use a distinct and more appropriate icon for Layers

ngraham closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To: ngraham, aacid, #okular Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

This revision was automatically updated to reflect the committed changes. Closed by commit R223:da89a035c1e2: Use a distinct and more appropriate icon for Layers (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9043?vs=23284&id=23368 REVIS

D9615: Fix calculation of TextAnnotation size so that select/move rectangle fits exactly around icons regardless of PDF page size and DPI settings

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9615 To: tobiasdeiminger, #okular Cc: #okular, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve message displayed when PDF wants to open in presentation mode

ngraham created this revision. ngraham added reviewers: Okular, aacid. Restricted Application added a project: Okular. ngraham requested review of this revision. REVISION SUMMARY BUG: 388511 TEST PLAN Okular still compiles and runs. I don't have any PDFs that request to be opened in presenta

D9692: Improve message displayed when PDF wants to open in presentation mode

ngraham updated this revision to Diff 24844. ngraham added a comment. - Returned to using a multi-line string - Updated wording - Made button text more expressive - Used standard on/cancel style icons for buttons REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.k

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham retitled this revision from "Improve message displayed when PDF wants to open in presentation mode" to "Improve dialog when PDF wants to open in presentation mode". ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D96

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > rkflx wrote in part.cpp:1630 > Why not just Cancel? Seems more common to me. > > Perhaps use `KStandardGuiItem::cancel()` and manually `setToolTip()`? I considered that, but that button doesn't actually c

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham updated this revision to Diff 24845. ngraham added a comment. With expressive buttons, we don't need explanatory tooltips amymore REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9692?vs=24844&id=24845 BRANCH master REVISION DETAIL https://phabri

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. Good point, that is too many presentation modes. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. How about this? F5625111: enter presentation mode.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. OK, maybe something more like this? F5625726: enter presentation mode.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ng

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. More polish: F5625744: Request to change viewing mode.png I try to add Albert as a reviewer for Okular patches since he is/was/has been a maintainer. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham marked 3 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham updated this revision to Diff 24855. ngraham edited the summary of this revision. ngraham added a comment. Polish and UI review REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9692?vs=24845&id=24855 BRANCH master REVISION DETAIL https://phabrica

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. I wasn't 100% sold on "Stay Here" either, but it was the best I could come up with at the time. That said, Okular's main window is definitely visible by the time the dialog shows up, so "here" would visually refer to that. How about this? F5625996: Request t

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. F5626016: Request to change viewing mode.png REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham edited the test plan for this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham updated this revision to Diff 24882. ngraham added a comment. Tweaks according to review comments REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9692?vs=24855&id=24882 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 AFFECTED FI

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. OK to land this now? And if so, onto `master` or `Applications/17.12`? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham added a comment. OK, so master, then, thanks. Can I land this? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

ngraham closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9857: Smooth Scrolling

ngraham added a comment. Awesome, I like smooth scrolling too, and would support its inclusion! But I wonder if this wouldn't be better implemented at the system level, to turn on smooth scrolling for all apps that use standard Qt scroll views. If that's not possible, then I guess this is fi

D9852: Fix crash due to dangling pointer in MouseAnnotation

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9852 To: tobiasdeiminger, #okular Cc: michaelweghorn, gassaf, ngraham, aacid

D9852: Fix crash due to dangling pointer in MouseAnnotation

ngraham added a comment. Thanks for the patch! FWIW, "BUG: 388228" has to be on its own line. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9852 To: tobiasdeiminger, #okular Cc: ngraham, michaelweghorn, gassaf, aacid

D10209: Added setCursor() call in the CloseButton constructor

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla Cc: #okular, michaelweghorn, ngraham, aacid

D10209: Added setCursor() call in the CloseButton constructor

ngraham added a comment. Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working? Also, the title of the revision is really better suited to being in the summary. For the title, try to briefly explain the overall purpose. Maybe somet

D10209: Added setCursor() call in the CloseButton constructor

ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Actually, the BUG: line can't be a link, I'm afraid. It has to be just: "BUG: " See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dilee

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Thanks! One more thing. The commit message has the following for your name: Author: RobStat Date: Wed Jan 31 10:54:37 2018 -0700 Would you mind using "Dileep Sankhla" instead of RobStat? for future patches? I'll correct it for this one. REPOSITORY R22

D10209: Use correct arrow cursor for Annotations' close buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R223:de56b9c9c165: Use correct arrow cursor for Annotations' close buttons (authored by dileepsankhla, committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Congratulations on your first patch! May it be the first of many more. If you're looking for inspiration, might I suggest checking out https://phabricator.kde.org/T6831? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla

D10249: Option to exit after printing

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular Cc: ngraham, aacid, #okular, michaelweghorn

D10298: Fix searching in RTL PDFs

ngraham created this revision. ngraham added a reviewer: Okular. Restricted Application added a project: Okular. ngraham requested review of this revision. REVISION SUMMARY BUG: 207748 Migrated this patch from https://git.reviewboard.kde.org/r/125442/ since it had whitespace errors and the

Re: Review Request 125442: [okular] fix Arabic & Hebrew search

> On July 21, 2016, 9:19 a.m., Olivier Churlaud wrote: > > ui/searchlineedit.cpp > > Lines 219 (patched) > > > > > > Before submitting patches, check with a `git diff` that you don't add > > whitespaces... I've

D10298: Fix searching in RTL PDFs

ngraham updated this revision to Diff 26510. ngraham added a comment. Update author REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10298?vs=26509&id=26510 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10298 AFFECTED FILES ui/searchlinee

D10298: Fix searching in RTL PDFs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10298 To: ngraham, #okular Cc: ltoscano, michaelweghorn, ngraham, aacid

D10566: Add support for code tags in fictionbook

ngraham added a comment. Thanks for your patch! For the summary section, please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch for information about how to format the BUG: tag to connect this patch with the Bugzilla ticket. REPOSITORY R223 Okular REVISION

  1   2   3   4   5   6   >