.
- Martin Tobias Holmedahl Sandsmark
On July 11, 2016, 10:05 p.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
> On July 11, 2016, 10:51 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Looks good to me, does basically the same as KDBusService.
>
> Olivier Churlaud wrote:
> Should I wait for a Ship it? A review from Albert?
>
> What about the noraise/raise bit ?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128424/#review97326
---
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
Montel.
Repository: okular
Description
---
This also re-adds the attempt at migrating the KPDF config.
Diffs
-
part.cpp f18e9c8
Diff: https://git.reviewboard.kde.org/r/128430/diff/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
------
On July 12, 2016, 8:13 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This is an automatically generated e-mail. To repl
---
Thanks,
Martin Tobias Holmedahl Sandsmark
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
.kde.org/r/128435/diff/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
> On Oct. 4, 2015, 10:32 p.m., Albert Astals Cid wrote:
> > This patch does not give me an image for the first page of the linked
> > document. Any idea what may be wrong?
>
> Boris Egorov wrote:
> Do you have warnings like this in terminal?
>
>
> OEBPS//@public@vhost@g@gutenberg@
has tests for the
"unique" behaviour?
- Martin Tobias Holmedahl Sandsmark
On July 13, 2016, 10:56 a.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > did you run the tests (especially the mainshelltest, which has tests for
> > the "unique" behaviour?
but fwiw, your description of the behaviour seems correct to me, but I think it
should
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
---
On July 13, 2016, 9:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> --
t; > It's not something specific about okular.
>
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?
>
> Aleix Pol Gonzalez wrote:
> Whichever QPT that is underwhelming you and pushed you to make this RR.
> Or
select a single
random filetype to view at the time. This tries to improve that, but I'm not
sure if that's something you/we want?
Diffs (updated)
-
shell/shell.cpp bca7206
Diff: https://git.reviewboard.kde.org/r/128435/diff/
Testing
---
Thanks,
Martin T
f a shipit soonish.
- Martin Tobias Holmedahl Sandsmark
On July 12, 2016, 10:37 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
t; > It's not something specific about okular.
>
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?
>
> Aleix Pol Gonzalez wrote:
> Whichever QPT that is underwhelming you and pushed you to make this RR.
> Or QFi
t; > It's not something specific about okular.
>
> Martin Tobias Holmedahl Sandsmark wrote:
> move which logic to which upstream? QFileDialog?
>
> Aleix Pol Gonzalez wrote:
> Whichever QPT that is underwhelming you and pushed you to make this RR.
> Or QFi
rated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> ---
>
> (Updated July 23, 2016, 11:24 a.m.)
>
>
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl
> Sandsmark.
>
>
> Repository: okular
>
>
> Description
> On July 24, 2016, 2:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4018
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4018>
> >
> > instead use something like:
> > if (url.s
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97956
---
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
plugin, no duplication
of "all supported files" or whatever. So unless there's any objections I'll
push it soonish.
- Martin Tobias Holmedahl Sandsmark
On July 17, 2016, 6:09 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> --
file open dialog just lets you select a single
random filetype to view at the time. This tries to improve that, but I'm not
sure if that's something you/we want?
Diffs
-
shell/shell.cpp bca7206
Diff: https://git.reviewboard.kde.org/r/128435/diff/
Testing
---
Thanks,
Mar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128673/#review98375
---
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
, so I guess we
might get this in soon.
- Martin Tobias Holmedahl Sandsmark
On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
, though.
- Martin Tobias Holmedahl Sandsmark
On Aug. 30, 2016, 3:57 p.m., Gleb Popov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
128821/#comment66561>
always use {}, even for oneliners.
ui/pageview.cpp (line 1510)
<https://git.reviewboard.kde.org/r/128821/#comment66560>
Why put this in a separate variable?
- Martin Tobias Holmedahl Sands
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > ui/pageview.cpp, line 1500
> > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1500>
> >
> > Don't put assignments in the if condition.
> >
block, but feel free to fix them
before pushing. :-)
ui/pageview.h (line 134)
<https://git.reviewboard.kde.org/r/128821/#comment66575>
nitpick; inconsistent spacing
- Martin Tobias Holmedahl Sandsmark
On Sept. 4, 2016, 3:16 p.m., Oliver Sander
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > ui/pageview.cpp, line 1505
> > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1505>
> >
> > potentially uninitialized, add some default value.
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128938/#review99511
---
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
idget
is used and I'd prefer not having a new application class just for this.
- Martin Tobias Holmedahl Sandsmark
On Sept. 7, 2016, 8:18 p.m., Oliver Sander wrote:
>
> ---
> This is an automatically generated e-mail. To re
Qt doesn't handle
the gestures from libinput or something.
ui/pageview.cpp (line 1496)
<https://git.reviewboard.kde.org/r/128821/#comment67036>
you need to call QAbstractScrollArea::event(), not QWidget::event(),
otherwise you get an infinite recursion when scrolling.
- Ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review99717
---
Ship it!
Ship It!
- Martin Tobias Holmedahl Sandsmark
> On Oct. 2, 2016, 12:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > I tried to test with pinching on my touchpad, but apparently Qt doesn't
> > handle the gestures from libinput or something.
>
> Oliver Sander wrote:
> Touchpad pinching does not wo
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote:
> > I honestly don't see the benefit
> >
> > You changed a delete by a reset, is there any benefit at all other than
> > making the code harder to read?
>
> Oliver Sander wrote:
> I see three benefits:
> a) I can see by looking at the
.
For reference, this code is almost verbatim from the explode tool in the
original plucker source. The font variable is used to track whether to start or
end a formatted string span (represented by tags in the explode tool).
- Martin Tobias Holmedahl Sandsmark
On Oct. 30, 2016, 2:29 p.m
> On Nov. 19, 2016, 12:50 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Which code are you working against? I fixed this in July.
> >
> > For reference, this code is almost verbatim from the explode tool in the
> > original plucker source. The font variable
/document.cpp fdddfaa6
generators/xps/generator_xps.cpp c15da173
ui/debug_ui.cpp be2b3c7d
Diff: https://git.reviewboard.kde.org/r/129832/diff/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
> On Jan. 7, 2017, 1:24 p.m., Luigi Toscano wrote:
> > Does it mean that you can't override the setting using kdebugsettings? If
> > it's the case, it's probably a no-go.
>
> Miklós Máté wrote:
> Oh, sorry I didn't realize how important this is:
>
> "/usr/local/lib/x86_64-linux-gnu/plu
/debug_ui.cpp be2b3c7d
Diff: https://git.reviewboard.kde.org/r/129832/diff/
Testing
---
Thanks,
Martin Tobias Holmedahl Sandsmark
en to test on unfortunately
ui/presentationwidget.cpp (line 538)
<https://git.reviewboard.kde.org/r/125847/#comment68336>
always use {}
- Martin Tobias Holmedahl Sandsmark
On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote:
>
>
42 matches
Mail list logo
