----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 -----------------------------------------------------------
Which code are you working against? I fixed this in July. For reference, this code is almost verbatim from the explode tool in the original plucker source. The font variable is used to track whether to start or end a formatted string span (represented by <FONT> tags in the explode tool). - Martin Tobias Holmedahl Sandsmark On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129288/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > If we assume that the code was correct, then the pointer dereference is > unnecessary. If we assume that the code was wrong, then it probably wanted to > do (*font)--. I assumed the former, but I can't test it. > > > Diffs > ----- > > generators/plucker/unpluck/qunpluck.cpp 8363dd3 > > Diff: https://git.reviewboard.kde.org/r/129288/diff/ > > > Testing > ------- > > > Thanks, > > Miklós Máté > >
