Re: Review Request 129288: Fix unused computation result warning in plucker

2016-12-14 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/ --- (Updated Dec. 14, 2016, 11:52 p.m.) Status -- This change has been d

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-20 Thread Miklós Máté
> On Nov. 19, 2016, 1:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable is used to track whether to > >

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-20 Thread Miklós Máté
> On Nov. 19, 2016, 1:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable is used to track whether to > >

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-19 Thread Martin Tobias Holmedahl Sandsmark
> On Nov. 19, 2016, 12:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable is used to track whether to > >

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-19 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 --- Which code are you working against? I fixed this in July. F

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100408 --- If we don't know what we're doing, let's actually leave the

Review Request 129288: Fix unused computation result warning in plucker

2016-10-30 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/ --- Review request for Okular. Repository: okular Description --- If w