Re: Review Request 130226: CHM Generator Lib Update

2017-11-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103842 --- generators/CMakeLists.txt Lines 45 (patched)

Re: Review Request 130226: CHM Generator Lib Update

2017-09-12 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/ --- (Updated Sept. 12, 2017, 9:07 p.m.) Status -- This change has been m

Re: Review Request 130226: CHM Generator Lib Update

2017-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103693 --- Ship it! I don't have many files to test not many knowled

Re: Review Request 130226: CHM Generator Lib Update

2017-08-26 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/ --- (Updated Aug. 26, 2017, 5:49 p.m.) Review request for Okular. Changes -

Re: Review Request 130226: CHM Generator Lib Update

2017-08-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103628 --- generators/chm/lib/ebook_chm.cpp (line 829)

Re: Review Request 130226: CHM Generator Lib Update

2017-08-19 Thread Gilbert Assaf
> On Aug. 16, 2017, 9:58 p.m., Albert Astals Cid wrote: > > What do they use instead of khtml? Some other html renderer? > > Gilbert Assaf wrote: > QtWebKit > > Albert Astals Cid wrote: > Do we want to use that? Or do maybe as a second step? I.e. this first and > then evaluate if we wa

Re: Review Request 130226: CHM Generator Lib Update

2017-08-17 Thread Albert Astals Cid
> On ago. 16, 2017, 9:58 p.m., Albert Astals Cid wrote: > > What do they use instead of khtml? Some other html renderer? > > Gilbert Assaf wrote: > QtWebKit Do we want to use that? Or do maybe as a second step? I.e. this first and then evaluate if we want to move to qtwekbit? Also what te

Re: Review Request 130226: CHM Generator Lib Update

2017-08-17 Thread Gilbert Assaf
> On Aug. 16, 2017, 9:58 nachm., Albert Astals Cid wrote: > > What do they use instead of khtml? Some other html renderer? QtWebKit - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

Re: Review Request 130226: CHM Generator Lib Update

2017-08-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103610 --- What do they use instead of khtml? Some other html renderer?