> On Aug. 16, 2017, 9:58 p.m., Albert Astals Cid wrote: > > What do they use instead of khtml? Some other html renderer? > > Gilbert Assaf wrote: > QtWebKit > > Albert Astals Cid wrote: > Do we want to use that? Or do maybe as a second step? I.e. this first and > then evaluate if we want to move to qtwekbit? > > Also what testing have you done?
There is one big problem with qtwebkit: it is no longer officially supported. Qt uses qtwebengine now, but you have to use a recent distro to get, because it seems very hard to package (see https://euroquis.nl/bobulate/?p=1681 and this https://marc.info/?l=kde-core-devel&m=142954900813235&w=2 ). I would suggest we stick with khtml for now. I tested this patch with all documents I have, but I would welcome everyone who would like to do some additional testing, since it is quiet a big change. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103610 ----------------------------------------------------------- On Aug. 16, 2017, 12:54 p.m., Gilbert Assaf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130226/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 12:54 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > This patch updates our copy of the chm lib from kchmviewer. The lib files > itself are an unmodified copy from kchmviewer 7.7, only our generator needed > some changes. In contrast to kchmviewer we still use khtml and therefor still > need msits. > > > Diffs > ----- > > cmake/modules/FindLibZip.cmake PRE-CREATION > generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 > generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da > generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f > generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 > generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 > generators/chm/lib/ebook.h PRE-CREATION > generators/chm/lib/ebook.cpp PRE-CREATION > generators/chm/lib/ebook_chm.h PRE-CREATION > generators/chm/lib/ebook_chm.cpp PRE-CREATION > generators/chm/lib/ebook_chm_encoding.h PRE-CREATION > generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION > generators/chm/lib/ebook_epub.h PRE-CREATION > generators/chm/lib/ebook_epub.cpp PRE-CREATION > generators/chm/lib/ebook_search.h PRE-CREATION > generators/chm/lib/ebook_search.cpp PRE-CREATION > generators/chm/lib/ebook_url.h PRE-CREATION > generators/chm/lib/helper_entitydecoder.h PRE-CREATION > generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION > generators/chm/lib/helper_search_index.h PRE-CREATION > generators/chm/lib/helper_search_index.cpp PRE-CREATION > generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION > generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION > generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION > generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION > generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION > generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION > generators/chm/lib/lchmurlhandler.h > 35133c41d764de551a350a240d8ee43d07f84716 > generators/chm/lib/lchmurlhandler.cpp > 9d98d87e147539ef30817b3c66a040aa750575ad > generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 > generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 > generators/chm/lib/libchmfile_search.cpp > 76532b18282913ff97c8509d8e384ec0b1f48dfb > generators/chm/lib/libchmfileimpl.h > f8d7cc11269a2688fd8b58a30d718ff911b051b3 > generators/chm/lib/libchmfileimpl.cpp > d10602028e958e7feded362b2ab58e32ca1d1ff0 > generators/chm/lib/libchmtextencoding.h > 5228b04c10718d407fc49df2e69d220d4efff67c > generators/chm/lib/libchmtextencoding.cpp > 0ed3f0710360c7bab113a35c7896e6bbd6664d20 > generators/chm/lib/libchmtocimage.h > c0d98b3ba27596a731fd0ab24386578f6c58fdf8 > generators/chm/lib/libchmtocimage.cpp > 2952e8604d8c01360eace2826bbf5dc428155ff1 > > Diff: https://git.reviewboard.kde.org/r/130226/diff/ > > > Testing > ------- > > > Thanks, > > Gilbert Assaf > >
