Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 18, 2013, 2:03 p.m.) Status -- This change has been mark

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review32738 --- This review has been submitted with commit 1fdb0a0a0621d8b8fa0

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 17, 2013, 12:07 a.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 17, 2013, 12:01 a.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 16, 2013, 11:15 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 16, 2013, 11:06 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
> On May 16, 2013, 10:31 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.cpp, line 255 > > > > > > Aren't we still leaking new TextDocumentSettingsWidget()? Yes, if the backend config dialog won't c

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review32675 --- core/textdocumentgenerator.cpp

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 16, 2013, 10:02 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 16, 2013, 8:36 p.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review32663 --- Looks pretty good, a few const missing but i can add them when

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-14 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 14, 2013, 8:06 p.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-14 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-14 Thread Albert Astals Cid
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-14 Thread Albert Astals Cid
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Fabio D'Urso
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class > > Azat Khuzhin wrote: > Could you explai

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 13, 2013, 11:30 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.h, line 217 > > > > > > This should ideally be a function of the private class Could you explain why you think so? - Azat

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.cpp, line 217 > > > > > > We are leaking the settings, no? > > > > Also i think it'd make more sense for the skeleton p

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review32466 --- core/textdocumentgenerator.h

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-13 Thread Albert Astals Cid
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-12 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 12, 2013, 10:02 p.m.) Review request for Okular, Albert Astal

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-11 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-11 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-11 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 11, 2013, 7:40 p.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-11 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentgenerator.cpp, line 217 > > > > > > We are leaking the settings, no? > > > > Also i think it'd make more sense for the skeleton p

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-11 Thread Azat Khuzhin
> On May 8, 2013, 6:02 p.m., Albert Astals Cid wrote: > > core/textdocumentsettings.h, line 29 > > > > > > We need to install this class so generators outside the okular repo can > > use it. This means you need to

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-07 Thread Azat Khuzhin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated May 8, 2013, 4:13 a.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-07 Thread Albert Astals Cid
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote: > > Azat you still interested in working on this? > > Azat Khuzhin wrote: > Yes, I will try to look at this weekend. > I don't have enough time for this at weekdays. > > Azat Khuzhin wrote: > Sorry for such a long delay, I have

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-01 Thread Azat Khuzhin
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote: > > Azat you still interested in working on this? > > Azat Khuzhin wrote: > Yes, I will try to look at this weekend. > I don't have enough time for this at weekdays. > > Azat Khuzhin wrote: > Sorry for such a long delay, I have

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-05-01 Thread Azat Khuzhin
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote: > > Azat you still interested in working on this? > > Azat Khuzhin wrote: > Yes, I will try to look at this weekend. > I don't have enough time for this at weekdays. Sorry for such a long delay, I have the time for that now. On it.

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-04-04 Thread Azat Khuzhin
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote: > > Azat you still interested in working on this? Yes, I will try to look at this weekend. I don't have enough time for this at weekdays. - Azat --- This is an automatically genera

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-04-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review30393 --- Azat you still interested in working on this? - Albert Astals

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-03-03 Thread Albert Astals Cid
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-03-01 Thread Eike Hein
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-28 Thread Azat Khuzhin
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-28 Thread Albert Astals Cid
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-24 Thread Azat Khuzhin
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated Feb. 23, 2013, 11:56 a.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-23 Thread Albert Astals Cid
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-23 Thread Azat Khuzhin
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-23 Thread Azat Khuzhin
> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backen

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review27753 --- conf/dlggeneralbase.ui

Re: [Okular-devel] Review Request 109021: Font selector for TextDocumentGenerator

2013-02-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/ --- (Updated Feb. 19, 2013, 9:41 p.m.) Review request for Okular and Albert As