Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated April 5, 2013, 10:39 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review30531 --- This review has been submitted with commit 78faf1e68f625787ea5

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated April 5, 2013, 12:29 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On April 3, 2013, 9:16 p.m., Albert Astals Cid wrote: > > I was about to commit and then i saw we still have the > > m_prevAnnotTextCursorPos and m_prevAnnotTextAnchorPos maps. Do we really > > need them? As far as I can see they only get used to fill the commands for > > the AnnotWindow, ca

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On April 3, 2013, 9:16 p.m., Albert Astals Cid wrote: > > I was about to commit and then i saw we still have the > > m_prevAnnotTextCursorPos and m_prevAnnotTextAnchorPos maps. Do we really > > need them? As far as I can see they only get used to fill the commands for > > the AnnotWindow, ca

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On April 3, 2013, 9:16 p.m., Albert Astals Cid wrote: > > I was about to commit and then i saw we still have the > > m_prevAnnotTextCursorPos and m_prevAnnotTextAnchorPos maps. Do we really > > need them? As far as I can see they only get used to fill the commands for > > the AnnotWindow, ca

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review30337 --- I was about to commit and then i saw we still have the m_prevAn

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 26, 2013, 10:54 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3239 > > > > > > wondering if we should assert here that > > d->m_prevPropsOfAnnotBeingModified is null/empty/wathever > > J

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 27, 2013, 12:10 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 26, 2013, 10:54 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3239 > > > > > > wondering if we should assert here that > > d->m_prevPropsOfAnnotBeingModified is null/empty/wathever > > J

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 26, 2013, 10:54 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3239 > > > > > > wondering if we should assert here that > > d->m_prevPropsOfAnnotBeingModified is null/empty/wathever Sure,

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review29929 --- core/document.cpp

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 14, 2013, 7:43 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3282 > > > > > > I am wondering why do we need this map for the prev contents, as far as > > i can see annotwindow does not mo

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 24, 2013, 12:40 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 14, 2013, 7:43 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3282 > > > > > > I am wondering why do we need this map for the prev contents, as far as > > i can see annotwindow does not mo

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 14, 2013, 7:43 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3282 > > > > > > I am wondering why do we need this map for the prev contents, as far as > > i can see annotwindow does not mo

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 14, 2013, 7:43 p.m., Albert Astals Cid wrote: > > Thanks for the feedback. I have a couple questions inline below > On March 14, 2013, 7:43 p.m., Albert Astals Cid wrote: > > ui/annotationpropertiesdialog.cpp, line 209 > >

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review29227 --- core/document.h

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 12, 2013, 1:26 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

> On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: > > Tried it looks pretty cool :) Some minor comments inline > > > > You will need to rebase your patch, there's a small conflict with a change > > i did in document.cp Thanks a lot for your feedback! These issues will be addressed in ve

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 12, 2013, 1:24 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review28765 --- Tried it looks pretty cool :) Some minor comments inline You w

Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated Feb. 2, 2013, 6:58 p.m.) Review request for Okular. Changes ---