-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/
-----------------------------------------------------------
(Updated March 27, 2013, 12:10 p.m.)
Review request for Okular.
Changes
-------
Error conditions are now checked in both
Document::modifyPageAnnotationProperties and
Document::prepareToModifyAnnotationProperties. Error message is printed with
kError and failure with a Q_ASSERT.
I also fixed the handling of latex fragments in annotWindow.
Description
-------
This patch adds undo/redo support to Okular's annotation manipulation commands.
Functionality:
The following actions can be undone and redone: creation and removal of
annotations, editing arbitrary annotation properties, relocating annotations
with Ctrl+drag, and editing the text contents of an annotation.
This patch does not include support for undoing and redoing editing actions on
forms.
This addresses bug 177501.
http://bugs.kde.org/show_bug.cgi?id=177501
Diffs (updated)
-----
core/annotations.h 72abdff
core/annotations.cpp 49ab5bd
core/annotations_p.h 221572d
core/document.h 6ff6536
core/document.cpp 5ab759e
core/document_p.h fb3aec6
core/page.cpp 1db2763
part.rc 39c1571
ui/annotationpropertiesdialog.cpp 4b02258
ui/annotwindow.h f7df9f6
ui/annotwindow.cpp c1bafb9
ui/guiutils.h 2ae4ab3
ui/guiutils.cpp 1d67d3a
ui/pageview.cpp b018dfe
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
-------
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents.
Thanks,
Jon Mease
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
