Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review20422 --- Ship it! Looks good, we can do the final tweaks in master :-)

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-15 Thread Marco Martin
> On Oct. 14, 2012, 6:32 p.m., Albert Astals Cid wrote: > > So are you happy enough with the feature set now? Anything else you want to > > work on before we do the final merge review? from my side, good to go - Marco --- This is an au

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-14 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review20324 --- So are you happy enough with the feature set now? Anything else

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 12, 2012, 12:54 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-05 Thread Albert Astals Cid
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-05 Thread Marco Martin
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-05 Thread Marco Martin
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-04 Thread Albert Astals Cid
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-04 Thread Marco Martin
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-04 Thread Marco Martin
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Albert Astals Cid
> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- Little summary since the other block is getting huge :D * Mes

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Albert Astals Cid
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > active/app/active-documentviewer.desktop, line 13 > > > > > > This is not correct, active-documentviewer will only support pdf if the > > poppler generator

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Marco Martin
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > You seem to be missing a Message.sh file > > Marco Martin wrote: > i added a couple of messages.sh and catalogs. > org.kde.active.documentviewer.pot for the app, both qml and c++ parts > org.kde.okular.pot for the qml compone

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 3, 2012, 10:17 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Albert Astals Cid
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > You seem to be missing a Message.sh file > > Marco Martin wrote: > i added a couple of messages.sh and catalogs. > org.kde.active.documentviewer.pot for the app, both qml and c++ parts > org.kde.okular.pot for the qml compone

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Albert Astals Cid
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > active/app/active-documentviewer.desktop, line 13 > > > > > > This is not correct, active-documentviewer will only support pdf if the > > poppler generator

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/ --- (Updated Oct. 2, 2012, 12:21 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Marco Martin
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > You seem to be missing a Message.sh file i added a couple of messages.sh and catalogs. org.kde.active.documentviewer.pot for the app, both qml and c++ parts org.kde.okular.pot for the qml components: maybe that should be together okular

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19712 --- You seem to be missing a Message.sh file active/CMakeLists.tx