D8863: Give warnings when the file is modified externally

This revision was automatically updated to reflect the committed changes. Closed by commit R223:559836c39270: Give warnings when the file is modified externally (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8863?vs=22627&id=22653#toc REPOSITORY R223 Okular CHANGE

D8863: Give warnings when the file is modified externally

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, looks good. You missed a single spot, but I guess you just wanted to test whether I check everything indeed ;) INLINE COMMENTS > rkflx wrote in part.cpp:1721 > Use title case. Ping

D8863: Give warnings when the file is modified externally

aacid added a comment. In https://phabricator.kde.org/D8863#169475, @ngraham wrote: > > This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk: > > Right, that's what I originally thought this was all about. If the user can't, then this whole in

D8863: Give warnings when the file is modified externally

aacid updated this revision to Diff 22627. aacid added a comment. And correct diff again :D REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8863?vs=22626&id=22627 BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTE

D8863: Give warnings when the file is modified externally

aacid updated this revision to Diff 22626. aacid added a comment. New text based in suggestions Please aprove ASAP since we're past the message freeze already, the translators have approved for the exception but every day that passes makes it worse for them REPOSITORY R223 Okular CHA

D8863: Give warnings when the file is modified externally

rkflx added a comment. Thanks for proofreading. In https://phabricator.kde.org/D8863#169475, @ngraham wrote: > write the working copy in Okular back to disk, overwriting what the other program did. There is no such thing. You'll see this when opening a multi-page document an

D8863: Give warnings when the file is modified externally

ngraham added a comment. > This is in stark contrast to Kate and LibreOffice, where you are allowed to save back to disk: Right, that's what I originally thought this was all about. If the user can't, then this whole interface is almost rubbing salt in the wound: they're informed that t

D8863: Give warnings when the file is modified externally

rkflx added a comment. Thanks for working on my "complaint" ;) In https://phabricator.kde.org/D8642#166462 I claimed that Save As worked correctly. After testing more, this turns out to be an edge case, i.e. it works (as in: annotation and document are saved) when overwriting with the or

D8863: Give warnings when the file is modified externally

aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > With "Keep Okular version", could we make it save over the file again using > the copy in memory--including the current state of the user's annotations and > forms? > > If not, then how about this? > > "There are

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1720 > I dont' like this wording, seems like it will let you not lose your changes > if you say "keep okular version". All you can do is "hopefully" still see > what is rendered, but doing much will probably also break rea

D8863: Give warnings when the file is modified externally

aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > How about this? > > "There are unsaved changes, but the file has been modified by another program > since it was opened.Which version would you like to keep?" > > [choices would then be "Keep Okular version" and "K

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > part.cpp:1720 > +res = KMessageBox::warningYesNo( widget(), > + i18n( "You have unsaved > modifications and the file has been modified externally since it was > opened.Unfortunately that mea

D8863: Give warnings when the file is modified externally

aacid added subscribers: ltoscano, rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: rkflx, ltoscano, #okular, ngraham, aacid

D8863: Give warnings when the file is modified externally

aacid updated this revision to Diff 22515. aacid added a comment. actual diff REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8863?vs=22514&id=22515 BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTED FILES part

D8863: Give warnings when the file is modified externally

aacid retitled this revision from "Workaround to build with older Qt" to "Give warnings when the file is modified externally". aacid edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: #okular, ngraham, aacid