Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-24 Thread Daniel Lichtenberger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/ --- (Updated March 23, 2016, 1:01 a.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-24 Thread Daniel Lichtenberger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/ --- (Updated March 22, 2016, 8:09 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-21 Thread Daniel Lichtenberger
> On March 21, 2016, 10:57 p.m., Albert Astals Cid wrote: > > Why did you develop this against the framework branch? You don't want this > > to end up in a release people will actually use? > > > > I was going to commit (with some spacing fixes) to Applications/16.04 but > > your patch doens't

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/#review93846 --- Why did you develop this against the framework branch? You do

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-19 Thread Daniel Lichtenberger
> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote: > > Could you please fix all the indentation to be like the one in the file? > > Daniel Lichtenberger wrote: > ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the > same method). Should I just convert them to spa

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-19 Thread Daniel Lichtenberger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/ --- (Updated March 16, 2016, 4:59 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-14 Thread Daniel Lichtenberger
> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote: > > Could you please fix all the indentation to be like the one in the file? ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the same method). Should I just convert them to spaces-only? - Daniel -

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/#review93500 --- Could you please fix all the indentation to be like the one i

[Okular-devel] Review Request 127351: Added ability to view embedded files

2016-03-12 Thread Daniel Lichtenberger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/ --- Review request for Okular. Bugs: 295567 http://bugs.kde.org/show_bug.