----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127351/#review93500 -----------------------------------------------------------
Could you please fix all the indentation to be like the one in the file? - Albert Astals Cid On March 12, 2016, 8:52 a.m., Daniel Lichtenberger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127351/ > ----------------------------------------------------------- > > (Updated March 12, 2016, 8:52 a.m.) > > > Review request for Okular. > > > Bugs: 295567 > http://bugs.kde.org/show_bug.cgi?id=295567 > > > Repository: okular > > > Description > ------- > > The selected embedded file(s) are extracted to QDir::tempPath() and the > default application associated with the file type is launched with KRun. > > Double-click on an embedded file also launches the view action. > > The temporary files are cleaned up automatically when the dialog is > closed. > > > Diffs > ----- > > ui/embeddedfilesdialog.h f3e2d038f4ffe2b64af15c94c7ec0cfb8a68834c > ui/embeddedfilesdialog.cpp b400e879b2849a931e069669c984a6b578ffd536 > ui/guiutils.h fffe04488b27d92d9a7bc623da653d0c1df87ae8 > ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a > > Diff: https://git.reviewboard.kde.org/r/127351/diff/ > > > Testing > ------- > > Tested with > > http://www.opf-labs.org/format-corpus/pdfCabinetOfHorrors/fileAttachment.pdf > > and the PDF file in > > http://www.sdbtransfer.de/app/download/10536876499/SuperSauber1_EDASXbau.zip?t=1453751464 > > > Thanks, > > Daniel Lichtenberger > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
