Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/#review89186 --- The part in pageview.cpp:1426 seems overly complicated: There

Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/ --- (Updated Sept. 15, 2015, 6:35 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 123427: Save view information per file

> On Aug. 10, 2015, 10:59 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 1402 > > > > > > You should use a string here and not an int, otherwise if in the future > > we add, move or remove items in th

Re: [Okular-devel] Review Request 123427: Save view information per file

> On ago. 10, 2015, 10:59 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 1402 > > > > > > You should use a string here and not an int, otherwise if in the future > > we add, move or remove items in th

Re: [Okular-devel] Review Request 123427: Save view information per file

> On ago. 10, 2015, 10:59 p.m., Albert Astals Cid wrote: > > How does this code play with the other code that remembers this stuff > > globally? Should that code be removed? > > Felix Mauch wrote: > yes, revision 2 reverts those changes, so revision 1 and 2 give the > complete change. Is t

Re: [Okular-devel] Review Request 123427: Save view information per file

> On Aug. 10, 2015, 10:59 nachm., Albert Astals Cid wrote: > > How does this code play with the other code that remembers this stuff > > globally? Should that code be removed? yes, revision 2 reverts those changes, so revision 1 and 2 give the complete change. Is this the wrong way to post it?

Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/#review83684 --- How does this code play with the other code that remembers thi

Re: [Okular-devel] Review Request 123427: Save view information per file

> On Juli 16, 2015, 11:09 nachm., Albert Astals Cid wrote: > > If you're going to save this, you probably want to save whether trim > > margins is enabled or not too. > > > > Also please do not introduce a new variable to store the viewmode, it makes > > it harder just to make sure it's synced

Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/ --- (Updated Aug. 6, 2015, 3:22 nachm.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/#review82591 --- If you're going to save this, you probably want to save whethe

Re: [Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/ --- (Updated April 27, 2015, 6 vorm.) Status -- This change has been mar

[Okular-devel] Review Request 123427: Save view information per file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/ --- Review request for Okular. Bugs: 341318 http://bugs.kde.org/show_bug.