> On Juli 16, 2015, 11:09 nachm., Albert Astals Cid wrote: > > If you're going to save this, you probably want to save whether trim > > margins is enabled or not too. > > > > Also please do not introduce a new variable to store the viewmode, it makes > > it harder just to make sure it's synced correctly with the actions, so why > > not just use the actions?
That's a very good point! I removed the variable and use the actions. I'm not really happy with checking each possible mode individually with d->aViewMode->menu()->actions().at(0)->isChecked(). However, I was not able to find something that returns the checked action. - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123427/#review82591 ----------------------------------------------------------- On Aug. 6, 2015, 3:22 nachm., Felix Mauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123427/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 3:22 nachm.) > > > Review request for Okular. > > > Bugs: 341318 > http://bugs.kde.org/show_bug.cgi?id=341318 > > > Repository: okular > > > Description > ------- > > Adds the functiionality to save the view mode (single page, facing...) and > continuous scrolling to the document information as it is already done with > the zoom information. > > > Diffs > ----- > > core/document.cpp 9d12488 > core/view.h a369d24 > ui/pageview.h e65b575 > ui/pageview.cpp b57e6ae > > Diff: https://git.reviewboard.kde.org/r/123427/diff/ > > > Testing > ------- > > I use a version with this patch applied since a couple of days. The intended > functionality seems to work reliably. > Maybe it would be nice to implement a "standard view" selection in the > options dialog as it's done for the zoom mode. > > > Thanks, > > Felix Mauch > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
