Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/ --- (Updated April 15, 2015, 7:56 p.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin
> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it > > Eugene Shalygin wrote: > I can't. My changes to test Kile are the following: > http://pastebin.com/HMv9Ziku. And GCC says: > > In file included from ../../

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Alex Richardson
> On April 14, 2015, 9:34 p.m., Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it > > Eugene Shalygin wrote: > I can't. My changes to test Kile are the following: > http://pastebin.com/HMv9Ziku. And GCC says: > > In file included from ../../src/kileview

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin
> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it > > Eugene Shalygin wrote: > I can't. My changes to test Kile are the following: > http://pastebin.com/HMv9Ziku. And GCC says: > > In file included from ../../

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Andreas Cord-Landwehr
> On April 14, 2015, 8:34 p.m., Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it > > Eugene Shalygin wrote: > I can't. My changes to test Kile are the following: > http://pastebin.com/HMv9Ziku. And GCC says: > > In file included from ../../src/kileview

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin
> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it > > Eugene Shalygin wrote: > I can't. My changes to test Kile are the following: > http://pastebin.com/HMv9Ziku. And GCC says: > > In file included from ../../

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin
> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote: > > With this I can build Kile, so I'd say Ship it I can't. My changes to test Kile are the following: http://pastebin.com/HMv9Ziku. And GCC says: In file included from ../../src/kileviewmanager.cpp:62:0: /usr/include/

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/#review78939 --- Ship it! With this I can build Kile, so I'd say Ship it - Al

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/ --- (Updated April 14, 2015, 7:48 nachm.) Review request for Okular, Albert A

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
> On April 10, 2015, 6:59 p.m., Eugene Shalygin wrote: > > I cann't say that it fixes the issue. Maybe it does, but I just can not > > make it working. > > > > I'm testing with Kile. Kile needs access to > > okular/interfaces/viewerinterface.h. However, this file contains `#include > > "okula

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-14 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/#review78932 --- I have now managed to get Kile to compile after applying the f

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-12 Thread Andreas Cord-Landwehr
> On April 10, 2015, 5:59 nachm., Eugene Shalygin wrote: > > I cann't say that it fixes the issue. Maybe it does, but I just can not > > make it working. > > > > I'm testing with Kile. Kile needs access to > > okular/interfaces/viewerinterface.h. However, this file contains `#include > > "oku

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-10 Thread Alex Richardson
> On April 10, 2015, 6:59 p.m., Eugene Shalygin wrote: > > I cann't say that it fixes the issue. Maybe it does, but I just can not > > make it working. > > > > I'm testing with Kile. Kile needs access to > > okular/interfaces/viewerinterface.h. However, this file contains `#include > > "okula

[Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-09 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/ --- Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene