[okular] [Bug 499249] Feature Request: Javascript: Add possiblity to copy values from list box

2025-01-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=499249 --- Comment #1 from Martin --- Created attachment 177767 --> https://bugs.kde.org/attachment.cgi?id=177767&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 499249] New: Feature Request: Javascript: Add possiblity to copy values from list box

2025-01-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=499249 Bug ID: 499249 Summary: Feature Request: Javascript: Add possiblity to copy values from list box Classification: Applications Product: okular Version: unspecified Platform: Ot

[okular] [Bug 491607] New: create indexes for pdfs that don't have any

2024-08-11 Thread Martin Tlustos
https://bugs.kde.org/show_bug.cgi?id=491607 Bug ID: 491607 Summary: create indexes for pdfs that don't have any Classification: Applications Product: okular Version: 24.05.2 Platform: Neon OS: Linux Status: REPO

[okular] [Bug 484547] Does not show drop down menu in formular

2024-03-27 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=484547 --- Comment #2 from Martin --- (In reply to Albert Astals Cid from comment #1) > Are you clicking on the arrow of the combo box? (right hand side in the > regular style) Ah now I see, the button with the arrow for point 5 is just not rendere

[okular] [Bug 484547] New: Does not show drop down menu in formular

2024-03-26 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=484547 Bug ID: 484547 Summary: Does not show drop down menu in formular Classification: Applications Product: okular Version: unspecified Platform: Other OS: Linux Status: RE

[okular] [Bug 478644] New: svg file association

2023-12-17 Thread Martin Zbořil
https://bugs.kde.org/show_bug.cgi?id=478644 Bug ID: 478644 Summary: svg file association Classification: Applications Product: okular Version: 21.12.3 Platform: Kubuntu OS: Linux Status: REPORTED Sever

[okular] [Bug 467324] Feature Request: Stamp annotations with fixed length/width ratio

2023-10-23 Thread Reuben Martin
https://bugs.kde.org/show_bug.cgi?id=467324 Reuben Martin changed: What|Removed |Added CC||reube...@gmail.com --- Comment #2 from Reuben

[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses

2023-09-07 Thread Martin Fernau
https://bugs.kde.org/show_bug.cgi?id=443404 --- Comment #18 from Martin Fernau --- (In reply to an.inbox from comment #17) > Hi all, the issue is related to the use of the Logitech dongle. When using > Bluetooth there is no problem. > > I use the same mouse (Logitech M2S) on two m

[okular] [Bug 468647] Character not printed correctly

2023-06-20 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=468647 --- Comment #5 from Martin --- I can confirm that the issue is fixed in development nightly (master) Version 23.07.70 Thank you very much! -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 468647] Character not printed correctly

2023-05-17 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=468647 Martin changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO

[okular] [Bug 468647] Character not printed correctly

2023-05-17 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=468647 --- Comment #3 from Martin --- No exactly. If you go on the homepage and dowmload the paper and open it with firefox, the symbols are shown correctly. Just when you open in okular it is not correct -- You are receiving this mail because: You are the

[okular] [Bug 468647] New: Character not printed correctly

2023-04-18 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=468647 Bug ID: 468647 Summary: Character not printed correctly Classification: Applications Product: okular Version: unspecified Platform: Microsoft Windows OS: Microsoft Windows

[okular] [Bug 428922] Back Button should go back in history

2023-04-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=428922 --- Comment #2 from Martin --- I confirm that the bug exists in Okular Version 21.12.3. Reproduction: Open PDF, click on hyperlink going to a page (eg to the References section), click on Alt+Left Expected: go to last visited paper Actual: go to n-1

[okular] [Bug 428922] Back Button should go back in history

2023-04-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=428922 Martin changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED

Re: Runtime error "you need to call Settings::instance before using"

2023-02-26 Thread Martin Schnitkemper
e Backend Configuration, looks now like this: https://invent.kde.org/martin-de/okular/uploads/82757d49a7fe7daa4ffa872f5f6ca4b6/Screenshot_20230225_144426.png It seems to work now: the configuration is saved and can be retrieved and set as default before printing, and the print dialog no longer crashes after

[okular] [Bug 463732] Print Dialog should remember PDF Options

2023-01-30 Thread Martin Schnitkemper
https://bugs.kde.org/show_bug.cgi?id=463732 Martin Schnitkemper changed: What|Removed |Added CC|martin.schnitkemper@nexgo.d | |e

Runtime error "you need to call Settings::instance before using"

2023-01-19 Thread Martin Schnitkemper
for a proper usage. Can anyone tell me what I missed, or guide me to a code example of the okular project where I can see how to get right access to the "Okular::Settings::"? Thank you in advance for your support, Martin

[okular] [Bug 375649] Possibility to change the theme of okular

2023-01-18 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=375649 Martin changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[okular] [Bug 463732] Print Dialog should remember PDF Options

2023-01-11 Thread Martin Schnitkemper
https://bugs.kde.org/show_bug.cgi?id=463732 --- Comment #6 from Martin Schnitkemper --- (In reply to Nate Graham from comment #4) > This would work for the scaling option, since it's added by Okular. But it > would not work for any other options that come from the basic dialog itself.

[okular] [Bug 463732] Print Dialog should remember PDF Options

2023-01-11 Thread Martin Schnitkemper
https://bugs.kde.org/show_bug.cgi?id=463732 --- Comment #3 from Martin Schnitkemper --- Sorry, it seems to be decided in the function "PDFOptionsPage" of "generators/poppler/generator_pdf.cpp": | m_scaleMode = new QComboBox; | m_scaleMode->insertItem(FitToPrintableArea,

[okular] [Bug 463732] Print Dialog should remember PDF Options

2023-01-11 Thread Martin Schnitkemper
https://bugs.kde.org/show_bug.cgi?id=463732 Martin Schnitkemper changed: What|Removed |Added CC||martin.schnitkemper@nexgo.d

[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses

2022-12-20 Thread Martin Fernau
https://bugs.kde.org/show_bug.cgi?id=443404 --- Comment #15 from Martin Fernau --- I've the same problem since switching to kubuntu 22.04 (coming from 20.04) My mouse is a logitech M720 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses

2022-12-20 Thread Martin Fernau
https://bugs.kde.org/show_bug.cgi?id=443404 Martin Fernau changed: What|Removed |Added CC||mar...@martin-fernau.de -- You are receiving

[okular] [Bug 443882] popup menu of highlighted text does not appear on right click in text selection mode

2022-08-23 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=443882 Martin changed: What|Removed |Added CC||martin.monper...@gnieh.org --- Comment #14 from

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

2022-06-08 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=367959 --- Comment #16 from Martin --- Comment on attachment 149550 --> https://bugs.kde.org/attachment.cgi?id=149550 Micro Character not shown correctly okular: Version 22.03.70 OS: Win10 https://res.cloudinary.com/openmicrolab/raw/upload/v1487645

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

2022-06-08 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=367959 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #15 from

[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers

2021-06-16 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=431687 --- Comment #11 from Martin --- It is also possible to reproduce using only Okular. When having a pdf (see Attachment "Original Not rotated") and rotating it and saving afterwards. When reopening the pdf it is still rotated. Now create a ne

[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers

2021-06-16 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=431687 --- Comment #10 from Martin --- Created attachment 139387 --> https://bugs.kde.org/attachment.cgi?id=139387&action=edit RotatedAndSaved -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers

2021-06-16 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=431687 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #9 from Martin

[okular] [Bug 332271] search scrolls to wrong position not showing highlighted text with Trim Margins enabled

2021-03-09 Thread Martin Koller
https://bugs.kde.org/show_bug.cgi?id=332271 --- Comment #4 from Martin Koller --- checking with https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&ved=2ahUKEwip0eCelaXvAhVSVhoKHaEHD-oQFjABegQIARAD&url=https%3A%2F%2Fcatonmat.net%2Fftp%2Frfbproto.pdf&

[okular] [Bug 426171] Text not recognized correctly

2020-09-03 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=426171 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #1 from Martin

[okular] [Bug 426171] New: Text not recognized correctly

2020-09-03 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=426171 Bug ID: 426171 Summary: Text not recognized correctly Product: okular Version: unspecified Platform: Other OS: Other Status: REPORTED Severity: normal

[okular] [Bug 425597] Annotation Toolbar not shown

2020-08-24 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=425597 Martin changed: What|Removed |Added Status|NEEDSINFO |RESOLVED --- Comment #5 from Martin --- Seems to fix

[okular] [Bug 425597] Annotation Toolbar not shown

2020-08-20 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=425597 --- Comment #2 from Martin --- No it is not. The problem is also that in the menu action for showing and hiding only the rectangle is visible, but not "Annotation Toolbar" (Next to the action to show and hide the main toolbar). In the flatp

[okular] [Bug 425598] New: Quick Annotations more accessible

2020-08-20 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=425598 Bug ID: 425598 Summary: Quick Annotations more accessible Product: okular Version: 1.11.0 Platform: Other OS: Linux Status: REPORTED Severity: normal P

[okular] [Bug 425597] New: Annotation Toolbar not shown

2020-08-20 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=425597 Bug ID: 425597 Summary: Annotation Toolbar not shown Product: okular Version: 1.11.0 Platform: Other OS: Linux Status: REPORTED Severity: normal Priori

[okular] [Bug 342003] Trim margins confuses ordering of zoom steps while zooming out

2020-07-01 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=342003 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org --- Comment #16

[Active] [Bug 308240] active-documentviewer crashes by using zoom gestures

2020-06-29 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[okular] [Bug 421469] Slow search

2020-05-13 Thread Martin Steigerwald
https://bugs.kde.org/show_bug.cgi?id=421469 Martin Steigerwald changed: What|Removed |Added CC||mar...@lichtvoll.de Ever confirmed|0

[okular] [Bug 421103] Feature request: change action when clicking and double clicking on drawing tool

2020-05-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=421103 --- Comment #2 from Martin --- Hi David, yes a dedicated button is also good. I'm using in the most time the persistent mode so enabling it is also good. Thanks This request can be closed. -- You are receiving this mail because: You ar

[okular] [Bug 421102] Feature request: Ability to move tool list freely around

2020-05-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=421102 --- Comment #2 from Martin --- Hi David, yes at least setting the toolbar floating is already nice. The other is not that important, because it will not be zoomed that often. So moving manually is okay :) I think you can close this request. Thank you

[okular] [Bug 421103] New: Feature request: change action when clicking and double clicking on drawing tool

2020-05-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=421103 Bug ID: 421103 Summary: Feature request: change action when clicking and double clicking on drawing tool Product: okular Version: 1.9.2 Platform: Other OS: MS Wind

[okular] [Bug 421102] New: Feature request: Ability to move tool list freely around

2020-05-06 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=421102 Bug ID: 421102 Summary: Feature request: Ability to move tool list freely around Product: okular Version: 1.9.2 Platform: Other OS: MS Windows Status:

[okular] [Bug 401944] Copy listings created in Latex not copied properly

2020-04-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=401944 Martin changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[okular] [Bug 401944] Copy listings created in Latex not copied properly

2020-04-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=401944 --- Comment #4 from Martin --- I tried with languate=C++ and it is the same. I think you are right. When I mark the text, I am able to select spaces between characters -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 420699] New: Feature Request: Split View

2020-04-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=420699 Bug ID: 420699 Summary: Feature Request: Split View Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Pr

[okular] [Bug 401944] Copy listings created in Latex not copied properly

2020-04-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=401944 --- Comment #2 from Martin --- Did you write a bugreport for poppler or should I do that? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 419084] New: Add option to print several or all opened pdf files

2020-03-21 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=419084 Bug ID: 419084 Summary: Add option to print several or all opened pdf files Product: okular Version: 1.9.3 Platform: Other OS: Linux Status: REPORTED Severity: w

[okular] [Bug 396087] Okular stops rendering some pages, locks up at 25% CPU usage and won't die

2020-01-30 Thread Martin Bednar
https://bugs.kde.org/show_bug.cgi?id=396087 --- Comment #16 from Martin Bednar --- Patched okular on my Gentoo. Seems fixed. Thank you! You made the day of at least 2 people :) -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 396087] Okular stops rendering some pages, locks up at 25% CPU usage and won't die

2020-01-29 Thread Martin Bednar
https://bugs.kde.org/show_bug.cgi?id=396087 Martin Bednar changed: What|Removed |Added CC||martin+...@serafean.cz --- Comment #14 from

[okular] [Bug 411743] when review/comment tool is selected, keep it selected

2020-01-14 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=411743 --- Comment #2 from Martin --- I confirm that double-clicking works on my box! Thanks a lot Oliver. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 411743] New: when review/comment tool is selected, keep it selected

2019-09-09 Thread Martin
comment tool leave comment leave comment leave comment Thanks! --Martin -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-16 Thread Martin Steigerwald
https://bugs.kde.org/show_bug.cgi?id=402015 Martin Steigerwald changed: What|Removed |Added Resolution|WORKSFORME |FIXED --- Comment #4 from Martin

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-11 Thread Martin Steigerwald
https://bugs.kde.org/show_bug.cgi?id=402015 Martin Steigerwald changed: What|Removed |Added CC||mar...@lichtvoll.de

[okular] [Bug 408056] Activating edit tool automatically

2019-05-29 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=408056 --- Comment #2 from Martin --- Thank you Oliver! Good to know it exist :) -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408056] New: Activating edit tool automatically

2019-05-29 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=408056 Bug ID: 408056 Summary: Activating edit tool automatically Product: okular Version: 1.5.3 Platform: Other OS: Linux Status: REPORTED Severity: wishlist

[okular] [Bug 407583] New: Save as does anymore work, if the file was edited external

2019-05-16 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=407583 Bug ID: 407583 Summary: Save as does anymore work, if the file was edited external Product: okular Version: 1.7.1 Platform: Archlinux Packages OS: Linux

[okular] [Bug 402307] New: crash when pasting clipboard into form field

2018-12-18 Thread Martin Koller
https://bugs.kde.org/show_bug.cgi?id=402307 Bug ID: 402307 Summary: crash when pasting clipboard into form field Product: okular Version: unspecified Platform: openSUSE RPMs OS: Linux Status: REPORTED Keyw

[okular] [Bug 401944] New: Copy listings created in Latex not copied properly

2018-12-10 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=401944 Bug ID: 401944 Summary: Copy listings created in Latex not copied properly Product: okular Version: 1.5.3 Platform: Other OS: Linux Status: REPORTED Severity: no

[okular] [Bug 357430] Okular crashed when activating “fit width”

2018-11-03 Thread Martin Ueding
https://bugs.kde.org/show_bug.cgi?id=357430 Martin Ueding changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[okular] [Bug 398202] provide navigation for annotations

2018-09-04 Thread Martin Corley
https://bugs.kde.org/show_bug.cgi?id=398202 --- Comment #4 from Martin Corley --- Man, I'm being dense. Many thanks -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 398202] provide navigation for annotations

2018-09-04 Thread Martin Corley
https://bugs.kde.org/show_bug.cgi?id=398202 --- Comment #2 from Martin Corley --- Thanks for the response. My apologies: Have used okular for years and somehow missed that(!). So then my only wish would be that this view was much flatter, to reduce the number of clicks to get to a page with an

[okular] [Bug 398202] New: provide navigation for annotations

2018-09-03 Thread Martin Corley
https://bugs.kde.org/show_bug.cgi?id=398202 Bug ID: 398202 Summary: provide navigation for annotations Product: okular Version: 1.5.0 Platform: unspecified OS: Linux Status: UNCONFIRMED Severity: wishlist

[okular] [Bug 397273] New: Not able to set breakpoints in other file than main.cpp

2018-08-08 Thread Martin
bugger stops. In the debugging window is the following Message: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-martin' qt.qpa.screen: QXcbConnection: Could not connect to display Could not connect to any X display. *** Normal beendet *** While debugging the breakp

D12884: Remove the internal file navigation from the global drawer

2018-05-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid

D12770: Android: Make it possible to associate with files

2018-05-11 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. Restricted Application added a subscriber: okular-devel. REPOSITORY R223 Okular BRANCH filesAndroid REVISION DETAIL https://phabricator.kde.org/D12770 To: apol, #okular, aacid, mart Cc: okular-devel, ngraham, aa

D12299: Android: include metadata for okular kirigami

2018-04-18 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for the icon, maybe a png version of https://cgit.kde.org/breeze-icons.git/tree/icons/apps/48/okular.svg which is the breeze icon REPOSITORY R223 Okular BRANCH okularkirigamiandroid REVI

D12176: Turn okularkirigami into an executable

2018-04-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12176 To: apol, #kirigami, #okular, mart Cc: plasma-devel, michaelweghorn, ngraham, apol, aacid, davidedmundson, mart, hein

[okular] [Bug 381405] New: Link to different document does not launch a new instance of Okular, but replaces current open document

2017-06-19 Thread Martin Drozdik
https://bugs.kde.org/show_bug.cgi?id=381405 Bug ID: 381405 Summary: Link to different document does not launch a new instance of Okular, but replaces current open document Product: okular Version: 0.24.0 Platform: Ubuntu Pa

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-17 Thread Martin Tobias Holmedahl Sandsmark
en to test on unfortunately ui/presentationwidget.cpp (line 538) <https://git.reviewboard.kde.org/r/125847/#comment68336> always use {} - Martin Tobias Holmedahl Sandsmark On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote: > >

[okular] [Bug 375649] New: Possibility to change the theme of okular

2017-01-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=375649 Bug ID: 375649 Summary: Possibility to change the theme of okular Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: no

[okular] [Bug 375648] New: Moving comments and resize inline notes

2017-01-28 Thread Martin
https://bugs.kde.org/show_bug.cgi?id=375648 Bug ID: 375648 Summary: Moving comments and resize inline notes Product: okular Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED S

Re: Review Request 129832: Only show warning messages by default

2017-01-16 Thread Martin Tobias Holmedahl Sandsmark
marked as submitted. Review request for Okular and Miklós Máté. Changes --- Submitted with commit 7f3eebd9f3bc1f7fec6b33549dcf86b1fdd3c2c3 by Martin T. H. Sandsmark to branch master. Repository: okular Description --- With this debug output has to be explicitly enabled by the user

Re: Review Request 129785: Stop debug spam in release builds

2017-01-15 Thread Martin Tobias Holmedahl Sandsmark
KDebugSettings is part of KDE Applications. Is it installed in the same > environment where Okular is installed? If I compile both in my kdesrc-build > environment, kdebugsettings has Okular categories (same for KHelpCenter). If >

Review Request 129832: Only show warning messages by default

2017-01-14 Thread Martin Tobias Holmedahl Sandsmark
/document.cpp fdddfaa6 generators/xps/generator_xps.cpp c15da173 ui/debug_ui.cpp be2b3c7d Diff: https://git.reviewboard.kde.org/r/129832/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-19 Thread Martin Tobias Holmedahl Sandsmark
> On Nov. 19, 2016, 12:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable

Re: Review Request 129288: Fix unused computation result warning in plucker

2016-11-19 Thread Martin Tobias Holmedahl Sandsmark
. For reference, this code is almost verbatim from the explode tool in the original plucker source. The font variable is used to track whether to start or end a formatted string span (represented by tags in the explode tool). - Martin Tobias Holmedahl Sandsmark On Oct. 30, 2016, 2:29 p.m

[okular] [Bug 372581] New: font too big for numbers in printed forms

2016-11-17 Thread Martin Senftleben
https://bugs.kde.org/show_bug.cgi?id=372581 Bug ID: 372581 Summary: font too big for numbers in printed forms Product: okular Version: 0.26.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 368229] [Frameworks] 'change light & dark colors' broken

2016-10-29 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=368229 Martin Sandsmark changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-15 Thread Martin Sandsmark via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781 Martin Sandsmark changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-07 Thread Martin Tobias Holmedahl Sandsmark
tyle (e. g. snake_case). That small rant aside, I don't mind if it is merged if anyone else wants it in (but I'm not going to give it a shipit myself). I know I Qt is moving towards using and recommending using more of the standard library instead of Qt's own similar things, so I'

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark
> On Oct. 2, 2016, 12:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > I tried to test with pinching on my touchpad, but apparently Qt doesn't > > handle the gestures from libinput or something. > > Oliver Sander wrote: > Touchpad pinching does not wo

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99717 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark
Qt doesn't handle the gestures from libinput or something. ui/pageview.cpp (line 1496) <https://git.reviewboard.kde.org/r/128821/#comment67036> you need to call QAbstractScrollArea::event(), not QWidget::event(), otherwise you get an infinite recursion when scrolling. - Ma

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-02 Thread Martin Tobias Holmedahl Sandsmark
idget is used and I'd prefer not having a new application class just for this. - Martin Tobias Holmedahl Sandsmark On Sept. 7, 2016, 8:18 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 128938: Rename method slotAutoScoll to slotAutoScroll

2016-09-25 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128938/#review99511 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1505> > > > > potentially uninitialized, add some default value. >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
block, but feel free to fix them before pushing. :-) ui/pageview.h (line 134) <https://git.reviewboard.kde.org/r/128821/#comment66575> nitpick; inconsistent spacing - Martin Tobias Holmedahl Sandsmark On Sept. 4, 2016, 3:16 p.m., Oliver Sander

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1500 > > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1500> > > > > Don't put assignments in the if condition. > >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
128821/#comment66561> always use {}, even for oneliners. ui/pageview.cpp (line 1510) <https://git.reviewboard.kde.org/r/128821/#comment66560> Why put this in a separate variable? - Martin Tobias Holmedahl Sands

Re: Review Request 128805: Fix compile with MSVC

2016-08-30 Thread Martin Tobias Holmedahl Sandsmark
, though. - Martin Tobias Holmedahl Sandsmark On Aug. 30, 2016, 3:57 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2016-08-13 Thread Martin Tobias Holmedahl Sandsmark
, so I guess we might get this in soon. - Martin Tobias Holmedahl Sandsmark On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128673: Remove a spurious trailing semicolon

2016-08-13 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128673/#review98375 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

[okular] [Bug 357579] Okular-15.12.0: page numbers text area not sized correctly when refreshing a document

2016-08-13 Thread Martin Sandsmark via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357579 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org Status

[okular] [Bug 363435] [frameworks] missing NoDisplay=true in org.kde.mobile.okular.desktop file

2016-08-13 Thread Martin Sandsmark via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363435 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org Resolution

[okular] [Bug 356127] "Save as" dialog for "Save copy as": path editing widget and list widget out of sync

2016-08-13 Thread Martin Sandsmark via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356127 Martin Sandsmark changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

Re: Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-08-13 Thread Martin Tobias Holmedahl Sandsmark
marked as submitted. Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez. Changes --- Submitted with commit 8f86818b5cf4bffb38ce9b3f725b4c38f20df598 by Martin T. H. Sandsmark to branch frameworks. Repository: okular Description --- Without the Plasma QPA now the

Re: Using TabletEvent hiRes positions

2016-08-07 Thread Martin Sandsmark
nderstand it, the hiRes position was used for a reason, see Since Qt5 hiResGlobalPos() and globalPosF() return the same value, if you look at the code. It is also noted in the documentation and hiResGlobalPos() is marked as deprecated with a QT_DEPRECATED macro in the header. -- Martin Sandsmark

Re: Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

2016-08-07 Thread Martin Tobias Holmedahl Sandsmark
plugin, no duplication of "all supported files" or whatever. So unless there's any objections I'll push it soonish. - Martin Tobias Holmedahl Sandsmark On July 17, 2016, 6:09 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --

Re: [Okular-devel] Review Request 128507: Port: Open relative path again

2016-07-31 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97956 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

  1   2   3   >