ent. The behavior on the DVI document is unchanged. I find the
behavior on the PDF document to be more natural.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
-only form
fields.
Diffs
-
ui/formwidgets.cpp 023a25f
Diff: https://git.reviewboard.kde.org/r/118171/diff/
Testing
---
Okular no longer crashes when selecting text from the read only text field in
the PDF supplied with the bug report
Thanks,
Jon Mease
://git.reviewboard.kde.org/r/118171/diff/
Testing
---
Okular no longer crashes when selecting text from the read only text field in
the PDF supplied with the bug report
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org
https://bugs.kde.org/show_bug.cgi?id=334611
--- Comment #3 from Jon Mease ---
Sure, I'll try to take a look by this weekend.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kd
ent and on
a DVI document. The behavior on the DVI document is unchanged. I find the
behavior on the PDF document to be more natural.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
/utils_p.h df82fe1
Diff: https://git.reviewboard.kde.org/r/114060/diff/
Testing
---
Manual testing of the viewport behavior for find and undo/redo actions on
several documents. I also tested that the desired behavior is maintained when
documents are rotated.
Thanks,
Jon Mease
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote:
> > Rendering differences (that I judged ugly) were the reason why I chose to
> > go the dashed outline route.
>
> Jon Mease wrote:
> Yeah, that makes sense. How do you feel about my idea above of only u
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114060/#review44637
---
On Nov. 28, 2013, 12:47 a.m., Jon Mease wrote:
>
> -
d8448
core/utils_p.h df82fe1
Diff: http://git.reviewboard.kde.org/r/114060/diff/
Testing
---
Manual testing of the viewport behavior for find and undo/redo actions on
several documents. I also tested that the desired behavior is maintained when
documents are rotated.
Thanks,
Jon
> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote:
> > Rendering differences (that I judged ugly) were the reason why I chose to
> > go the dashed outline route.
>
> Jon Mease wrote:
> Yeah, that makes sense. How do you feel about my idea above of only u
-
On Nov. 27, 2013, 3:22 p.m., Jon Mease wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114153/
>
lly in
Okular as in Poppler.
- Jon
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114153/#review44611
-------
On Nov.
ment to be more natural.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Greetings,
After some time away I'm ready to work a bit more on enhancing
Okular's annotation support.
I am interested in working towards adding an "Annotation Selection
Tool" that would live under the "Tools" menu. I would like this tool to
provide functionality that is similar to the
testing :-)
File Attachments
Form Samples PDF
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
---
Manual testing of the viewport behavior for find and undo/redo actions on
several documents. I also tested that the desired behavior is maintained when
documents are rotated.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel
testing of the viewport behavior for find and undo/redo actions on
several documents. I also tested that the desired behavior is maintained when
documents are rotated.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https
PDF
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
t:
http://git.reviewboard.kde.org/r/110589/#review33700
-------
On June 3, 2013, 8:47 p.m., Jon Mease wrote:
>
> ---
> This is an automatically generated e-mail. To repl
themselves) is it
> > possible not to pass the old values to editFormList and editFormCombo too?
>
> Jon Mease wrote:
> This is the approach I originally attempted. However, I couldn't figure
> out how to reliably get the current text out of a FormFieldChoice object
>
/git.reviewboard.kde.org/media/uploaded/files/2013/05/22/stripped-doc.pdf
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
change anything along these lines after committing). Thanks!
- Jon
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110589/#review33561
-------
iles/2013/05/22/stripped-doc.pdf
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Greetings,
Wanted to let you all know that I'm working on adding undo support to
form editing actions in Okular. I already have undo support added for
TextAreaEdit and FormLineEdit and I believe I'm close to having ListEdit
working as well.
I ran into an issue with CheckBoxEdit and RadioButt
oard.kde.org/r/110391/#review32452
---
On May 13, 2013, 11:06 p.m., Jon Mease wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.re
g/r/110391/diff/
Testing
---
Tested creating inline note annotations and the bug no longer occurs.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=319442
--- Comment #4 from Jon Mease ---
Thanks for your thoughts Fabio.
Proposed fix at https://git.reviewboard.kde.org/r/110391/
I removed the inplaceText and window text attributes (along with getters and
setters) and replaced all usages with (get/set
ns and the bug no longer occurs.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
pp 2732441
generators/djvu/generator_djvu.cpp bc83ed7
generators/poppler/annots.cpp b7fb9f7
ui/pagepainter.cpp 950be03
ui/pageviewannotator.cpp 4615d1c
Diff: http://git.reviewboard.kde.org/r/110391/diff/
Testing
---
Tested creating inline note annotations and the bug no longer occurs.
Th
https://bugs.kde.org/show_bug.cgi?id=319442
--- Comment #1 from Jon Mease ---
Fabio, what do you think of the proposal above?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://bugs.kde.org/show_bug.cgi?id=319442
Jon Mease changed:
What|Removed |Added
CC||fabiodu...@hotmail.it
https://bugs.kde.org/show_bug.cgi?id=319442
Bug ID: 319442
Summary: Initial contents of Inline Note annotation discarded
Classification: Unclassified
Product: okular
Version: 0.16.60
Platform: Compiled Sources
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=318828
--- Comment #5 from Jon Mease ---
Proposed fix and unit test submitted for review
https://git.reviewboard.kde.org/r/110229/
--
You are receiving this mail because:
You are the assignee for the bug
ModifyAnnotationPropertiesTest::testModifyAnnotationPropertiesWithRotation_Bug318828
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=318828
--- Comment #4 from Jon Mease ---
Sure thing. May be a few days but I'll take a look soon.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
O
h PRE-CREATION
tests/testingutils.cpp PRE-CREATION
tests/translateannotationtest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109989/diff/
Testing
---
This is testing :-)
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kd
Thanks Albert,
I think I just missed a couple steps from
http://techbase.kde.org/Getting_Started/Build/Environment#Environment_Configuration
I set things up from scratch again and everything is working.
No excuses left, time to start on some unit tests :-)
-Jon
>> I am able to cmake, and make, a
Thanks Albert (and Fabio) for all of your help along the way on this. I
appreciate it.
I do plan to tackle both a) and b) below. Not sure yet which order.
I could use a little help getting started with the a). I'm having trouble
figuring out how to run okular's existing unit tests.
When I run (
ified annotation actions using
.dvi and .pdf documents.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
> > the AnnotWindow, can't we cache "old" those values to feed the command in
> > AnnotWindow itself?
>
> Jon Mease wrote:
> Do you mean have the annotWindow keep track of its own previous cursor
> and anchor positions and then pass them in as arguments
isit:
http://git.reviewboard.kde.org/r/107442/#review30337
-----------
On March 27, 2013, 12:10 p.m., Jon Mease wrote:
>
> ---
> This is an automatically generated
fAnnotBeingModified is null/empty/wathever
>
> Jon Mease wrote:
> Sure, that makes sense. Is a C++ assert statement sufficient? Or would
> you prefer another failure mechanism?
>
> Albert Astals Cid wrote:
> Q_ASSERT (that will only assert in debug b
w.cpp b018dfe
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kd
.reviewboard.kde.org/r/107442/#review29929
-------
On March 24, 2013, 12:40 a.m., Jon Mease wrote:
>
> ---
> This is an automatically generated e-mail. To repl
ful under
different circumstances.
- Jon Mease
On March 21, 2013, 1:26 a.m., Peter Grasch wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://
> On March 22, 2013, 8:19 p.m., Albert Astals Cid wrote:
> > So yeah, besides what Fabio comments on it may well be a bit slow (no way
> > to speed it up unless you change poppler to do two pass rendering that
> > might even be possible) code looks ok *but* it will stop working when the
> > un
gt; > i can see annotwindow does not modify the annotation anymore, so the
> > annotation * you get here should have the old values still no?
>
> Jon Mease wrote:
> Yes, we could assume that the old contents are still in the annotation
> but this makes me a little nervous
f9f6
ui/annotwindow.cpp c1bafb9
ui/guiutils.h 2ae4ab3
ui/guiutils.cpp 1d67d3a
ui/pageview.cpp b018dfe
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents.
Thanks,
; <http://git.reviewboard.kde.org/r/107442/diff/6/?file=119430#file119430line38>
> >
> > We don't seem to use it anymore, or maybe we didn't already, but can
> > you kill the annotation() method?
Will do
- Jon
---------
f9f6
ui/annotwindow.cpp c1bafb9
ui/pageview.cpp b018dfe
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing (updated)
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents.
Thanks,
re what is the file style)
Also did some general parenthesis spacing cleanup of this section
- Jon
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review28765
-
.pdf files.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Greetings,
For the past several months I've been (slowly) working on adding
undo/redo support to Okular. I believe I have everything working to
undo/redo all actions related to annotations (See
https://git.reviewboard.kde.org/r/107442/).
My first question is whether this functionality is suf
ff
core/annotations.cpp 49ab5bd
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents. The only known issue is the one described above when
using .pdf files.
Thanks,
nly known issue is the one described above when
using .pdf files.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
rivate::loadDocumentInfo, or, even better, bypass the undo
> > stack while loading saved annotations?
Good point, in version 3 we're bypassing the undo stack when loading saved
annotations.
- Jon
---
Thi
df documents. The only known issue is the one described above when
using .pdf files.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
On Dec. 27, 2012, 3:22 p.m., Jon Mease wrote:
> > Sorry for the long delay, I've started to have a look at this new version.
> > Apart from the minor issues I've noted, most code looks good to me.
> >
> > I'm not fully convinced by AnnotWindow changes, I
git.reviewboard.kde.org/r/107442/diff/
Testing
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents. The only known issue is the one described above when
using .pdf files.
Thanks,
Jon Mease
___
ve?
- The reason I clear the undo stack in page.cpp is so that when opening a
document with existing saved annotations, it's not possible to undo the act of
adding those saved annotations to the document. Does that make sense?
Thanks also for the overview of how PDF a
Testing
---
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents. The only known issue is the one described above when
using .pdf files.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-dev
Thanks for the feedback Albert.
I think I will proceed with the plan of utilizing the XML code to
store/load annotation state information. And I'll plan on working to get
this in for 4.11. Please forgive my ignorance of the development process,
but when would be a good time to submit a review req
Greetings,
So I've spent a good bit of time studying the code, planning, and
prototyping ideas for the undo framework and I wanted to lay them out
here for general discussion.
Location of the QUndoStack: My current thinking is that the undo
stack should be a member of DocumentPrivate. Methods o
und like what you're thinking?
- Jon
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106923/#review20514
---
On Oct. 17, 2012
On Sun, Oct 14, 2012 at 12:16 PM, Fabio D'Urso wrote:
> On Saturday, October 13, 2012 11:43:38 PM Jon Mease wrote:
>> Hello all,
> Hi,
>
>> My next goal for enhancing Okular's annotation framework is to
>> add undo / redo support when creating/editing/deleting a
an explicit "delete" call.
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
of PageViewPrivate class
- Jon
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106816/#review20318
---
On Oct. 15,
Testing
---
* The creation of annotations using the wacom pen (smooth freehand annotations)
* The creation of annotations using the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen
(pen behaves just like the mouse).
Thanks,
Hello all,
My next goal for enhancing Okular's annotation framework is to
add undo / redo support when creating/editing/deleting annotations.
Looking back at the list archives it seems like this is something that
has been asked for and mentioned in bug reports for several years now.
Before st
g the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen
(pen behaves just like the mouse).
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
g the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen
(pen behaves just like the mouse).
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
g the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen
(pen behaves just like the mouse).
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
on of the annotations menu using both the mouse and the wacom pen
(pen behaves just like the mouse).
Thanks,
Jon Mease
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
74 matches
Mail list logo
