[okular] [Bug 408743] Typewriter tool not showing in okular annotations.

2019-07-21 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=408743 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINF

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right c

[okular] [Bug 409932] Allow to open a link using text search

2019-07-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=409932 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 CC|

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread Nathaniel Graham
ngraham added a reviewer: ndavis. ngraham added a comment. The 16px version is used in menus. The 22px version is used in toolbar buttons. 24px is unnecessary; it's only used by some 3rd-party apps I think. The ones that are already in there at that size are legacy and maybe we should just d

D22064: General improvements to stamp annotation

2019-07-21 Thread Nathaniel Graham
ngraham added a comment. If the feature is considered fundamentally broken, then just hiding it behind a bad UI isn't really enough because people will discover it anyway (I did). It either should be totally removed so we don't torture users until Poppler can handle it properly, or it should

D21266: Improve documentation of area classes

2019-07-21 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21266 To: davidhurka, #okular, aacid Cc: aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

2019-07-21 Thread David Hurka
davidhurka added a subscriber: Okular. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

[okular] [Bug 410071] Review tools typewriter box incorrect width

2019-07-21 Thread perispomenon
https://bugs.kde.org/show_bug.cgi?id=410071 --- Comment #1 from perispomenon --- And the font is Liberation Sans 10 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 410071] Review tools typewriter box incorrect width

2019-07-21 Thread perispomenon
https://bugs.kde.org/show_bug.cgi?id=410071 perispomenon changed: What|Removed |Added Summary|Review tools typewriter |Review tools typewriter box |

[okular] [Bug 410071] New: Review tools typewriter

2019-07-21 Thread perispomenon
https://bugs.kde.org/show_bug.cgi?id=410071 Bug ID: 410071 Summary: Review tools typewriter Product: okular Version: 1.7.3 Platform: Manjaro OS: Linux Status: REPORTED Severity: normal Priority:

D22064: General improvements to stamp annotation

2019-07-21 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > annotationwidgets.cpp:53 > +toplay->addWidget( m_comboItems ); > +m_stampPushButton = new QPushButton(QIcon::fromTheme( "document-open" ), > "", this ); > +m_stampPushButton->setVisible( false ); maybe add a tooltip to this button, just

D21271: Improve documentation of TextEntity stuff

2019-07-21 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21271 To: davidhurka, #okular, aacid Cc: aacid, yurchor, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen

D22064: General improvements to stamp annotation

2019-07-21 Thread Albert Astals Cid
aacid added a comment. Small code improvements that can be ignored if you want. The main concern i have is that we're improving a broken feature, stamps are not saved correctly into the pdf files (because of poppler) so I'm a bit unconvinced of making it easier to select random files sin