pino added inline comments. INLINE COMMENTS
> annotationwidgets.cpp:53 > + toplay->addWidget( m_comboItems ); > + m_stampPushButton = new QPushButton(QIcon::fromTheme( "document-open" ), > "", this ); > + m_stampPushButton->setVisible( false ); maybe add a tooltip to this button, just to hint users what's for > annotationwidgets.cpp:166 > + if( pixmap.isNull() ) { > + KMessageBox::sorry( this, i18n( "Could not load the file %1", > customStampFile ), "Invalid file" ); > + } else { The dialog title must be i18n'ed; while you are there, please use the `@title:window` semantic context with i18nc() REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen