D10859: Improve layout of annotation configuraton dialogs

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. In D10859#472322 , @simgunz wrote: > I am also in favor of the white space. Lines or group boxes seem to me too heavy for this type of configuration (and it is what I wanted to remove in the first place). Any idea on ho

[okular] [Bug 407338] Okular segfaults when opening a file digitally signed with portablesigner and Acrobat Reader

2019-05-30 Thread Juan Ases García
https://bugs.kde.org/show_bug.cgi?id=407338 Juan Ases García changed: What|Removed |Added CC||fred_insura...@yahoo.com --- Comment #5 from

[okular] [Bug 407369] Okular crashes when opening a digitally signed pdf file.

2019-05-30 Thread Juan Ases García
https://bugs.kde.org/show_bug.cgi?id=407369 Juan Ases García changed: What|Removed |Added Resolution|WAITINGFORINFO |DUPLICATE Status|NEEDSINFO

D10859: Improve layout of annotation configuraton dialogs

2019-05-30 Thread Simone Gaiarin
simgunz added a comment. I am also in favor of the white space. Lines or group boxes seem to me too heavy for this type of configuration (and it is what I wanted to remove in the first place). Any idea on how to add the vertical white space in a QFormLayout? Shape fill and Size are now

D10859: Improve layout of annotation configuraton dialogs

2019-05-30 Thread Simone Gaiarin
simgunz updated this revision to Diff 58928. simgunz added a comment. - Fix label buddy not working of PixmapPreviewSelector - Fix keyboard shortcut of Author conflicts with Add (now selected automatically) - Same order of Size and Fill color for GeomShape and Polygon - Make annotation t

D21266: [WIP] Improve documentation of area classes

2019-05-30 Thread David Hurka
davidhurka added a comment. Turns out that nothing is independent of page rotation, just discovered PagePrivate::rotateAt(Okular::Rotation), which transforms everything what is known to rotateAt(). Turns out that two facts turned out which let me wonder about the limited purpose of the

D21266: [WIP] Improve documentation of area classes

2019-05-30 Thread David Hurka
davidhurka added a comment. Turns out that the coordinate system of RegularAreaRect, as it is used by TextPage::textArea(TextSelection), is //not// independent of the page display. textArea() transforms the whole RegularAreaRect with the current totalRotation() of the Page. REPOSITORY R22

[okular] [Bug 334297] Highlighter of the review tool does not work correct in rotated views of the pdf document

2019-05-30 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=334297 --- Comment #4 from David Hurka --- (In reply to David Hurka from comment #3) > Seems like Okular passes the wrong RegularAreaRect to the highlighter tool, > a RegularAreaRect that somehow got the page rotation applied. Experimented a bit on this. Stil

[okular] [Bug 407438] Text hinting causes failure to render some texts

2019-05-30 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=407438 --- Comment #2 from David Hurka --- (In reply to Lukas Jelinek from comment #0) > EXPECTED RESULT > All text are rendered as with text hinting disabled. May I ask how the hinting works for the rendered texts? I enabled hinting in my Okular, and some t

D21490: Draw line caption for non-PDF documents

2019-05-30 Thread Simone Gaiarin
simgunz added a comment. Hi, yes I can try to think of something to expose this feature. As @tobiasdeiminger suggested, I would open a task regarding the straight line tool, where we can also discuss the point on how to deal with the proper line ending (see BUG: 407463). I would like to fi

[okular] [Bug 332117] Feature request: more flexibility in inline notes

2019-05-30 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=332117 avlas changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 407438] Text hinting causes failure to render some texts

2019-05-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=407438 --- Comment #1 from Christoph Feck --- Since I can reproduce with qpdfview (using libpoppler version 0.72 and "Splash" backend), I suspect it is a poppler issue. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 395497] Menubar - No text

2019-05-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=395497 --- Comment #22 from Christoph Feck --- Yes, files in ~/.local override files in /usr. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 332117] Feature request: more flexibility in inline notes

2019-05-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=332117 Albert Astals Cid changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|CONFIRMED

D21490: Draw line caption for non-PDF documents

2019-05-30 Thread Nathaniel Graham
ngraham added subscribers: simgunz, ngraham. ngraham added a comment. Line captions, so cool!!! Maybe @simgunz is interested in the UI angle as a part of his annotations UI overhaul? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21490 To: tobiasdeiminger Cc: ngraha

[okular] [Bug 332117] Feature request: more flexibility in inline notes

2019-05-30 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=332117 --- Comment #8 from David Hurka --- Is this fixed with the new “Typewriter” annotation tool now? These are Typewriter annotations: (In reply to avlas from comment #0) > - transparent background (but not necessarily text as well, as opacity does) > - ma

[okular] [Bug 408102] New: After every Plasma update the toolbar configuration is lost

2019-05-30 Thread Sete
https://bugs.kde.org/show_bug.cgi?id=408102 Bug ID: 408102 Summary: After every Plasma update the toolbar configuration is lost Product: okular Version: unspecified Platform: Manjaro OS: Linux St