[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-01 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=403848 Yuri Chornoivan changed: What|Removed |Added CC||yurc...@ukr.net --- Comment #1 from Yuri Chor

[okular] [Bug 403848] New: Redundant warning on close for unmodified documents in multiple tabs view

2019-02-01 Thread happy
https://bugs.kde.org/show_bug.cgi?id=403848 Bug ID: 403848 Summary: Redundant warning on close for unmodified documents in multiple tabs view Product: okular Version: 1.4.3 Platform: Other OS: Linux

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for all this great work on Okular's mobile interface! The search field shouldn't be touching the line below it; it should have as much padding on top as on bottom. Ju

[okular] [Bug 403772] Support animation from latex package 'animate'

2019-02-01 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=403772 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving thi

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18658: Modify search bar in the contextDrawer

2019-02-01 Thread Carl Schwan
ognarb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ognarb requested review of this revision. REVISION SUMMARY Use a copy of Discover searchBar component, modified. The bigestchange between discover version and this version is that this versio

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug (authored by ognarb). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50678&id=50683 REVISION DETA

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular, ngraham Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb updated this revision to Diff 50678. ognarb marked an inline comment as done. ognarb added a comment. I mean 1.3 and not 1.2 :) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50677&id=50678 BRANCH master REVISION DETAIL https://phabrica

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb added a comment. Let's focus with this patch on fixing the depredations and the small bug only. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular, ngraham Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb added a comment. So I tried to test ScrollView on my computer with a small display, on it look like it's working. But I prefer to revert this change, and reapply the change concerning ScrollView latter, after testing with my android phone with multitouch support. REPOSITORY R223 Ok

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in ThumbnailsBase.qml:21 > 1. Please only bump to 2.0, not 2.5 (see above comment for the reason) > 2. Does this actually work? Every time I've ported anything with a ScrollView > from QQC1 to QQC2, the ScrollView part has needed ext

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Carl Schwan
ognarb updated this revision to Diff 50677. ognarb added a comment. Revert some change REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18637?vs=50630&id=50677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18637 AFFECTED FILES mobile/app/

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Thumbnails.qml:21 > import QtQuick 2.1 > -import QtQuick.Controls 2.0 > +import QtQuick.Controls 2.5 > import org.kde.kirigami 2.0 as Kirigami This will b

[okular] [Bug 306417] opened new tab becomes active though not visible

2019-02-01 Thread Mykola Krachkovsky
https://bugs.kde.org/show_bug.cgi?id=306417 Mykola Krachkovsky changed: What|Removed |Added Resolution|FIXED |INTENTIONAL --- Comment #30 from Mykola Kr

[okular] [Bug 403835] New: Print print empty pages

2019-02-01 Thread Lach Sławomir
https://bugs.kde.org/show_bug.cgi?id=403835 Bug ID: 403835 Summary: Print print empty pages Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priori

D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Nicolas Fella
nicolasfella added a comment. +1 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular Cc: nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

[okular] [Bug 403782] Okular trying to save a PDF to an URL location

2019-02-01 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=403782 --- Comment #7 from avlas --- I realized of two things: 1) This is not only about PDF's, it also happens for remote images (e.g., in a browser) 2) In the "Save As" window: While the path is that of the remote URL, the content that you see is that of

[okular] [Bug 403782] Okular trying to save a PDF to an URL location

2019-02-01 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=403782 --- Comment #6 from David Hurka --- I thought a bit about this. (In reply to David Hurka from comment #5) > Better would be > [_] If document URL is non-writable [...] This could be confusing, if URLs randomly appear to be non-writable. Also, other K