ngraham added inline comments. INLINE COMMENTS
> ngraham wrote in ThumbnailsBase.qml:21 > 1. Please only bump to 2.0, not 2.5 (see above comment for the reason) > 2. Does this actually work? Every time I've ported anything with a ScrollView > from QQC1 to QQC2, the ScrollView part has needed extensive work. Can you > make sure all functionality works--especially anything related to the scroll > view? E.g. does it actually become scrollable if you resize the window to be > very small? I meant, this can go up 2.0, just not 2.5. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18637 To: ognarb, #okular, ngraham Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid
