KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 163 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/163/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Aug 2018 01:45:27 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT

[okular] [Bug 397463] New: okular session management

2018-08-14 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463 Bug ID: 397463 Summary: okular session management Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist

D14820: Select current format on the configure backend dialog

2018-08-14 Thread Oliver Sander
sander added a comment. Fine with me. If you want I can post a separate QHash -> QMap cleanup patch. Either way, for me this patch can land in git. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14820 To: aacid Cc: sander, okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

[okular] [Bug 397383] Calculation with many trailing zeros - Rounding doesn't work

2018-08-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397383 --- Comment #4 from Albert Astals Cid --- This is solved by https://phabricator.kde.org/D13171 + https://phabricator.kde.org/D13172 -- You are receiving this mail because: You are the assignee for the bug.

D14748: Add signature properties dialog

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14748 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14734: Add revision viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14734 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14696: Add certificate viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14696 To: chinmoyr, aacid, ngraham Cc: okular-devel, ngraham, aacid

D14656: Add utitlity functions for use in digital signature verification

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14656 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14655 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14654 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14816: Add signature panel

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14816 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14654: Add API for signature form field, and other helper classes

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:0696f4cb55a7: Add API for signature form field, and other helper classes (authored by chinmoyr). REPOSITORY R223 Oku

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:aed6df314baa: Show signature validation summary as popup (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SIN

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:536095bd9700: Add SignatureEdit widget for FormFieldSignature (authored by chinmoyr). REPOSITORY R223 Okular CHANGE

D14816: Add signature panel

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:bb1dbebb4f68: Add signature panel (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https:/

D14748: Add signature properties dialog

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:bf7d548a4872: Add signature properties dialog (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPD

D14656: Add utitlity functions for use in digital signature verification

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:53e095439724: Add utitlity functions for use in digital signature verification (authored by chinmoyr). REPOSITORY R2

D14696: Add certificate viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:35965f914548: Add certificate viewer (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE htt

D14734: Add revision viewer

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:b7a841e8eed1: Add revision viewer (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https:/

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:29cea9796ca7: Add unit test for SignatureFormField (authored by chinmoyr). REPOSITORY R223 Okular CHANGES SINCE LAS

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:d6e0577a0141: Reimplement signature form field and related utility classes in poppler… (authored by chinmoyr). REPOSIT

D12901: Add unit test for SignatureFormField

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependencies, added: D14655: Reimplement signature form field and related utility classes in poppler generator; removed: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12901 To: chinmoyr, aacid Cc: oku

D11723: Add FormFieldSignature to Okular namespace

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D12901: Add unit test for SignatureFormField. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D14655: Reimplement signature form field and related utility classes in poppler generator

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D12901: Add unit test for SignatureFormField. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14655 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependency: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13483 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D14816: Add signature panel

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13484: Show signature validation summary as popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14816 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 39701. chinmoyr edited the summary of this revision. chinmoyr added a dependency: D14816: Add signature panel. chinmoyr added a comment. Went with @ngraham's suggestion of showing a separate message for signature. But the "Show Signature" button will s

D13484: Show signature validation summary as popup

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependency: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-08-14 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D13484: Show signature validation summary as popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

[okular] [Bug 397444] Image Copy to Clipboard does not work on Wayland

2018-08-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397444 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

[okular] [Bug 397444] Image Copy to Clipboard does not work on Wayland

2018-08-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=397444 --- Comment #2 from avin...@gmail.com --- (In reply to Albert Astals Cid from comment #1) > I don't see how this can be an Okular problem. > > The only thing we do is > > QClipboard *cb = QApplication::clipboard(); >

[okular] [Bug 397444] Image Copy to Clipboard does not work on Wayland

2018-08-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397444 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Status|UNCONFIRME

[okular] [Bug 397444] New: Image Copy to Clipboard does not work on Wayland

2018-08-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=397444 Bug ID: 397444 Summary: Image Copy to Clipboard does not work on Wayland Product: okular Version: 1.4.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: n

D14820: Select current format on the configure backend dialog

2018-08-14 Thread Albert Astals Cid
aacid added a comment. In D14820#308569 , @sander wrote: > Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the

D14820: Select current format on the configure backend dialog

2018-08-14 Thread Oliver Sander
sander added a comment. Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them righ

D14809: Make 'configure generators' dialog open with current generator selected

2018-08-14 Thread Oliver Sander
sander abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14809 To: sander, #okular Cc: aacid, okular-devel, ngraham

D14809: Make 'configure generators' dialog open with current generator selected

2018-08-14 Thread Oliver Sander
sander added a comment. I tested https://phabricator.kde.org/D14820 and it works nicely. Thanks for your effort! I also like the fact that the entries get sorted now. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14809 To: sander, #okular Cc: aacid, okular-devel,

D14809: Make 'configure generators' dialog open with current generator selected

2018-08-14 Thread Albert Astals Cid
aacid added a comment. I made https://phabricator.kde.org/D14820 (you need latest branch since i did a change to make the sorting at least stable in the config dialog) which doesn't need changing the API, which i think it's better since it won't break plugins that may exist outside the okula

D14820: Select current format on the configure backend dialog

2018-08-14 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. aacid requested review of this revision. REPOSITORY R223 Okular BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D14820 AFFECTED FILES

D10298: Fix searching in RTL PDFs

2018-08-14 Thread Nathaniel Graham
ngraham added a comment. Thanks! Just so you know, the work in this patch moved to D10455: Add RTL support for search, copy & paste in pdf . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10298 To: ngraham, #okular Cc: okular-deve

[okular] [Bug 397429] Spurious empty file 'empty.cpp' in generators/spectre/conf

2018-08-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397429 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|