aacid added a comment.
In D14820#308569 <https://phabricator.kde.org/D14820#308569>, @sander wrote: > Looking good! Concerning the preparatory commit 9ba8dd2cd7838c626af79a4edcd8b8437205cc02 <https://phabricator.kde.org/R223:9ba8dd2cd7838c626af79a4edcd8b8437205cc02> , which copies the list of loaded generators from a QHash to a QMap: Why not use a QMap for them right away? Certainly the number of generators is low enough such that the efficiency differences between a QHash and a QMap become negligible? Yes, there is some copying, but it's faster than you blinking so let's not worry about that. I also thought about changing the hash to map, should have not implications, but yeah prefered to limit changes only to that same function. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14820 To: aacid Cc: sander, okular-devel, ngraham, aacid
