aacid added a comment.
This looks good to me in a "i've no idea what this does but tests still pass"
way.
Ideally one would get this into KDE Applications 17.08.x but given it's a big
ish change, my suggestion is get it into master for KDE Applications 17.12.0
and this way people that u
https://bugs.kde.org/show_bug.cgi?id=383651
--- Comment #3 from Nate Graham ---
(in combination with https://phabricator.kde.org/D7688, of course)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=383651
Nate Graham changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #2 from Nate Graham --
aacid added a comment.
In https://phabricator.kde.org/D7662#143055, @sander wrote:
> > This applies to all highlights, i.e. text selection too, are you sure we
want that?
>
> Are you sure we don't have that anyway? I get a darker-blue rectangle
around text selections even without th
aacid added a comment.
HAVE_POPPLER_0_60 doesn't get defined anywhere ;)
See generators/poppler/CMakeLists.txt
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7688
To: sander, #okular
Cc: aacid
aacid added a comment.
In https://phabricator.kde.org/D7671#142933, @progwolff wrote:
> In https://phabricator.kde.org/D7671#142826, @aacid wrote:
>
> > I don't know who told you this is the correct behaviour of kdirwatch, but
i kind of disagree.
> >
> > Since we're not watching t
aacid added a comment.
In https://phabricator.kde.org/D7671#142844, @rkflx wrote:
> Albert: Do you remember why
https://phabricator.kde.org/R223:f93ccd7923491c6b1412ba5cb1fe0711e44496d8 was
necessary? There is no bug linked and no autotest. Using just the commit
message as a testcase, w
https://bugs.kde.org/show_bug.cgi?id=381383
Nate Graham changed:
What|Removed |Added
Status|RESOLVED|VERIFIED
--- Comment #3 from Nate Graham ---
Nic
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:075b8153af55: Search for Kirigami (authored by
heikobecker).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7241?vs=17986&id=19186
REVISION DETAIL
https://phabric
sander added a comment.
> This applies to all highlights, i.e. text selection too, are you sure we
want that?
Are you sure we don't have that anyway? I get a darker-blue rectangle around
text selections even without the patch.
> There's something weird going on with the drawing, i
sander created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
Previously, rasterized printing would use the QPrinter backend whenever
annotations were to be printed, and fall back to the convert-to-ps
toolchain otherwise. Effectively, this meant that p
progwolff added a comment.
In https://phabricator.kde.org/D7671#142826, @aacid wrote:
> I don't know who told you this is the correct behaviour of kdirwatch, but i
kind of disagree.
>
> Since we're not watching the file but *also* the folder.
From the KDirWatch class reference
12 matches
Mail list logo
