Re: Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

2017-03-12 Thread Albert Astals Cid
> On March 11, 2017, 4:51 p.m., Albert Astals Cid wrote: > > ui/findbar.cpp, line 50 > > > > > > Why this line? > > Marco Scarpetta wrote: > Because when we call *m_automaticSearchAct->setChecked( > Okular::

Re: Review Request 129785: Stop debug spam in release builds

2017-03-12 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129785/ --- (Updated March 12, 2017, 10:18 p.m.) Status -- This change has been

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

2017-03-12 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/ --- (Updated March 12, 2017, 10:17 p.m.) Status -- This change has been

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

2017-03-12 Thread Albert Astals Cid
> On March 11, 2017, 5:03 p.m., Albert Astals Cid wrote: > > Which compiler are you using that gives you those warnings? > > Miklós Máté wrote: > 3 months ago I think I used gcc 5.something. Currently I have gcc 6.3, > and it doesn't issue a warning for the dvi generator. Yay for fewer fals

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

2017-03-12 Thread Lukas Schneiderbauer
https://bugs.kde.org/show_bug.cgi?id=362856 Lukas Schneiderbauer changed: What|Removed |Added CC||lukas.schneiderbauer@gmail.

Re: Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

2017-03-12 Thread Marco Scarpetta
> On Mar. 11, 2017, 4:51 p.m., Albert Astals Cid wrote: > > ui/findbar.cpp, line 50 > > > > > > Why this line? Because when we call *m_automaticSearchAct->setChecked( Okular::Settings::searchAutomatic() )* and