Re: Review Request 129785: Stop debug spam in release builds

2017-03-11 Thread Luigi Toscano
> On Gen. 7, 2017, 2:24 p.m., Luigi Toscano wrote: > > Does it mean that you can't override the setting using kdebugsettings? If > > it's the case, it's probably a no-go. > > Miklós Máté wrote: > Oh, sorry I didn't realize how important this is: > > "/usr/local/lib/x86_64-linux-gnu/plu

Re: Review Request 129785: Stop debug spam in release builds

2017-03-11 Thread Miklós Máté
> On Jan. 7, 2017, 2:24 p.m., Luigi Toscano wrote: > > Does it mean that you can't override the setting using kdebugsettings? If > > it's the case, it's probably a no-go. > > Miklós Máté wrote: > Oh, sorry I didn't realize how important this is: > > "/usr/local/lib/x86_64-linux-gnu/plu

Re: Review Request 129284: Don't jump up 1/2 page on file reload if scrolled to page (with left-right cursor)

2017-03-11 Thread Miklós Máté
> On March 11, 2017, 6:15 p.m., Albert Astals Cid wrote: > > What do you mean with "if scrolled to page (with left-right cursor)"? > > > > Maybe you can add an autotest for this? When you press cursor left or cursor right it scrolls the document to previous/next page, and it sets only the page

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

2017-03-11 Thread Miklós Máté
> On March 11, 2017, 6:03 p.m., Albert Astals Cid wrote: > > Which compiler are you using that gives you those warnings? 3 months ago I think I used gcc 5.something. Currently I have gcc 6.3, and it doesn't issue a warning for the dvi generator. Yay for fewer false positives. - Miklós -

Re: Review Request 124276: Separated bookmarks.xml so that every document have its own bookmarks file

2017-03-11 Thread Nikola Nikolic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124276/ --- (Updated March 11, 2017, 5:57 p.m.) Status -- This change has been d

Re: Review Request 124276: Separated bookmarks.xml so that every document have its own bookmarks file

2017-03-11 Thread Albert Astals Cid
> On Aug. 26, 2015, 9:24 p.m., Albert Astals Cid wrote: > > Ping? No answer in 1.5 years :/ Discarding. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124276/#review84426

Re: Review Request 123905: Solution to Bug 271986 - A "Go to Bookmark..." action similar to "Go to Page..."

2017-03-11 Thread Nikola Nikolic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123905/ --- (Updated March 11, 2017, 5:56 p.m.) Status -- This change has been d

Re: Review Request 123905: Solution to Bug 271986 - A "Go to Bookmark..." action similar to "Go to Page..."

2017-03-11 Thread Albert Astals Cid
> On July 16, 2015, 11:21 p.m., Albert Astals Cid wrote: > > Looks good but needs improvements: > > - Double clicking on the list item should activate it > > - Ok should be disabled if there's no selected item, otherwise i open the > > dialog, click ok, and nothing happens > > > > also you ne

Re: Review Request 126378: remove kactivities on windows

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126378/#review102801 --- Patch doesn't apply to master. - Albert Astals Cid On Dec

Re: Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

2017-03-11 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125020/ --- (Updated March 11, 2017, 5:52 p.m.) Status -- This change has been d

Re: Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

2017-03-11 Thread Albert Astals Cid
> On Sept. 16, 2015, 8:59 p.m., Albert Astals Cid wrote: > > Actually, if you just leave the libokularGenerator_comicbook.desktop change > > this should be ok, tells okular this plugin may know how to open rar files, > > so if you use the file dialog or the command line it should work, but it

Re: Review Request 125500: [okular] epub: Add "file" scheme for resourceUrl

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125500/#review102799 --- Patch doesn't apply anymore to master. - Albert Astals Cid

Re: Review Request 128062: Tabs should be more homogeneously sized

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128062/#review102798 --- Patch doesn't apply to current master - Albert Astals Cid

Re: Review Request 129893: Implement continuous search

2017-03-11 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated March 11, 2017, 5:41 p.m.) Review request for Okular, KDE Usabil

Re: Review Request 126809: Allow to rotate the page view using two-finger pinches on a touchscreen

2017-03-11 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126809/ --- (Updated March 11, 2017, 5:34 p.m.) Status -- This change has been m

Re: Review Request 126809: Allow to rotate the page view using two-finger pinches on a touchscreen

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126809/#review102797 --- Ship it! Ship It! - Albert Astals Cid On Oct. 16, 2016

Re: Review Request 129284: Don't jump up 1/2 page on file reload if scrolled to page (with left-right cursor)

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129284/#review102795 --- What do you mean with "if scrolled to page (with left-right

Re: Review Request 129287: Set viewport only once

2017-03-11 Thread Miklós Máté
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129287/ --- (Updated March 11, 2017, 8:11 p.m.) Status -- This change has been m

Re: Review Request 129422: Fix for disabling thumbnail panel on startup. Added option in general settings dialog.

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129422/#review102794 --- I don't think adding an option for this makes any sense. -

Re: Review Request 129893: Implement continuous search

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102793 --- Someone from accessibility: ping? - Albert Astals Cid On

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review102792 --- Which compiler are you using that gives you those warnings?

Re: Review Request 129785: Stop debug spam in release builds

2017-03-11 Thread Albert Astals Cid
> On Jan. 7, 2017, 1:24 p.m., Luigi Toscano wrote: > > Does it mean that you can't override the setting using kdebugsettings? If > > it's the case, it's probably a no-go. > > Miklós Máté wrote: > Oh, sorry I didn't realize how important this is: > > "/usr/local/lib/x86_64-linux-gnu/plu

Re: Review Request 127366: Resize annotations

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127366/#review102789 --- Feature Freeze date for 17.04 is March 23, i suggest you try

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

2017-03-11 Thread Albert Astals Cid
> On Jan. 23, 2017, 11:07 p.m., Albert Astals Cid wrote: > > This regresses in this file > > > > http://www.postgresql.org/files/documentation/pdf/8.4/postgresql-8.4-A4.pdf > > > > Open that file with this patch, search for " in ", i.e "in" with a space > > before and after > > > > An occurre

Re: Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129956/#review102788 --- ui/findbar.cpp (line 50)

Re: Review Request 129999: Allow to create bookmarks from the TOC

2017-03-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review102787 --- I don't think this is a good way to implement this, it'll be

[okular] [Bug 377487] Find and List all instances of a searched word

2017-03-11 Thread Miguel
https://bugs.kde.org/show_bug.cgi?id=377487 --- Comment #4 from Miguel --- Created attachment 104506 --> https://bugs.kde.org/attachment.cgi?id=104506&action=edit Search panel in Gnome Evince (similar to "Advanced search" in Adobe Acrobat) -- You are receiving this mail because: You are the a

[okular] [Bug 377487] Find and List all instances of a searched word

2017-03-11 Thread Miguel
https://bugs.kde.org/show_bug.cgi?id=377487 Miguel changed: What|Removed |Added CC||mjul...@free.fr --- Comment #3 from Miguel --- I didn

[okular] [Bug 377493] New: Music staff notation is often impossible to read due to object placement and line spacing

2017-03-11 Thread Tom
https://bugs.kde.org/show_bug.cgi?id=377493 Bug ID: 377493 Summary: Music staff notation is often impossible to read due to object placement and line spacing Product: okular Version: unspecified Platform: Other

[okular] [Bug 377487] Find and List all instances of a searched word

2017-03-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=377487 --- Comment #2 from kritins...@gmail.com --- I didn't know of that, it is quite similar to what I wanted, thank you. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

2017-03-11 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=377487 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1 from

[okular] [Bug 377487] New: Find and List all instances of a searched word

2017-03-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=377487 Bug ID: 377487 Summary: Find and List all instances of a searched word Product: okular Version: unspecified Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED