----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129999/#review102787 -----------------------------------------------------------
I don't think this is a good way to implement this, it'll be confusing because people won't know why suddenly things behave differenly. I think it would make much more sense to implement a right click menu on the TOC items themselves that has a "Bookmark" menu entry. - Albert Astals Cid On March 9, 2017, 11:33 a.m., Gilbert Assaf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129999/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 11:33 a.m.) > > > Review request for Okular. > > > Bugs: 190203 > http://bugs.kde.org/show_bug.cgi?id=190203 > > > Repository: okular > > > Description > ------- > > If a bookmark is created from the TOC view, the text of the selected TOC item > text is automatically used. Otherwise the behavior stays unchanged. > > > Diffs > ----- > > part.cpp 198197a5f4f5f09b3e30efbc7798ecef5f637ca7 > ui/toc.h 5e7fe2a39ee5245379844fa0392a628a6e7f5c78 > ui/toc.cpp a205ad1c577b81e9059620d03ffd86bab033813c > > Diff: https://git.reviewboard.kde.org/r/129999/diff/ > > > Testing > ------- > > > Thanks, > > Gilbert Assaf > >
