Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Oliver Sander
> On Nov. 24, 2015, 10:52 nachm., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Mont

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Albert Astals Cid
> On nov. 24, 2015, 10:52 p.m., Albert Astals Cid wrote: > > > Reason: it expects the dialog to have a KLineEdit member with object name > > > 'name'. > > > > Who does expect that? > > Oliver Sander wrote: > The unit test 'editdrawingtooldialogtest', originally written by Laurent > Montel

Re: [Okular-devel] Review Request 126158: Set objectName for 'm_name'

2015-11-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/#review4 --- Ship it! Ship It! - Albert Astals Cid On nov. 24, 2015, 7:

[Okular-devel] [okular] [Bug 272258] okular should have rotate left and right shortcuts in the toolbar

2015-11-26 Thread matthias sweertvaegher via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=272258 matthias sweertvaegher changed: What|Removed |Added CC||matthias.sweertvaegher@gmai